Page MenuHomePhabricator

When selecting Ferret ngrams, select term ngrams (not raw ngrams) for term search
ClosedPublic

Authored by epriestley on Sep 8 2017, 4:13 PM.
Tags
None
Referenced Files
F13236335: D18581.diff
Tue, May 21, 9:14 AM
F13235097: D18581.diff
Tue, May 21, 4:15 AM
F13227510: D18581.diff
Mon, May 20, 3:52 AM
F13224714: D18581.id44618.diff
Sun, May 19, 10:21 AM
F13193063: D18581.id.diff
Sun, May 12, 11:58 AM
F13193051: D18581.id44621.diff
Sun, May 12, 11:53 AM
F13192833: D18581.id44618.diff
Sun, May 12, 9:57 AM
F13189542: D18581.diff
Sat, May 11, 6:09 AM
Subscribers
None

Details

Summary

Ref T12819. For queries like v0.2, we would incorrectly search for ngrams including 0.2, but this is only a substring ngram: the term corpus splits this into v0 and 2, so 0.2 is not in the ngrams table.

When executing term queries, search for term ngrams instead. This makes "v0.2" work properly again.

Test Plan

Searched for "v0.2", found a task with "v0.2" in the title.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable