Page MenuHomePhabricator

Split Ferret engine strings for tokenization on any sequence of whitespace
ClosedPublic

Authored by epriestley on Sep 8 2017, 3:08 PM.
Tags
None
Referenced Files
F13239184: D18579.id44616.diff
Wed, May 22, 12:54 AM
F13236326: D18579.diff
Tue, May 21, 9:13 AM
F13217671: D18579.diff
Sat, May 18, 6:58 AM
F13180615: D18579.id44619.diff
Thu, May 9, 1:30 AM
F13178964: D18579.diff
Wed, May 8, 8:49 PM
F13174637: D18579.id.diff
Wed, May 8, 12:21 AM
Unknown Object (File)
Sat, May 4, 6:40 PM
Unknown Object (File)
Tue, Apr 30, 11:23 PM
Subscribers
None

Details

Summary

Ref T12819. Currently, strings are split only on spaces, but newlines (and, if they exist, tabs) should also split strings.

Without this, we can fail to get the proper term boundary tokens for words which begin at the start of a line or end at the end of a line.

Test Plan

Reindexed a document with "xyz\nabc", saw "yz " and " ab" term boundary tokens generate properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable