Page MenuHomePhabricator
Differential D18570

Update passphrase edit UI
ClosedPublic
Actions

Authored by chad on Sep 7 2017, 8:09 PM.
Tags
None
Referenced Files
F13236311: D18570.diff
Tue, May 21, 9:09 AM
F13214880: D18570.diff
Fri, May 17, 1:32 PM
F13213060: D18570.diff
Fri, May 17, 7:20 AM
F13192979: D18570.id44583.diff
Sun, May 12, 11:08 AM
F13192590: D18570.id44603.diff
Sun, May 12, 8:54 AM
Unknown Object (File)
Mon, May 6, 6:56 PM
Unknown Object (File)
Sun, May 5, 1:52 PM
Unknown Object (File)
Fri, May 3, 6:43 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPf1193afa94bf: Update passphrase edit UI
Summary

Updates creating credentials

Test Plan

create some notes

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad created this revision.Sep 7 2017, 8:09 PM
Herald added a subscriber: Korvin. · View Herald TranscriptSep 7 2017, 8:09 PM
Harbormaster completed remote builds in B18366: Diff 44583.Sep 7 2017, 8:10 PM
epriestley accepted this revision.Sep 7 2017, 8:51 PM

The dialog version also gets hit via "New Credential" in Diffusion, maybe worth double-checking.

This revision is now accepted and ready to land.Sep 7 2017, 8:51 PM
Closed by commit rPf1193afa94bf: Update passphrase edit UI (authored by Chad Little <chad@phacility.com>). · Explain WhySep 7 2017, 9:13 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Sep 7 2017, 9:13 PM

seems ok

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
controller/
2 lines
passphrase/
controller/
9 lines
17 lines

Diff 44603

View Options

src/applications/herald/controller/HeraldRuleController.php

Loading...
View Options

src/applications/passphrase/controller/PassphraseCredentialCreateController.php

Loading...
View Options

src/applications/passphrase/controller/PassphraseCredentialEditController.php

Loading...
Phabricator · Built by Phacility