Page MenuHomePhabricator

Use the Ferret engine fulltext document table to drive auxiliary fulltext constraints
ClosedPublic

Authored by epriestley on Sep 7 2017, 3:49 PM.
Tags
None
Referenced Files
F13283670: D18550.diff
Sun, Jun 2, 4:06 PM
F13247786: D18550.diff
Thu, May 23, 10:29 PM
F13245758: D18550.diff
Thu, May 23, 6:13 AM
F13237927: D18550.id44557.diff
Tue, May 21, 4:01 PM
F13236259: D18550.diff
Tue, May 21, 8:56 AM
F13223964: D18550.diff
Sun, May 19, 5:35 AM
F13191907: D18550.id44586.diff
Sun, May 12, 2:19 AM
F13178788: D18550.diff
Wed, May 8, 8:41 PM
Subscribers
None

Details

Summary

Ref T12819. I started trying to get individual engines to drive these constraints (e.g., ManiphestTaskQuery can do most of the work) but this is a big pain, especially since most engines don't support "any owner" or "no owner", and not everything has an owner, and so on and so on. Going down this path would have meant a huge pile of stub functions everywhere, I think.

Instead, drive these through the main engine using the fulltext document table, which already has everything we need to apply these constraints in a uniform way.

Also tweak some parts of query construction and result ordering.

Test Plan

Searched for documents by author, owner, unowned, any owner, tags, subscribers, fulltext in global search. Got sensible results without any application-specific code.

Diff Detail

Repository
rP Phabricator
Branch
ferret4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18340
Build 24686: Run Core Tests
Build 24685: arc lint + arc unit