Add a "Reviewed By" Herald condition
AbandonedPublic
Actions

Authored by joshuaspence on Aug 9 2017, 10:30 PM.

Tags

None

Referenced Files

	F13256420: D18379.id.diff
	Sat, May 25, 11:53 AM

	F13236197: D18379.diff
	Tue, May 21, 8:42 AM

	F13214539: D18379.diff
	Fri, May 17, 11:16 AM

	F13200290: D18379.diff
	Mon, May 13, 10:52 PM

	Unknown Object (File)
	Mon, May 6, 10:44 PM

	Unknown Object (File)
	Mon, May 6, 4:38 AM

	Unknown Object (File)
	Apr 28 2024, 9:31 AM

	Unknown Object (File)
	Apr 27 2024, 4:14 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Summary

WIP

Test Plan

WIP

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17970
Build 24129: Run Core Tests
Build 24128: arc lint + arc unit

Event Timeline

joshuaspence created this revision.Aug 9 2017, 10:30 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 9 2017, 10:30 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster completed remote builds in B17970: Diff 44171.Aug 9 2017, 10:31 PM

Probably obsoleted by D18839?

This revision now requires changes to proceed.May 14 2019, 2:28 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 14 2019, 2:28 PM

joshuaspence abandoned this revision.May 14 2019, 11:25 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

diffusion/

herald/

DiffusionCommitRevisionReviewedByHeraldField.php

43 lines

Diff 44171

View Options

src/__phutil_library_map__.php