Page MenuHomePhabricator
Differential D16624

Remove a flaky test which can fail under load
ClosedPublic
Actions

Authored by epriestley on Sep 28 2016, 10:10 PM.
Tags
None
Referenced Files
F13283116: D16624.id40023.diff
Sun, Jun 2, 12:50 PM
F13272760: D16624.diff
Thu, May 30, 8:29 PM
F13213912: D16624.diff
Fri, May 17, 8:13 AM
F13191324: D16624.id40023.diff
Sat, May 11, 7:26 PM
Unknown Object (File)
Tue, May 7, 9:28 AM
Unknown Object (File)
May 3 2024, 9:18 AM
Unknown Object (File)
May 2 2024, 11:49 PM
Unknown Object (File)
Apr 30 2024, 5:32 PM
View All Files
Subscribers
None
Tokens
"Y So Serious" token, awarded by yelirekim.

Details

Reviewers
chad
Commits
rPHU19ef6e504d26: Remove a flaky test which can fail under load
Summary

This test can fail incorrectly when the host is under load (e.g., several builds running simultaneously).

Essentially everything it tests is tested more reliably by adjacent tests.

Test Plan

Laughed robustly.

Diff Detail

Repository
rPHU libphutil
Branch
loadtest
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13912
Build 18009: Run Core Tests
Build 18008: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40023.Sep 28 2016, 10:10 PM
epriestley retitled this revision from to Remove a flaky test which can fail under load.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Sep 28 2016, 10:54 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 28 2016, 10:54 PM
Closed by commit rPHU19ef6e504d26: Remove a flaky test which can fail under load (authored by epriestley, committed by epriestley). · Explain WhySep 28 2016, 11:15 PM
This revision was automatically updated to reflect the committed changes.
yelirekim awarded a token.Sep 28 2016, 11:46 PM

Revision Contents
Changeset List

PathSize
src/
future/
exec/
__tests__/
12 lines

Diff 40023

View Options

src/future/exec/__tests__/ExecFutureTestCase.php

Loading...
Phabricator · Built by Phacility