Page MenuHomePhabricator
Differential D16342

In Task Graphs, provide a parent/child hint and fix weird strikethrough
ClosedPublic
Actions

Authored by epriestley on Jul 28 2016, 6:48 PM.
Tags
None
Referenced Files
F13284135: D16342.diff
Mon, Jun 3, 12:43 AM
F13281950: D16342.diff
Sun, Jun 2, 11:30 AM
F13263214: D16342.id.diff
Mon, May 27, 7:57 AM
F13225824: D16342.id39300.diff
Sun, May 19, 5:36 PM
F13187212: D16342.diff
Sat, May 11, 4:24 AM
Unknown Object (File)
Tue, May 7, 7:30 AM
Unknown Object (File)
Sun, May 5, 12:06 PM
Unknown Object (File)
Sun, May 5, 12:06 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4788: Allow "Edit Dependencies" both ways (blocking and depending)
T11386: Weird effect on closed tasks in graph view
Commits
rPcebf4bbec6ba: In Task Graphs, provide a parent/child hint and fix weird strikethrough
Summary

Fixes T11386. Ref T4788.

  • Apparently fix weird strikethrough effect? Spooky!
  • Provide a little icon hint in the left column about which tasks are direct parents/children, vs just reachable somehow. I don't think this is super useful/important, but seems maybe nice?
Test Plan

Screen Shot 2016-07-28 at 11.45.22 AM.png (364×626 px, 45 KB)

Diff Detail

Repository
rP Phabricator
Branch
task3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13176
Build 16868: Run Core Tests
Build 16867: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39300.Jul 28 2016, 6:48 PM
epriestley retitled this revision from to In Task Graphs, provide a parent/child hint and fix weird strikethrough.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T11386: Weird effect on closed tasks in graph view, T4788: Allow "Edit Dependencies" both ways (blocking and depending).
Herald edited edge metadata. · View Herald TranscriptJul 28 2016, 6:48 PM
chad accepted this revision.Jul 28 2016, 6:49 PM
chad edited edge metadata.

suchwow

This revision is now accepted and ready to land.Jul 28 2016, 6:49 PM
Closed by commit rPcebf4bbec6ba: In Task Graphs, provide a parent/child hint and fix weird strikethrough (authored by epriestley, committed by epriestley). · Explain WhyJul 28 2016, 6:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
infrastructure/
graph/
55 lines
4 lines
webroot/
rsrc/
css/
aphront/
4 lines

Diff 39300

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/graph/ManiphestTaskGraph.php

Loading...
View Options

src/infrastructure/graph/PhabricatorObjectGraph.php

Loading...
View Options

webroot/rsrc/css/aphront/table-view.css

Loading...
Phabricator · Built by Phacility