Differential D16340

Fix "Blocked" task queries with multiple subtasks, and update language
ClosedPublic
Actions

Authored by epriestley on Jul 28 2016, 5:21 PM.

Tags

None

Referenced Files

	F13229316: D16340.id39294.diff
	Mon, May 20, 3:42 PM

	F13218159: D16340.id.diff
	Sat, May 18, 10:30 AM

	F13212404: D16340.diff
	Fri, May 17, 6:40 AM

	F13198113: D16340.id39294.diff
	Mon, May 13, 4:14 AM

	F13195970: D16340.diff
	Sun, May 12, 10:48 PM

	F13179806: D16340.diff
	Wed, May 8, 9:27 PM

	Unknown Object (File)
	Mon, May 6, 9:27 PM

	Unknown Object (File)
	Sat, May 4, 7:06 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T8126: Issue with using the filter "Blocked: Show Tasks Not Blocked By Other Tasks" in Queries

Commits

rPc715b42f3612: Fix "Blocked" task queries with multiple subtasks, and update language

Summary

Ref T8126. See that task for discussion. This change:

Updates language to be more consistent ("Parents", "Subtasks") since I moved us away from the often-confusing "Block" language in T4788.
Fixes bugs with finding the wrong set of tasks if tasks have a mixture of open and closed subtasks or parents.

Test Plan

Created four tasks: no subtasks, one closed subtask, one open subtask, mixture of open and closed subtasks.
Created four more tasks: no parents, one closed parent, one open parent, mixture of open and closed parents.
Searched for all this stuff, got the proper results:

Screen Shot 2016-07-28 at 10.14.13 AM.png (1×1 px, 222 KB)

Screen Shot 2016-07-28 at 10.11.46 AM.png (1×1 px, 193 KB)

Screen Shot 2016-07-28 at 10.14.07 AM.png (1×1 px, 223 KB)

Screen Shot 2016-07-28 at 10.11.49 AM.png (1×1 px, 193 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39294.Jul 28 2016, 5:21 PM

epriestley retitled this revision from to Fix "Blocked" task queries with multiple subtasks, and update language.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T8126: Issue with using the filter "Blocked: Show Tasks Not Blocked By Other Tasks" in Queries.

awwyiss

This revision is now accepted and ready to land.Jul 28 2016, 5:29 PM

epriestley mentioned this in T8126: Issue with using the filter "Blocked: Show Tasks Not Blocked By Other Tasks" in Queries.Jul 28 2016, 5:31 PM

Closed by commit rPc715b42f3612: Fix "Blocked" task queries with multiple subtasks, and update language (authored by epriestley, committed by epriestley). · Explain WhyJul 28 2016, 6:00 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D15560: Improve task dependency queries (Fixes T8126).Jul 28 2016, 6:05 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

query/

ManiphestTaskQuery.php

166 lines

ManiphestTaskSearchEngine.php

30 lines

Diff 39298

src/applications/maniphest/query/ManiphestTaskQuery.php

Loading...

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

Loading...