Page MenuHomePhabricator

Improve "thread" rendering of unusually-shaped graphs
ClosedPublic

Authored by epriestley on Jul 1 2016, 5:11 PM.
Tags
None
Referenced Files
F13269638: D16216.diff
Wed, May 29, 6:33 AM
F13257123: D16216.diff
Sat, May 25, 8:29 PM
F13234908: D16216.diff
Tue, May 21, 3:54 AM
F13212840: D16216.diff
Fri, May 17, 7:08 AM
F13209759: D16216.id39012.diff
Fri, May 17, 1:58 AM
F13197726: D16216.diff
Mon, May 13, 12:26 AM
F13184476: D16216.id39012.diff
Fri, May 10, 7:13 PM
Unknown Object (File)
Sun, May 5, 12:06 PM
Subscribers
None

Details

Summary

Ref T4788. This fixes all the bugs I was immediately able to catch:

  • "Directory-Like" graph shapes could draw too many vertical lines.
  • "Reverse-Directory-Like" graph shapes could draw too few vertical lines.
  • Terminated, branched graph shapes drew the very last line to the wrong place.

This covers the behavior with tests, so we should be able to fix more stuff later without breaking anything.

Test Plan
  • Added failing tests and made them pass.

Screen Shot 2016-07-01 at 10.05.28 AM.png (368×481 px, 42 KB)

Screen Shot 2016-07-01 at 9.52.26 AM.png (328×418 px, 36 KB)

Screen Shot 2016-07-01 at 9.55.31 AM.png (370×380 px, 40 KB)

Screen Shot 2016-07-01 at 9.52.10 AM.png (330×360 px, 35 KB)

Diff Detail

Repository
rP Phabricator
Branch
graph4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12884
Build 16431: Run Core Tests
Build 16430: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Improve "thread" rendering of unusually-shaped graphs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
src/infrastructure/diff/view/__tests__/PHUIDiffGraphViewTestCase.php
19–26

O.O

chad edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2016, 5:59 PM
This revision was automatically updated to reflect the committed changes.