Page MenuHomePhabricator
Differential D15964

Hover hint on calendar list items should appear on the most convenient side of the item
ClosedPublic
Actions

Authored by lpriestley on May 23 2016, 5:26 PM.
Tags
None
Referenced Files
F13234259: D15964.diff
Tue, May 21, 3:14 AM
F13226243: D15964.id38441.diff
Sun, May 19, 7:59 PM
F13215203: D15964.id.diff
Fri, May 17, 3:46 PM
F13215179: D15964.diff
Fri, May 17, 3:33 PM
F13213616: D15964.id38436.diff
Fri, May 17, 7:56 AM
F13196948: D15964.diff
Sun, May 12, 11:42 PM
F13184698: D15964.id.diff
Fri, May 10, 10:19 PM
Unknown Object (File)
Thu, May 2, 3:00 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9606: "Calendar" tab on user profiles is pretty junky
Commits
rP359e8d4aa59e: Hover hint on calendar list items should appear on the most convenient side…
Summary

Hover hint on calendar list items should be to the right in day view, left in profile view, on top in month view

Test Plan

Open profile view, calendar items should have a left hover. Open day view, calendar items should have a right hover. Open month view, calendar items should have top hover.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 38436.May 23 2016, 5:26 PM
lpriestley retitled this revision from to Hover hint on calendar list items should appear on the most convenient side of the item.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 23 2016, 5:26 PM
Herald added a subscriber: Korvin. · View Herald Transcript
lpriestley added a child revision: D15851: Adding a calendar preview panel to people profile.May 23 2016, 5:27 PM
lpriestley removed a child revision: D15851: Adding a calendar preview panel to people profile.
lpriestley added a parent revision: D15851: Adding a calendar preview panel to people profile.
lpriestley added a task: T9606: "Calendar" tab on user profiles is pretty junky.
epriestley accepted this revision.May 23 2016, 5:31 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 23 2016, 5:31 PM
Closed by commit rP359e8d4aa59e: Hover hint on calendar list items should appear on the most convenient side… (authored by lpriestley, committed by lpriestley). · Explain WhyMay 23 2016, 5:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
people/
controller/
1 line
view/
phui/
calendar/
8 lines
5 lines
12 lines

Diff 38441

View Options

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarListView.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarMonthView.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarWeekView.php

Loading...
Phabricator · Built by Phacility