Add getPhobjectClassConstant() to Phobject
ClosedPublic
Actions

Authored by epriestley on Oct 1 2015, 8:26 PM.

Tags

None

Referenced Files

	F13291915: D14216.id34335.diff
	Wed, Jun 5, 12:58 AM

	F13291914: D14216.id34329.diff
	Wed, Jun 5, 12:58 AM

	F13291913: D14216.id.diff
	Wed, Jun 5, 12:58 AM

	F13291912: D14216.diff
	Wed, Jun 5, 12:58 AM

	F13280901: D14216.diff
	Sun, Jun 2, 9:27 AM

	F13259042: D14216.id.diff
	Sun, May 26, 3:38 PM

	F13240301: D14216.diff
	Wed, May 22, 12:54 PM

	F13224394: D14216.id.diff
	Sun, May 19, 8:15 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T9494: Standardize GarbageCollector TTLs

Commits

rPHU367fadac24f2: (stable) Promote 2015 Week 40
rPHUd0105f145688: Add getPhobjectClassConstant() to Phobject

Summary

Ref T9494. We have like 20 copies of this code, just add a helper method to the base class.

Test Plan

See next change.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34329.Oct 1 2015, 8:26 PM

epriestley retitled this revision from to Add getPhobjectClassConstant() to Phobject.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9494: Standardize GarbageCollector TTLs.

epriestley added a child revision: D14217: Use getPhobjectClassConstant() to access class constants.

chad accepted this revision.Oct 1 2015, 8:32 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 1 2015, 8:32 PM

Closed by commit rPHUd0105f145688: Add getPhobjectClassConstant() to Phobject (authored by epriestley, committed by epriestley). · Explain WhyOct 1 2015, 11:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

object/

Phobject.php

41 lines

Diff 34335

View Options

Add getPhobjectClassConstant() to PhobjectClosedPublicActions