Page MenuHomePhabricator
Differential D13705

Modularize "add projects" and "remove projects" Herald actions
ClosedPublic
Actions

Authored by epriestley on Jul 24 2015, 7:26 PM.
Tags
None
Referenced Files
F13279523: D13705.id33280.diff
Sat, Jun 1, 7:07 PM
F13277865: D13705.id33123.diff
Fri, May 31, 2:37 PM
F13274545: D13705.diff
Fri, May 31, 3:49 AM
F13265014: D13705.id33129.diff
Tue, May 28, 12:39 AM
F13260597: D13705.diff
Mon, May 27, 12:07 AM
F13244830: D13705.diff
Thu, May 23, 5:21 AM
F13240203: D13705.id33280.diff
Wed, May 22, 11:42 AM
F13235671: D13705.diff
Tue, May 21, 6:07 AM
View All Files
Subscribers
epriestley
joshuaspence
Tokens
"Orange Medal" token, awarded by joshuaspence.

Details

Reviewers
btrahan
Maniphest Tasks
T8726: Modularize Herald fields and actions
Commits
Restricted Diffusion Commit
rP37829926702b: Modularize "add projects" and "remove projects" Herald actions
Summary

Ref T8726. Convert these to be modular.

Test Plan
  • Created rules using these actions.
  • Upgraded them.
  • Verified they still work.

Screen Shot 2015-07-24 at 12.24.07 PM.png (200×495 px, 33 KB)

Diff Detail

Repository
rP Phabricator
Branch
heraldx6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7383
Build 7806: [Placeholder Plan] Wait for 30 Seconds
Build 7805: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33123.Jul 24 2015, 7:26 PM
epriestley retitled this revision from to Modularize "add projects" and "remove projects" Herald actions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8726: Modularize Herald fields and actions.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 24 2015, 7:26 PM
btrahan accepted this revision.Jul 25 2015, 12:01 AM
btrahan edited edge metadata.
btrahan added inline comments.
src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php
1244

duplicate s

This revision is now accepted and ready to land.Jul 25 2015, 12:01 AM
epriestley updated this revision to Diff 33129.Jul 25 2015, 12:03 AM
epriestley edited edge metadata.
  • Fix duplicate "ss".
joshuaspence awarded a token.Jul 25 2015, 1:23 AM
joshuaspence rescinded a token.
joshuaspence awarded a token.
joshuaspence added a subscriber: joshuaspence.
Closed by commit rP37829926702b: Modularize "add projects" and "remove projects" Herald actions (authored by epriestley, committed by epriestley). · Explain WhyAug 3 2015, 9:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
11 lines
src/
6 lines
applications/
herald/
adapter/
58 lines
project/
herald/
28 lines
180 lines
28 lines
infrastructure/
internationalization/
translation/
20 lines

Diff 33123

View Options

resources/sql/autopatches/20150724.herald.3.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/project/herald/PhabricatorProjectAddHeraldAction.php

Loading...
View Options

src/applications/project/herald/PhabricatorProjectHeraldAction.php

Loading...
View Options

src/applications/project/herald/PhabricatorProjectRemoveHeraldAction.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...
Phabricator · Built by Phacility