Page MenuHomePhabricator
Differential D13516

Don't put objects into the query workspace by default
ClosedPublic
Actions

Authored by epriestley on Jul 1 2015, 6:10 PM.
Tags
None
Referenced Files
F13325242: D13516.diff
Sat, Jun 15, 1:34 AM
F13312732: D13516.diff
Tue, Jun 11, 7:01 AM
F13299094: D13516.diff
Fri, Jun 7, 7:37 AM
F13251521: D13516.id.diff
Sat, May 25, 12:01 AM
F13211470: D13516.diff
Fri, May 17, 5:47 AM
F13201796: D13516.diff
May 14 2024, 4:27 PM
F13198933: D13516.diff
May 13 2024, 10:24 AM
F13177985: D13516.diff
May 8 2024, 8:05 PM
View All Files
Subscribers
chad
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8731: Logged out secure.phabricator.com feed error
Commits
Restricted Diffusion Commit
rPd5e4d9608626: Don't put objects into the query workspace by default
Summary

Ref T8731. I think the issue is that some ProjectQuery (without needImages()) populates the query workspace, then the "real" one hits the workspace.

Instead, only populate the workspace from ObjectQuery, so we know that objects in the workspace always have whatever ObjectQuery attaches to them.

Test Plan

Verified this didn't destroy the cache hitrate, but I can't repro the original issue locally per se.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7099
Build 7250: [Placeholder Plan] Wait for 30 Seconds
Build 7249: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32676.Jul 1 2015, 6:10 PM
epriestley retitled this revision from to Don't put objects into the query workspace by default.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8731: Logged out secure.phabricator.com feed error.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 1 2015, 6:10 PM
btrahan accepted this revision.Jul 1 2015, 7:58 PM
btrahan edited edge metadata.

whatcouldgowrong

This revision is now accepted and ready to land.Jul 1 2015, 7:58 PM
chad added a subscriber: chad.Jul 1 2015, 8:04 PM

spoderman

btrahan added a comment.Jul 1 2015, 8:07 PM

Macro spoderman: cash hit s'all gud

Closed by commit rPd5e4d9608626: Don't put objects into the query workspace by default (authored by epriestley, committed by epriestley). · Explain WhyJul 1 2015, 9:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
query/
policy/
22 lines

Diff 32676

View Options

src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility