Move People to SearchFields
ClosedPublic
Actions

Authored by epriestley on Jun 7 2015, 5:00 PM.

Details

Reviewers

Maniphest Tasks

T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch
T8441: Integrate Spaces into ApplicationSearch

Commits

Restricted Diffusion Commit
rP3e2b0c35f9da: Move People to SearchFields

Summary

Ref T8441. Ref T7715. This is the second of three ApplicationSearch + CustomField use cases (Maniphest is the third).

Also add a way to set a default ordering for the fields.

Test Plan

Performed searches with each field.
Added a custom field and searched for it.
Observed desired ordering.

Diff Detail

Repository

rP Phabricator

Branch

spaces5

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6604
Build 6626: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31880.Jun 7 2015, 5:00 PM

epriestley retitled this revision from to Move People to SearchFields.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T8441: Integrate Spaces into ApplicationSearch, T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 7 2015, 5:00 PM

btrahan accepted this revision.Jun 8 2015, 6:28 PM

btrahan edited edge metadata.

btrahan added inline comments.

src/applications/search/engine/PhabricatorApplicationSearchEngine.php
250–273	I dig this API.

This revision is now accepted and ready to land.Jun 8 2015, 6:28 PM

epriestley added inline comments.Jun 8 2015, 6:34 PM

src/applications/search/engine/PhabricatorApplicationSearchEngine.php
250–273	Yeah, this is a little out there but it feels neat without being too weird.

btrahan added inline comments.Jun 8 2015, 6:36 PM

src/applications/search/engine/PhabricatorApplicationSearchEngine.php
250–273	its like phutil_time in spirit; easiest / best for human consumption and quick changes in the future.

Closed by commit rP3e2b0c35f9da: Move People to SearchFields (authored by epriestley, committed by epriestley). · Explain WhyJun 8 2015, 7:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

query/

PhabricatorPeopleSearchEngine.php

233 lines

search/

engine/

PhabricatorApplicationSearchEngine.php

73 lines

Diff 31880

View Options

src/applications/people/query/PhabricatorPeopleSearchEngine.php