Page MenuHomePhabricator

Fix an issue where "Browse > Select" did not work for dynamic tokenizers
ClosedPublic

Authored by epriestley on Apr 23 2015, 1:16 PM.
Tags
None
Referenced Files
F13287544: D12529.diff
Tue, Jun 4, 8:56 AM
F13275031: D12529.diff
Fri, May 31, 4:20 AM
F13261084: D12529.diff
Mon, May 27, 12:42 AM
F13255452: D12529.id30076.diff
Sat, May 25, 5:22 AM
F13243602: D12529.diff
Thu, May 23, 4:03 AM
F13222018: D12529.diff
Sun, May 19, 3:16 AM
F13204548: D12529.diff
Wed, May 15, 12:41 AM
F13187532: D12529.diff
Sat, May 11, 4:35 AM
Subscribers

Details

Summary

Ref T4100. In Herald, using the browse dialog to select a result didn't work because we'd add the token with no name value. Other things would render it elsewhere, but it would eventaully be discarded.

Instead, add it with a name value.

Test Plan

Edited a Herald rule and used Browse > Select to add a token. Saved rule. Saw token persist.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix an issue where "Browse > Select" did not work for dynamic tokenizers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 23 2015, 5:30 PM
This revision was automatically updated to reflect the committed changes.