Page MenuHomePhabricator
Differential D12454

Provide more buildXClause() and buildXClauseParts() on PolicyAwareQuery
ClosedPublic
Actions

Authored by epriestley on Apr 18 2015, 2:52 PM.
Tags
None
Referenced Files
F13227702: D12454.diff
Mon, May 20, 4:59 AM
F13215924: D12454.id29896.diff
Fri, May 17, 8:56 PM
F13207337: D12454.diff
Wed, May 15, 10:17 PM
F13192170: D12454.diff
Sun, May 12, 6:03 AM
F13173968: D12454.diff
Tue, May 7, 9:31 PM
Unknown Object (File)
Sat, May 4, 7:07 AM
Unknown Object (File)
Apr 20 2024, 8:37 AM
Unknown Object (File)
Apr 17 2024, 3:15 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T5595: Allow all applications to filter results by project
T4100: Support query parameterization in typeaheads
Commits
Restricted Diffusion Commit
rP55e49d7e316c: Provide more buildXClause() and buildXClauseParts() on PolicyAwareQuery
Summary

Ref T4100. Ref T5595. These functions are trivial for now, but move us toward being able to define more default query behavior by default.

Future changes will give these methods meaningful, nontrivial behaviors.

Test Plan

arc unit --everything

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29896.Apr 18 2015, 2:52 PM
epriestley retitled this revision from to Provide more buildXClause() and buildXClauseParts() on PolicyAwareQuery.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T4100: Support query parameterization in typeaheads, T5595: Allow all applications to filter results by project.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 18 2015, 2:52 PM
btrahan accepted this revision.Apr 20 2015, 3:58 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2015, 3:58 PM
Closed by commit rP55e49d7e316c: Provide more buildXClause() and buildXClauseParts() on PolicyAwareQuery (authored by epriestley, committed by epriestley). · Explain WhyApr 20 2015, 5:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
almanac/
query/
2 lines
conpherence/
query/
2 lines
diffusion/
query/
2 lines
feed/
query/
2 lines
files/
query/
2 lines
legalpad/
query/
2 lines
owners/
query/
2 lines
phortune/
query/
2 lines
2 lines
phriction/
query/
2 lines
project/
query/
2 lines
infrastructure/
daemon/
workers/
query/
2 lines
query/
111 lines
policy/
75 lines

Diff 29950

View Options

src/applications/almanac/query/AlmanacServiceQuery.php

Loading...
View Options

src/applications/conpherence/query/ConpherenceThreadQuery.php

Loading...
View Options

src/applications/diffusion/query/DiffusionCommitQuery.php

Loading...
View Options

src/applications/feed/query/PhabricatorFeedQuery.php

Loading...
View Options

src/applications/files/query/PhabricatorFileQuery.php

Loading...
View Options

src/applications/legalpad/query/LegalpadDocumentQuery.php

Loading...
View Options

src/applications/owners/query/PhabricatorOwnersPackageQuery.php

Loading...
View Options

src/applications/phortune/query/PhortuneAccountQuery.php

Loading...
View Options

src/applications/phortune/query/PhortuneMerchantQuery.php

Loading...
View Options

src/applications/phriction/query/PhrictionDocumentQuery.php

Loading...
View Options

src/applications/project/query/PhabricatorProjectQuery.php

Loading...
View Options

src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php

Loading...
View Options

src/infrastructure/query/PhabricatorQuery.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility