Page MenuHomePhabricator

Improve browsability of People query
ClosedPublic

Authored by epriestley on Apr 15 2015, 6:31 PM.
Tags
None
Referenced Files
F13188120: D12427.diff
Sat, May 11, 5:03 AM
Unknown Object (File)
Tue, May 7, 8:14 AM
Unknown Object (File)
Fri, May 3, 7:57 AM
Unknown Object (File)
Tue, Apr 30, 7:43 AM
Unknown Object (File)
Thu, Apr 25, 1:56 AM
Unknown Object (File)
Sat, Apr 13, 2:30 AM
Unknown Object (File)
Apr 8 2024, 1:59 PM
Unknown Object (File)
Apr 7 2024, 6:19 PM
Subscribers

Details

Summary

Ref T5750. Fix this query so it works better with the browse view. In particular, make it return results before the user types a query.

Test Plan
  • Used a people tokenizer.
  • Used global search tokenizer to search for people.
  • Ran new version of query in production to make sure it wasn't crazy.
  • Browsed through results in browse view.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Improve browsability of People query.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
src/applications/people/query/PhabricatorPeopleQuery.php
329–347

BEHOLD! Adding new sort orders is now a reasonable thing which mere mortals can accomplish!

btrahan edited edge metadata.
btrahan added inline comments.
src/applications/people/query/PhabricatorPeopleQuery.php
329–347

lol

This revision is now accepted and ready to land.Apr 15 2015, 6:48 PM
This revision was automatically updated to reflect the committed changes.