Page MenuHomePhabricator
Differential D12426

Add a typehaead filter to tokenizer browse views
ClosedPublic
Actions

Authored by epriestley on Apr 15 2015, 5:54 PM.
Tags
None
Referenced Files
F13285509: D12426.id29873.diff
Mon, Jun 3, 10:22 PM
F13265135: D12426.id.diff
Tue, May 28, 1:29 AM
F13249017: D12426.diff
Fri, May 24, 6:04 AM
F13240910: D12426.id29873.diff
Wed, May 22, 5:48 PM
F13240905: D12426.id.diff
Wed, May 22, 5:46 PM
F13240790: D12426.id29835.diff
Wed, May 22, 4:31 PM
F13228968: D12426.diff
Mon, May 20, 1:43 PM
F13224410: D12426.id29835.diff
Sun, May 19, 8:22 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T5750: Implement typeahead browse mode
Commits
Restricted Diffusion Commit
rPf688181eaf3f: Add a typehaead filter to tokenizer browse views
Summary

Ref T5750. This adds a search filter which filters results (kind of: a lot of datasources don't do a great job with this right now -- but the correct data is sent to the server).

Test Plan

Screen_Shot_2015-04-15_at_10.49.06_AM.png (448×629 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Branch
type4
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/application/typeahead/behavior-typeahead-search.js:1JAVELIN5`javelinsymbols` Not In Path
Unit
No Test Coverage
Build Status
Buildable 5327
Build 5345: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29835.Apr 15 2015, 5:54 PM
epriestley retitled this revision from to Add a typehaead filter to tokenizer browse views.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5750: Implement typeahead browse mode.
Herald added a reviewer: chad. · View Herald TranscriptApr 15 2015, 5:54 PM
Herald added a subscriber: epriestley. · View Herald Transcript
chad accepted this revision.Apr 15 2015, 6:01 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 15 2015, 6:01 PM
Closed by commit rPf688181eaf3f: Add a typehaead filter to tokenizer browse views (authored by epriestley, committed by epriestley). · Explain WhyApr 17 2015, 6:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
src/
applications/
typeahead/
controller/
36 lines
webroot/
rsrc/
css/
aphront/
13 lines
js/
application/
typeahead/
56 lines

Diff 29835

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php

Loading...
View Options

webroot/rsrc/css/aphront/typeahead-browse.css

Loading...
View Options

webroot/rsrc/js/application/typeahead/behavior-typeahead-search.js

Loading...
Phabricator · Built by Phacility