Page MenuHomePhabricator

Provide "builtin" high-level result orders
ClosedPublic

Authored by epriestley on Apr 12 2015, 10:34 PM.
Tags
None
Referenced Files
F13186641: D12379.diff
Sat, May 11, 3:46 AM
Unknown Object (File)
Tue, May 7, 7:03 AM
Unknown Object (File)
Sat, May 4, 9:42 AM
Unknown Object (File)
Fri, May 3, 5:08 AM
Unknown Object (File)
Thu, Apr 25, 12:46 AM
Unknown Object (File)
Mon, Apr 15, 4:33 AM
Unknown Object (File)
Apr 12 2024, 9:26 PM
Unknown Object (File)
Apr 12 2024, 9:26 PM
Subscribers

Details

Summary

Ref T7803. Currently, available high-level orders are spread across Query and SearchEngine classes and implemented separately for each application.

Lift the concept of "builtin" (high-level, user-facing, named) orders (similar to "builtin" queries in ApplicationSearch) into the root Query class, and let it drive the SearchEngine implementation. This allows you to define a new order in one place and have it automatically work across the entire stack.

This will also let Conduit expose this information in a straightforward way.

Test Plan
  • Used ApplicationSearch in Diffusion.
  • Used all result orderings.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Provide "builtin" high-level result orders.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 5:58 PM
This revision was automatically updated to reflect the committed changes.