Page MenuHomePhabricator
Differential D12378

Remove getPagingColumn() / getReversePaging()
ClosedPublic
Actions

Authored by epriestley on Apr 12 2015, 9:21 PM.
Tags
None
Referenced Files
F13295439: D12378.diff
Thu, Jun 6, 2:54 AM
F13255102: D12378.diff
Sat, May 25, 4:25 AM
F13241177: D12378.id29711.diff
Wed, May 22, 7:02 PM
F13238245: D12378.id.diff
Tue, May 21, 6:15 PM
F13233729: D12378.diff
Tue, May 21, 2:32 AM
F13213784: D12378.diff
Fri, May 17, 8:04 AM
F13209438: D12378.id29766.diff
Fri, May 17, 12:12 AM
Unknown Object (File)
May 7 2024, 8:16 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7803: Implement a composite query which unifies cursor paging across subqueries
Commits
Restricted Diffusion Commit
rP2794c69db550: Remove getPagingColumn() / getReversePaging()
Summary

Ref T7803. Remove these in favor of more generalized paging and ordering.

Test Plan

Sorted and paged results in various applications.

Diff Detail

Repository
rP Phabricator
Branch
rpaging16
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/conpherence/query/ConpherenceTransactionQuery.php:11XHP16TODO Comment
Advicesrc/applications/differential/query/DifferentialHunkQuery.php:116XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 5264
Build 5282: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29711.Apr 12 2015, 9:21 PM
epriestley retitled this revision from to Remove getPagingColumn() / getReversePaging().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7803: Implement a composite query which unifies cursor paging across subqueries.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 12 2015, 9:21 PM
btrahan accepted this revision.Apr 13 2015, 5:54 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 5:54 PM
Closed by commit rP2794c69db550: Remove getPagingColumn() / getReversePaging() (authored by epriestley, committed by epriestley). · Explain WhyApr 13 2015, 7:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
base/
controller/
1 line
config/
controller/
2 lines
conpherence/
query/
5 lines
differential/
query/
5 lines
ponder/
query/
4 lines
1 line
repository/
query/
2 lines
transactions/
query/
10 lines
infrastructure/
query/
policy/
61 lines

Diff 29711

View Options

src/applications/base/controller/PhabricatorController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigHistoryController.php

Loading...
View Options

src/applications/conpherence/query/ConpherenceTransactionQuery.php

Loading...
View Options

src/applications/differential/query/DifferentialHunkQuery.php

Loading...
View Options

src/applications/ponder/query/PonderAnswerQuery.php

Loading...
View Options

src/applications/ponder/query/PonderQuestionQuery.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryQuery.php

Loading...
View Options

src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility