Paths

Table of Contentst

Differential D12372

Modernize ManiphestTask paging and ordering
ClosedPublic
Actions

Authored by epriestley on Apr 12 2015, 8:04 PM.

Tags

None

Referenced Files

	F13252155: D12372.diff
	Sat, May 25, 1:08 AM

	F13240263: D12372.id29700.diff
	Wed, May 22, 12:26 PM

	F13240064: D12372.id29765.diff
	Wed, May 22, 10:02 AM

	F13239480: D12372.id.diff
	Wed, May 22, 3:32 AM

	F13228501: D12372.id.diff
	Mon, May 20, 9:55 AM

	F13215515: D12372.id29703.diff
	Fri, May 17, 5:54 PM

	F13208696: D12372.id.diff
	Thu, May 16, 6:44 PM

	F13207696: D12372.id29700.diff
	Thu, May 16, 2:33 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T7803: Implement a composite query which unifies cursor paging across subqueries

Commits

Restricted Diffusion Commit
rPbdd1edea7a40: Modernize ManiphestTask paging and ordering

Summary

Ref T7803. The ApplicationSearch integration is still a little rough here, but it seems to have the correct behavior.

The rest of this is now at least relatively sane, cohesive, and properly behaved.

Test Plan

Used all grouping and ordering queries in Maniphest. Pagingated results.
Used custom field ordering in Maniphest. Paginated results.
Paginated through the null section of "Assigned" and "Projects" group-by queries. Pagingation now works correctly (it does not work at HEAD).
Ran unit tests covering priority changes.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29700.Apr 12 2015, 8:04 PM

epriestley retitled this revision from to Modernize ManiphestTask paging and ordering.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7803: Implement a composite query which unifies cursor paging across subqueries.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 12 2015, 8:04 PM

Fix some issues with subpriority adjustments.

epriestley mentioned this in D12374: Actually support "%Lf" in qsprintf().Apr 12 2015, 8:28 PM

btrahan accepted this revision.Apr 13 2015, 5:51 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 13 2015, 5:51 PM

Closed by commit rPbdd1edea7a40: Modernize ManiphestTask paging and ordering (authored by epriestley, committed by epriestley). · Explain WhyApr 13 2015, 6:59 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rPHU99e9235ec6a4: Actually support "%Lf" in qsprintf().

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

editor/

ManiphestTransactionEditor.php

20 lines

query/

ManiphestTaskQuery.php

444 lines

infrastructure/

query/

policy/

PhabricatorCursorPagedPolicyAwareQuery.php

86 lines

Diff 29765

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Loading...

src/applications/maniphest/query/ManiphestTaskQuery.php

Loading...

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...