Page MenuHomePhabricator
Differential D12361

Remove ORDER_PATH_MODIFIED from Differential
ClosedPublic
Actions

Authored by epriestley on Apr 12 2015, 3:20 AM.
Tags
None
Referenced Files
F13287813: D12361.diff
Tue, Jun 4, 9:21 AM
F13275490: D12361.diff
Fri, May 31, 4:50 AM
F13261597: D12361.diff
Mon, May 27, 1:13 AM
F13247935: D12361.diff
Thu, May 23, 11:37 PM
F13245186: D12361.id29684.diff
Thu, May 23, 5:49 AM
F13244197: D12361.diff
Thu, May 23, 4:36 AM
F13240874: D12361.id29684.diff
Wed, May 22, 5:25 PM
F13240463: D12361.id.diff
Wed, May 22, 2:22 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7803: Implement a composite query which unifies cursor paging across subqueries
Commits
Restricted Diffusion Commit
rP9b5198f46330: Remove ORDER_PATH_MODIFIED from Differential
Summary

Ref T7803. This is a performance hack, not a real order, and isn't really meaningful or pageable.

After D12158, we constraint his query on dateModified anyway, which should generally give the database a relatively small result set to examine.

Test Plan

Browsed Differential and Diffusion. Checked query plan, it didn't look too crazy.

Diff Detail

Repository
rP Phabricator
Branch
rpaging11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5244
Build 5262: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29684.Apr 12 2015, 3:20 AM
epriestley retitled this revision from to Remove ORDER_PATH_MODIFIED from Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7803: Implement a composite query which unifies cursor paging across subqueries.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 12 2015, 3:20 AM
btrahan accepted this revision.Apr 13 2015, 5:28 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 5:28 PM
Closed by commit rP9b5198f46330: Remove ORDER_PATH_MODIFIED from Differential (authored by epriestley, committed by epriestley). · Explain WhyApr 13 2015, 7:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
2 lines
query/
22 lines
diffusion/
controller/
2 lines

Diff 29684

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/query/DifferentialRevisionQuery.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
Phabricator · Built by Phacility