Page MenuHomePhabricator
Differential D12361

Remove ORDER_PATH_MODIFIED from Differential
ClosedPublic
Actions

Authored by epriestley on Apr 12 2015, 3:20 AM.
Tags
None
Referenced Files
F13178493: D12361.diff
Wed, May 8, 8:27 PM
Unknown Object (File)
Sun, Apr 28, 1:03 PM
Unknown Object (File)
Thu, Apr 25, 2:32 AM
Unknown Object (File)
Apr 10 2024, 2:10 PM
Unknown Object (File)
Apr 9 2024, 7:56 PM
Unknown Object (File)
Apr 9 2024, 7:01 AM
Unknown Object (File)
Apr 5 2024, 5:46 AM
Unknown Object (File)
Mar 20 2024, 9:56 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7803: Implement a composite query which unifies cursor paging across subqueries
Commits
Restricted Diffusion Commit
rP9b5198f46330: Remove ORDER_PATH_MODIFIED from Differential
Summary

Ref T7803. This is a performance hack, not a real order, and isn't really meaningful or pageable.

After D12158, we constraint his query on dateModified anyway, which should generally give the database a relatively small result set to examine.

Test Plan

Browsed Differential and Diffusion. Checked query plan, it didn't look too crazy.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29684.Apr 12 2015, 3:20 AM
epriestley retitled this revision from to Remove ORDER_PATH_MODIFIED from Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7803: Implement a composite query which unifies cursor paging across subqueries.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 12 2015, 3:20 AM
btrahan accepted this revision.Apr 13 2015, 5:28 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 5:28 PM
Closed by commit rP9b5198f46330: Remove ORDER_PATH_MODIFIED from Differential (authored by epriestley, committed by epriestley). · Explain WhyApr 13 2015, 7:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
2 lines
query/
22 lines
diffusion/
controller/
2 lines

Diff 29763

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/query/DifferentialRevisionQuery.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
Phabricator · Built by Phacility