Page MenuHomePhabricator
Differential D12356

Remove trivial implementations of getPagingColumn()
ClosedPublic
Actions

Authored by epriestley on Apr 12 2015, 2:02 AM.
Tags
None
Referenced Files
F13301137: D12356.diff
Fri, Jun 7, 3:21 PM
F13284984: D12356.id29678.diff
Mon, Jun 3, 12:23 PM
F13266292: D12356.diff
Tue, May 28, 12:11 PM
F13250236: D12356.diff
Fri, May 24, 1:27 PM
F13237740: D12356.id29759.diff
Tue, May 21, 2:45 PM
F13236305: D12356.id29678.diff
Tue, May 21, 9:08 AM
F13235957: D12356.id.diff
Tue, May 21, 7:19 AM
F13235846: D12356.diff
Tue, May 21, 6:53 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7803: Implement a composite query which unifies cursor paging across subqueries
Commits
Restricted Diffusion Commit
rP4fba6e7730aa: Remove trivial implementations of getPagingColumn()
Summary

Ref T7803. Some Query subclasses implement getPagingColumn() in a trivial way, usually to provide a table alias.

Formalize the concept of a primary table alias, and remove obsoleted getPagingColumn() implementations.

Test Plan

Issued affected queries.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29678.Apr 12 2015, 2:02 AM
epriestley retitled this revision from to Remove trivial implementations of getPagingColumn().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7803: Implement a composite query which unifies cursor paging across subqueries.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 12 2015, 2:02 AM
btrahan accepted this revision.Apr 13 2015, 5:11 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 5:11 PM
Closed by commit rP4fba6e7730aa: Remove trivial implementations of getPagingColumn() (authored by epriestley, committed by epriestley). · Explain WhyApr 13 2015, 7:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
files/
query/
4 lines
macro/
query/
4 lines
maniphest/
query/
4 lines
metamta/
query/
8 lines
people/
query/
8 lines
project/
query/
4 lines
slowvote/
query/
4 lines
infrastructure/
query/
policy/
33 lines

Diff 29759

View Options

src/applications/files/query/PhabricatorFileQuery.php

Loading...
View Options

src/applications/macro/query/PhabricatorMacroQuery.php

Loading...
View Options

src/applications/maniphest/query/ManiphestTaskQuery.php

Loading...
View Options

src/applications/metamta/query/PhabricatorMetaMTAApplicationEmailQuery.php

Loading...
View Options

src/applications/people/query/PhabricatorPeopleQuery.php

Loading...
View Options

src/applications/project/query/PhabricatorProjectQuery.php

Loading...
View Options

src/applications/slowvote/query/PhabricatorSlowvoteQuery.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility