Page MenuHomePhabricator

Begin formalizing query orders
ClosedPublic

Authored by epriestley on Apr 12 2015, 12:24 AM.
Tags
None
Referenced Files
F13250254: D12352.id.diff
Fri, May 24, 1:29 PM
F13241330: D12352.id29673.diff
Wed, May 22, 8:22 PM
F13241217: D12352.id.diff
Wed, May 22, 7:27 PM
F13240568: D12352.id29753.diff
Wed, May 22, 3:13 PM
F13234304: D12352.diff
Tue, May 21, 3:17 AM
F13226853: D12352.id29673.diff
Sun, May 19, 11:42 PM
F13217522: D12352.diff
Sat, May 18, 6:00 AM
F13211914: D12352.diff
Fri, May 17, 6:13 AM
Subscribers

Details

Summary

Ref T7803. Queries currently have a single getPagingColumn(), which is oversimplified and insufficient to describe many ordering operations. Frequently, orders must span multiple columns.

Move toward an "order vector", which is a list of orderable values like "name, id". These map directly to columns, and are sufficient to actually describe orders. The more modern Query classes (Maniphest, Repository) essentially do this manually anyway.

Test Plan
  • Added and executed unit tests.
  • Browsed around, verified the correct ORDER BY clauses were generated.

Diff Detail

Event Timeline

epriestley retitled this revision from to Begin formalizing query orders.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 5:03 PM
This revision was automatically updated to reflect the committed changes.