Paths

Table of Contentst

Differential D12343

Document just-in-time methods for handles
ClosedPublic
Actions

Authored by epriestley on Apr 9 2015, 11:10 PM.

Tags

None

Referenced Files

	F13241353: D12343.id29659.diff
	Wed, May 22, 8:32 PM

	F13241347: D12343.id.diff
	Wed, May 22, 8:30 PM

	F13240770: D12343.id29652.diff
	Wed, May 22, 4:25 PM

	F13217625: D12343.diff
	Sat, May 18, 6:33 AM

	F13205313: D12343.diff
	Wed, May 15, 1:49 AM

	F13191651: D12343.id29652.diff
	Sat, May 11, 11:10 PM

	F13188724: D12343.diff
	Sat, May 11, 5:26 AM

	Unknown Object (File)
	Tue, May 7, 9:09 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T7689: Load handles just-in-time

Commits

Restricted Diffusion Commit
rP3c254469c95c: Document just-in-time methods for handles

Summary

Fixes T7689. I'm not going to go clean up all the rest of the loadViewerHandles() calls right now since a lot of them are kind of a pain and they aren't really hurting anything so it doesn't feel very leveraged, but at least deprecate it and document the new hotness.

Test Plan

have a look
in a book
reading rainbow

Diff Detail

Repository

Branch

hand3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5222
Build 5240: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29652.Apr 9 2015, 11:10 PM

epriestley retitled this revision from to Document just-in-time methods for handles.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7689: Load handles just-in-time.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 9 2015, 11:10 PM

btrahan accepted this revision.Apr 10 2015, 5:13 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 10 2015, 5:13 PM

Closed by commit rP3c254469c95c: Document just-in-time methods for handles (authored by epriestley, committed by epriestley). · Explain WhyApr 10 2015, 5:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

base/

controller/

PhabricatorController.php

5 lines

docs/

tech/

handles.diviner

101 lines

Diff 29652

src/applications/base/controller/PhabricatorController.php

Loading...

src/docs/tech/handles.diviner

Loading...