Page MenuHomePhabricator

Update script for compatibility with PHP CompatInfo v4.0.0
ClosedPublic

Authored by joshuaspence on Apr 5 2015, 5:18 AM.
Tags
None
Referenced Files
F13280785: D12278.diff
Sun, Jun 2, 9:18 AM
F13278654: D12278.id29477.diff
Sat, Jun 1, 1:36 AM
F13267476: D12278.diff
Wed, May 29, 3:26 AM
F13252915: D12278.diff
Sat, May 25, 2:12 AM
F13247606: D12278.id.diff
Thu, May 23, 8:56 PM
F13241329: D12278.id29477.diff
Wed, May 22, 8:22 PM
F13231233: D12278.diff
Tue, May 21, 12:18 AM
F13210425: D12278.diff
Fri, May 17, 4:50 AM
Subscribers

Details

Summary

The API for PHP CompatInfo changed significantly in v4.0.0 and therefore this script needs to be updated. One of the major differences is that the data is now stored in an SQLite database and JSON files rather than in PHP source code.

Another noticable difference is that the newer version is missing information regarding the compatibility of class methods. I have filled an upstream issue for this, but I don't consider this to be hugely significant as they data isn't currently used.

I also took this opportunity to tweak the output format to include some additional fields (although I have no immediate plans to use these fields).

Test Plan

Eyeballed the output. The main thing that looked out of place was the following, which seems wrong to me:

"opcache_compile_file": {
  "min": "5.2.0",
  "max": null,
  "ref": "Zend OPcache"
},
"opcache_is_script_cached": {
  "min": "5.2.0",
  "max": null,
  "ref": "Zend OPcache"
},

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Update script for compatibility with PHP CompatInfo v4.0.0.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.

Simplify logic for parsing parameter counts

epriestley edited edge metadata.

I have zero clue what I ran locally, then, if it also clearly wasn't 4.0.0. I guess I am exceptionally bad at using Composer.

iiam

This revision is now accepted and ready to land.Apr 6 2015, 1:21 PM
This revision was automatically updated to reflect the committed changes.