Page MenuHomePhabricator

Add a linter rule for PHP indentation
AbandonedPublic

Authored by joshuaspence on Jan 26 2015, 10:12 AM.
Tags
None
Referenced Files
F13294818: D11504.id27759.diff
Wed, Jun 5, 7:41 PM
F13281688: D11504.diff
Sun, Jun 2, 11:06 AM
F13242932: D11504.diff
Thu, May 23, 3:12 AM
F13240712: D11504.id27759.diff
Wed, May 22, 3:55 PM
F13235447: D11504.diff
Tue, May 21, 5:23 AM
F13233169: D11504.id28041.diff
Tue, May 21, 1:46 AM
F13227664: D11504.diff
Mon, May 20, 4:50 AM
F13224614: D11504.diff
Sun, May 19, 9:37 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

WIP. Depends on D12295.

Test Plan

WIP

Diff Detail

Repository
rARC Arcanist
Branch
xhp-indent
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 4053
Build 4066: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
220 msArcanistXHPASTLinterTestCase::testLinter
673 msArcanistCSSLintLinterTestCase::testLinter
116 msArcanistCSSLintLinterTestCase::testVersion
229 msArcanistChmodLinterTestCase::testLinter
241 msArcanistClosureLinterTestCase::testLinter
View Full Test Results (1 Failed · 38 Passed · 12 Skipped)

Event Timeline

joshuaspence retitled this revision from to Add a linter rule for PHP indentation.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
epriestley added a reviewer: epriestley.

Just pushing this out of my queue for now, I'm excited about it if you can make it work.

I'm wildly amused by this diff getting flagged by itself.

This revision now requires changes to proceed.Jan 26 2015, 3:14 PM
joshuaspence edited edge metadata.

Somewhat working

joshuaspence edited edge metadata.

Somewhat working

Further work, seems to work reasonably well but still needs work

Not actively working on this.