2020 Week 37 (Mid September)

Updated 1,313 Days AgoPublic

Actions

Summary of changes from August 7, 2020 to September 18, 2020.

• These changes were promoted to stable.

General

• [] Amazon SES: If you send email with Amazon SES, see the note in "Upgrading / Compatibility" below.
• [] When importing commits, related revisions and tasks are now updated in the "publish" step, not the "message" step. This should generally align some of the more subtle import behavior more closely with expectation. In particular, if you push a commit which was previously reachable only from non-permanent refs (like alice-tmp-123) to a permanent ref (like master), it will now close related revisions properly alongside other publishing actions which are triggered when it becomes reachable from a permanent ref.
• The way commit lists are rendered in the UI has changed in some interfaces, with the general goal of increasing consistency.

Security

• No notes in this period.

Migrations

• No migrations in this period.

Upgrading / Compatibility

• The bypassCache parameter to diffusion.querycommits no longer has any effect and no longer offers a direct-to-authority access mode. If you have code which relies on this class of behavior you can switch to calling internal.commit.search, but neither are intended as public-facing APIs and you almost certainly should not have code which relies on this.
• Removed the rarely useful bin/repository lookup-users debugging worklfow.

Amazon SES

If you send email with Amazon SES, this version of Phabricator includes changes which impact you.

Older versions of Phabricator send email through SES using AWS "v3" API signatures. Amazon has stated that this signature method will no longer be accepted by SES starting October 1, 2020.

Beginning October 1st, 2020, Amazon SES will only support requests signed using Signature Version 4. If you use an older version of the AWS Signature, you must adopt AWS Signature Version 4 prior to that date.
https://docs.aws.amazon.com/ses/latest/DeveloperGuide/using-ses-api-authentication.html

This release of Phabricator switches to the modern AWS "v4" API signature for calls to SES.

When you update, you will need to make a small change to your mailer configuration in Phabricator (the cluster.mailers configuration setting), to add the new 'region' parameter that v4 signatures require. The change will generally look like this:

  {
    "key": "your-ses-mailer-name",
    "type": "ses",
    "options": {
      "access-key": "ABCDEF...",
      "secret-key": "81mf1naf...",
+     "region": "us-west-2",
      "endpoint": "email.us-west-2.amazonaws.com"
    }
  }

(Under the most common setup, this value is stored in phabricator/conf/local/local.json and can be updated by editing that file directly.)

Daemon Stability

• [] Fixed a slow memory leak in overseers which could affect daemon stability.
• [] Fixed an improper access to an obsolete pid property which could affect daemon stability.

Minor

• [] When printing a document to paper or a PDF, timestamps are now rendered in an absolute, context-free format. For example, the screen display date Jun 17 2019, 10:34 AM may be rendered as 2019-06-17 10:34:11 (UTC-7) when printed, so you don't need to know the year the document was printed or the viewer's local timezone to interpret the date accurately.
• [] Fixed an issue where some "passthru" commands were not shown in the "--trace" log.
• Fixed an issue where quoting comment text did not work properly in Pholio.
• [] It is now an error to pass a list of raw database rows to loadAllFromArray() that duplicate primary keys.
  • Fixed an issue where certain revision queries by commit hash incorrectly passed a list with duplicate primary keys. This was unlikely to cause any user-visible incorrect behavior.
• [] Added some missing indexes to the DrydockRepositoryOperation table.
• When a process elects to run worker tasks inline, then queues worker tasks which fail permanently, the parent process now continues to execute. (This is consistent with the behavior if it had queued the tasks for processing in the background rather than inline.)

The [] icon indicates a change backed by support mana.