Change Details

**Problem description: **When Phabricator "allow-public" is true and a repository is only accessible for certain users (non public) a push/pull failes with "404 No such repository". **Reason:** DiffusionServeController.php:86 -> If allow-public is set to true, no further check is done if the repository is even accessible as anonymous.

**Problem description: **When Phabricator "allow-public" is true and a repository is only accessible for certain users (non public) a push/pull failes with "404 No such repository". 1. Set phabricator to public 2. Set Diffusion `Can Use Application`, `Default View Policy` and `Default Push Policy` to a Project (I think this step has not been done in the previous attempt) 3. Create a git repository with `Visibile To`, `Pushable By` set to a Project 4. Try to push/pull the repo: ``` git push fatal: repository 'https://xyz/diffusion/MS/test.git/' not found ``` After applying the patch it is possible to push/pull as expected: ``` git push Everything up-to-date ``` **Reason:** DiffusionServeController.php -> If allow-public is set to true, no further check is done if the repository is even accessible as anonymous.

**Problem description: **When Phabricator "allow-public" is true and a repository is only accessible for certain users (non public) a push/pull failes with "404 No such repository". 1. Set phabricator to public 2. Set Diffusion `Can Use Application`, `Default View Policy` and `Default Push Policy` to a Project (I think this step has not been done in the previous attempt) 3. Create a git repository with `Visibile To`, `Pushable By` set to a Project 4. Try to push/pull the repo: ``` git push fatal: repository 'https://xyz/diffusion/MS/test.git/' not found ``` After applying the patch it is possible to push/pull as expected: ``` git push Everything up-to-date ``` **Reason:** DiffusionServeController.php:86 -> If allow-public is set to true, no further check is done if the repository is even accessible as anonymous.