Change Details

Similar to T9469. On a fresh installation with the database set up with unprivileged db user, I get a redirect loop to '/auth/register/'. After setting debug-stop-on-redirect to true, I got the following: ```Depth Library File Where 6 phabricator applications/auth/controller/PhabricatorAuthStartController.php : 65 AphrontRedirectResponse::__construct() 5 phabricator aphront/AphrontController.php : 71 PhabricatorAuthStartController::handleRequest() 4 phabricator applications/base/controller/PhabricatorController.php : 191 AphrontController::delegateToController() 3 phabricator aphront/configuration/AphrontApplicationConfiguration.php : 224 PhabricatorController::willBeginExecution() 2 phabricator aphront/configuration/AphrontApplicationConfiguration.php : 149 AphrontApplicationConfiguration::processRequest() 1 /srv/www/vhosts/phabricator.cynistar.net/live/phabricator/phabricator/webroot/index.php : 17 AphrontApplicationConfiguration::runHTTPRequest()``` Also, when hitting bare domain URL, I get: Request parameter '__path__' is set, but empty. Your rewrite rules are not configured correctly. The '__path__' should always begin with a '/'. I had to precede all the Apache RewriteRule directives with "RewriteCond %{ENV:REDIRECT_STATUS} ^$" because the app was constantly redirect looping even before I got to this point. I thought I had that nonsense sorted out but apparently not. Stripped bare, the Apache config is: <VirtualHost *:80> ServerAdmin webmaster@example.net ServerName phabricator.example.net DocumentRoot /srv/www/vhosts/phabricator.example.net/live/phabricator/phabricator/webroot LogLevel debug ErrorLog /var/log/apache2/phabricator.example.net-error_log CustomLog /var/log/apache2/phabricator.example.net-access_log combined HostnameLookups Off UseCanonicalName Off ServerSignature On <Directory "/srv/www/vhosts/phabricator.example.net/live/phabricator/phabricator/webroot"> RewriteEngine on RewriteCond %{ENV:REDIRECT_STATUS} ^$ RewriteRule ^/rsrc/(.*) - [L,QSA] RewriteCond %{ENV:REDIRECT_STATUS} ^$ RewriteRule ^/favicon.ico - [L,QSA] RewriteCond %{ENV:REDIRECT_STATUS} ^$ RewriteRule ^(.*)$ /index.php?__path__=$1 [B,L,QSA] Order allow,deny Allow from all </Directory> </VirtualHost> FWIW, the LAMP setup this is running on has been in production successfully for several years, so it's unlikely to be a problem with the server, just with the app or this specific virtual host config. The virtual host config is essentially identical to the other 20+ on the system and there's not much to it aside from the rewrite rules pulled straight from the configuration guide. Any hints on how to knock some sense into mod_rewrite?

Similar to T9469. On a fresh installation with the database set up with unprivileged db user, I get a redirect loop to '/auth/register/'. After setting debug-stop-on-redirect to true, I got the following: ```Depth Library File Where 6 phabricator applications/auth/controller/PhabricatorAuthStartController.php : 65 AphrontRedirectResponse::__construct() 5 phabricator aphront/AphrontController.php : 71 PhabricatorAuthStartController::handleRequest() 4 phabricator applications/base/controller/PhabricatorController.php : 191 AphrontController::delegateToController() 3 phabricator aphront/configuration/AphrontApplicationConfiguration.php : 224 PhabricatorController::willBeginExecution() 2 phabricator aphront/configuration/AphrontApplicationConfiguration.php : 149 AphrontApplicationConfiguration::processRequest() 1 /srv/www/vhosts/phabricator.cynistar.net/live/phabricator/phabricator/webroot/index.php : 17 AphrontApplicationConfiguration::runHTTPRequest()``` Also, when hitting bare domain URL, I get: ``` Request parameter '__path__' is set, but empty. Your rewrite rules are not configured correctly. The '__path__' should always begin with a '/'. ``` I had to precede all the Apache RewriteRule directives with `RewriteCond %{ENV:REDIRECT_STATUS} ^$` because the app was constantly redirect looping even before I got to this point. I thought I had that nonsense sorted out but apparently not. Stripped bare, the Apache config is: ``` <VirtualHost *:80> ServerAdmin webmaster@example.net ServerName phabricator.example.net DocumentRoot /srv/www/vhosts/phabricator.example.net/live/phabricator/phabricator/webroot LogLevel debug ErrorLog /var/log/apache2/phabricator.example.net-error_log CustomLog /var/log/apache2/phabricator.example.net-access_log combined HostnameLookups Off UseCanonicalName Off ServerSignature On <Directory "/srv/www/vhosts/phabricator.example.net/live/phabricator/phabricator/webroot"> RewriteEngine on RewriteCond %{ENV:REDIRECT_STATUS} ^$ RewriteRule ^/rsrc/(.*) - [L,QSA] RewriteCond %{ENV:REDIRECT_STATUS} ^$ RewriteRule ^/favicon.ico - [L,QSA] RewriteCond %{ENV:REDIRECT_STATUS} ^$ RewriteRule ^(.*)$ /index.php?__path__=$1 [B,L,QSA] Order allow,deny Allow from all </Directory> </VirtualHost> ``` FWIW, the LAMP setup this is running on has been in production successfully for several years, so it's unlikely to be a problem with the server, just with the app or this specific virtual host config. The virtual host config is essentially identical to the other 20+ on the system and there's not much to it aside from the rewrite rules pulled straight from the configuration guide. Any hints on how to knock some sense into mod_rewrite?

Similar to T9469. On a fresh installation with the database set up with unprivileged db user, I get a redirect loop to '/auth/register/'. After setting debug-stop-on-redirect to true, I got the following: ```Depth Library File Where 6 phabricator applications/auth/controller/PhabricatorAuthStartController.php : 65 AphrontRedirectResponse::__construct() 5 phabricator aphront/AphrontController.php : 71 PhabricatorAuthStartController::handleRequest() 4 phabricator applications/base/controller/PhabricatorController.php : 191 AphrontController::delegateToController() 3 phabricator aphront/configuration/AphrontApplicationConfiguration.php : 224 PhabricatorController::willBeginExecution() 2 phabricator aphront/configuration/AphrontApplicationConfiguration.php : 149 AphrontApplicationConfiguration::processRequest() 1 /srv/www/vhosts/phabricator.cynistar.net/live/phabricator/phabricator/webroot/index.php : 17 AphrontApplicationConfiguration::runHTTPRequest()``` Also, when hitting bare domain URL, I get: ``` Request parameter '__path__' is set, but empty. Your rewrite rules are not configured correctly. The '__path__' should always begin with a '/'. ``` I had to precede all the Apache RewriteRule directives with "`RewriteCond %{ENV:REDIRECT_STATUS} ^$"` because the app was constantly redirect looping even before I got to this point. I thought I had that nonsense sorted out but apparently not. Stripped bare, the Apache config is: ``` <VirtualHost *:80> ServerAdmin webmaster@example.net ServerName phabricator.example.net DocumentRoot /srv/www/vhosts/phabricator.example.net/live/phabricator/phabricator/webroot LogLevel debug ErrorLog /var/log/apache2/phabricator.example.net-error_log CustomLog /var/log/apache2/phabricator.example.net-access_log combined HostnameLookups Off UseCanonicalName Off ServerSignature On <Directory "/srv/www/vhosts/phabricator.example.net/live/phabricator/phabricator/webroot"> RewriteEngine on RewriteCond %{ENV:REDIRECT_STATUS} ^$ RewriteRule ^/rsrc/(.*) - [L,QSA] RewriteCond %{ENV:REDIRECT_STATUS} ^$ RewriteRule ^/favicon.ico - [L,QSA] RewriteCond %{ENV:REDIRECT_STATUS} ^$ RewriteRule ^(.*)$ /index.php?__path__=$1 [B,L,QSA] Order allow,deny Allow from all </Directory> </VirtualHost> ``` FWIW, the LAMP setup this is running on has been in production successfully for several years, so it's unlikely to be a problem with the server, just with the app or this specific virtual host config. The virtual host config is essentially identical to the other 20+ on the system and there's not much to it aside from the rewrite rules pulled straight from the configuration guide. Any hints on how to knock some sense into mod_rewrite?