Change Details

The landing page of a Diffusion repository consists of multiple components -- file browse, history, branches, etc. Occasionally an error will occur when creating the content for one of these pieces, which when it does so will cause the entire landing page content to be replaced with an error message. This can happen when e.g. deleting recent local state for a repository, causing the history view to attempt querying a non-existent commit (see also T13365). This behavior is usually expected however in the case of repositories it's very helpful to access the Manage repositories piece when these errors occur. Normally this is accessed by going to the Actions > Manage menu option from the landing page but this component becomes inaccessible if any of the other content pieces runs into an error being generated. The behavior here could be better by e.g. only showing the error information within the section content of the page that had the issue, but still loading other components which don't fail to load.

On non-clustered installations the semantics of error handling Futures is different than for clustered installations. The result for non-clustered installations is that when an error happens querying history (or querying file paths for browse, branches, etc.) an exception is thrown during the construction of the query future rather than the resolution of the future. The construction of the futures is not guarded by try/catch and the end result to the user is that no content appears. The intent of this page is to still render parts of the page which succeed in having their content loaded, particularly the ability the access the Actions > Manage button. To reproduce: 1. Configure a non-clustered environment with a repository 2. Remove a recent changeset from the repository's on-disk state 3. Navigate to the repository's main page The result is a page with the error but no other controls: {F9660766} Additionally, this specific error occurs when trying to query recent history of the repository, of which the history is no longer used on this page. This query can be outright removed, reducing the chance of an error happening and possibly improving the loading of the page.

The landing page of a Diffusion repository consists of multiple components -- file browse,On non-clustered installations the semantics of error handling Futures is different than for clustered installations. The result for non-clustered installations is that when an error happens querying historyory (or querying file paths for browse, branches, etc. Occasionally an error will occur when creating the content for one of these pieces, which when it does so will cause the entire landing page content to be replaced with an error messag) an exception is thrown during the construction of the query future rather than the resolution of the future. This can happen when e.gThe construction of the futures is not guarded by try/catch and the end result to the user is that no content appears. deleting recent local state for a repositoryThe intent of this page is to still render parts of the page which succeed in having their content loaded, causing the history view to attempt querying a non-existent commit (see also T13365)particularly the ability the access the Actions > Manage button. This behavior is usually expected however in the case of repositories it's very helpful to access the Manage repositories piece when these errors occuro reproduce: 1. Configure a non-clustered environment with a repository 2. Remove a recent changeset from the repository's on-disk state 3. Normally this is accessed by going to the Actions > Manage menu option from the landing page but this component becomes inaccessible if any of the other content pieces runs into an error being generated.avigate to the repository's main page The behavior here could be better by e.gresult is a page with the error but no other controls: {F9660766} Additionally, this specific error occurs when trying to query recent history of the repository, of which the history is no longer used on this page. only showing the error information within the section content of the page that had the issueThis query can be outright removed, but still loading other components which don't fail to loadreducing the chance of an error happening and possibly improving the loading of the page.