Using arcanist on git commit 59640f7eae3f7c0a352c18e784fb55acb7967991, the following errors can be seen:
```
$ bin/arc unit --everything --no-coverage
```
# 1
```
FAIL ArcanistPhpcsLinterTestCase::testVersion
Assertion failed, expected 'true' (at ArcanistExternalLinterTestCase.php:10): Failed to parse version from command.
ACTUAL VALUE
false
```
I am using PHP_CodeSniffer 1.5.0RC4, so it seems that regexp in src/lint/linter/ArcanistPhpcsLinter.php does not match
- `$ phpcs --version`
- `PHP_CodeSniffer version 1.5.0RC4 (beta) by Squiz (http://www.squiz.net)`
Here is a quick and dirty patch:
```
diff --git a/src/lint/linter/ArcanistPhpcsLinter.php b/src/lint/linter/ArcanistPhpcsLinter.php
index 8475c55..5364ec3 100644
--- a/src/lint/linter/ArcanistPhpcsLinter.php
+++ b/src/lint/linter/ArcanistPhpcsLinter.php
@@ -88,7 +88,7 @@ final class ArcanistPhpcsLinter extends ArcanistExternalLinter {
list($stdout) = execx('%C --version', $this->getExecutableCommand());
$matches = array();
- $regex = '/^PHP_CodeSniffer version (?P<version>\d+\.\d+\.\d+)\b/';
+ $regex = '/^PHP_CodeSniffer version (?P<version>\d+\.\d+\.\d+)(RC\d)?\b/';
if (preg_match($regex, $stdout, $matches)) {
return $matches['version'];
} else {
```
# 2
```
FAIL ArcanistPyLintLinterTestCase::testLinter
In 'pylint.lint-test', expected lint to raise warning on line 1 at char 0, but no warning was raised. Actually raised:
disabled at line 1, char 0: W0611 PyLint W0611
disabled at line 1, char 0: C0111 PyLint C0111
disabled at line 1, char 0: W0611 PyLint W0611
disabled at line 3, char 0: E0602 PyLint E0602
```
pylint config have been made that way:
- `$ bin/arc set-config --local lint.pylint.codes.advice '^(C|R).*'`
- `$ bin/arc set-config --local lint.pylint.codes.error '^(E|F).*'`
- `$ bin/arc set-config --local lint.pylint.codes.warning '^W.*'`
Would not it be nice to provide a default pylint config ?
# 3
```
FAIL ArcanistXMLLinterTestCase::testLinter
In 'attr3.lint-test', expected lint to raise warning on line 4 at char 24, but no warning was raised. Actually raised:
warning at line 4, char 28: XML501 LibXML Error
```