It would be helpful to have a consistent way of commenting on images anywhere in Phabricator. Most commonly, tasks, diffs, and Pholio Mocks. I've put together some initial drafts which I'll attach here in a bit but essentially I think Pholio itself is useful for large / new projects where quick inline commenting on tasks/diffs will more likely be useful on a day to day basis. I also think this will give us a better opportunity to explore Pholio as more than just 'see image, leave comment' application. This would consist of:
- Pholio / Lightbox would share UI
- Inline Comments could be toggled on/off
- Inline Comments appear in Transactions, trigger lightbox if clicked.
- Differential to get 1-up and 2-up views for actually reviewing images.