Change Details

As an example, Here's a commit to a public project which is internally managed with Phabricator, but publicly available on GitHub: https://github.com/paperg/terraform-fleet/commit/4815ad799adb9016157e2f3095da459a82f9ccd3 ``` Update state appropriately when unit does not exist Summary: If a unit that existed in the past no longer exists, we must inform Terraform of that fact so that it can plan to re-create it. Ref T39. Test Plan: Deployed the test phabricator deployment I'm working on. Deleted the units with fleetctl behind Terraform's back. Ran `terraform plan`, and saw that it was planning to re-create the units I deleted. Reviewers: kian, #developers Reviewed By: kian, #developers Maniphest Tasks: T39 Differential Revision: https://phabricator.paperg.com/D30 ``` Note how Phabricator inserts a full link to the differential revision. This cool, because if I'm viewing the commit message in GitHub, or on the console with `git log`, I can just click it and go to differential. However, "Manifest Tasks" is not a link. To view this I have to copy it, open up a browser window, navigate to Phabricator, and paste the ticket number. Making that a link would not only make some of my own work easier, but it would make it stupid easy for my coworkers to go from "overheard Phil talk about fabricator" to "Actually looked at Phabricator."

As an example, Here's a commit to a public project which is internally managed with Phabricator, but publicly available on GitHub: https://github.com/paperg/terraform-fleet/commit/4815ad799adb9016157e2f3095da459a82f9ccd3 ``` Update state appropriately when unit does not exist Summary: If a unit that existed in the past no longer exists, we must inform Terraform of that fact so that it can plan to re-create it. Ref T39. Test Plan: Deployed the test phabricator deployment I'm working on. Deleted the units with fleetctl behind Terraform's back. Ran `terraform plan`, and saw that it was planning to re-create the units I deleted. Reviewers: kian, #developers Reviewed By: kian, #developers Maniphest Tasks: T39 Differential Revision: https://phabricator.paperg.com/D30 ``` Note how Phabricator inserts a full link to the differential revision. This cool, because if I'm viewing the commit message in GitHub, or on the console with `git log`, I can just click it and go to differential. However, "Maniphest Tasks" is not a link. To view this I have to copy it, open up a browser window, navigate to Phabricator, and paste the ticket number. Making that a link would not only make some of my own work easier, but it would make it stupid easy for my coworkers to go from "overheard Phil talk about fabricator" to "Actually looked at Phabricator."

As an example, Here's a commit to a public project which is internally managed with Phabricator, but publicly available on GitHub: https://github.com/paperg/terraform-fleet/commit/4815ad799adb9016157e2f3095da459a82f9ccd3 ``` Update state appropriately when unit does not exist Summary: If a unit that existed in the past no longer exists, we must inform Terraform of that fact so that it can plan to re-create it. Ref T39. Test Plan: Deployed the test phabricator deployment I'm working on. Deleted the units with fleetctl behind Terraform's back. Ran `terraform plan`, and saw that it was planning to re-create the units I deleted. Reviewers: kian, #developers Reviewed By: kian, #developers Maniphest Tasks: T39 Differential Revision: https://phabricator.paperg.com/D30 ``` Note how Phabricator inserts a full link to the differential revision. This cool, because if I'm viewing the commit message in GitHub, or on the console with `git log`, I can just click it and go to differential. However, "Manifestphest Tasks" is not a link. To view this I have to copy it, open up a browser window, navigate to Phabricator, and paste the ticket number. Making that a link would not only make some of my own work easier, but it would make it stupid easy for my coworkers to go from "overheard Phil talk about fabricator" to "Actually looked at Phabricator."