Change Details

I rarely use <fb code base>, but when I do, I usually hit this issue: - cd into <fb code base>, which is on master, and fast forward it - make minor fix - arc amend - get diff reviewed - follow phabricator instructions and run "arc land master" - see this fail because it's not allowed to run on master - figure out how to fix this mess and get my commit landed So, if arc knows that I shouldn't be committing to master, why does "arc amend" let me do it? Proposed solution: Step 1) Warn against this behavior on arc diff/amend Step 2) Automatically fix this (move the tasks onto a non master branch and reset master) on arc diff/amend/land Step 3 (long term): Allow this to actually work "arc land master --onto master" makes sense if master is considered origin/master in git (hg may be a little more difficult)

I rarely use <fb code base>, but when I do, I usually hit this issue: # `cd` into <fb code base>, which is on `master`, and fast forward it # Make minor fix # `arc amend` # Get diff reviewed # Follow Phabricator instructions and run `arc land master` # See this fail because it's not allowed to run on master # Figure out how to fix this mess and get my commit landed So, if `arc` knows that I shouldn't be committing to master, why does `arc amend` let me do it? **Proposed solution** # Warn against this behavior on `arc diff` / `arc amend` # Automatically fix this (move the tasks onto a non-master branch and reset master) on `arc diff` / `arc amend` / `arc land` # **Long term:** Allow this to actually work... `arc land master --onto master` makes sense if `master` is considered `origin/master` in `git` (`hg` may be a little more difficult)

I rarely use <fb code base>, but when I do, I usually hit this issue: - cd# `cd` into <fb code base>, which is on `master`, and fast forward it - m# Make minor fix - # `arc amend` - g# Get diff reviewed - f# Follow pPhabricator instructions and run "`arc land master"` - see# See this fail because it's not allowed to run on master - f# Figure out how to fix this mess and get my commit landed So, if arcif `arc` knows that I shouldn't be committing to master, why does "`arc amend"` let me do it? **Proposed solution:** Step 1)# Warn against this behavior on `arc diff/` / `arc amend` Step 2)# Automatically fix this (move the tasks onto a non non-master branch and reset master) on `arc diff/` / `arc amend/` / `arc land` Step 3 (l# **Long term)::** Allow this to actually work "... `arc land master --onto master"` makes sense if `master` is considered `origin/master` in git (hg`git` (`hg` may be a little more difficult)