Let me know if you have any questions or difficulty reproducing. Thanks!
**Reproduction steps:**
- make new branch
- commit code changes
- arc diff for a code review
- have code review approved
- commit more changes to the branch
- arc land
**Expected result:**
- push fails due to Herold Rule (`H2`) not being satisfied for the commit to be pushed
**Actual result:**
- All code (reviewed and unreviewed) is pushed to develop
**Our Herold Rule(`H2`):**
When all of these conditions are met:
- Branches matches regexp @^develop$@
- Another Herald rule does not match: `H9` ARMI Code Architect Review Completed
Take these actions every time this rule matches:
- Block push with message: Please do a code review before pushing to origin/develop. Find out how at https://ubuntuprod.tp.int/w/phabricator_training/code_review/
- Send an email to: ntouran, gmalmgren,
**Referenced Herold Rule(`H9`):**
When all of these conditions are met:
- Differential reviewers include any of ntouran, gmalmgren
- Accepted Differential revision exists
Take these actions every time this rule matches:
- Do nothing.
|Name| Version|
|phabricator |0426ce73f0e63f1900f1cc285cfa1465ea72317e (Jan 13 2017) (branched from 7276af6a81f49bbdc14ace064aab50afbeb79cfc on origin)|
|arcanist| 9503b941cc02be637d967bb50cfb25f852e071e4 (Jan 6 2017) (branched from ade25facfdf22aed1c1e20fed3e58e60c0be3c2b on origin)|
|phutil |10963f771f118baa338aacd3172aaede695cde62 (Jan 13 2017) (branched from 9d85dfab0f532d50c2343719e92d574a4827341b on origin)|