Change Details

T10366 has broken our use of Harbormaster. We are using Jenkins as our continous integration server and mercurial as our VCS. We have a build plan that consists of one step "Make HTTP request". The URI of this build step is set to https://<jenkins server>/mercurial/notifyCommit?url=${repository.uri} Unfortunately the bug in question has changed what the variable ${repository.uri} resolves to. It no longer resolves to the correct URI but instead is resolving to some internal hidden version of the uri. This causes jenkins to say that there are no jenkins jobs that correspond to the uri in question. I suggest one of several possible solutions: 1. Make ${repository.uri} go back to previous behaviour (e.g. don't return the internal hidden uri but the public visible one) 2. Add some other variable(s) that will return the publicly visible uri so that I can restore CI functionality.

I am not sure what is unclear but here are the steps to reproduce: 1. Create Build Plan in harbourmaster with 1 step. 2. The Step should be of type "Make HTTP Request" 3. Set URI https://<jenkins server>/mercurial/notifyCommit?url=${repository.uri} 4. Check in something into repo with CALLSIGN REPO 5. Observe Build plan reports the following: "No Mercurial jobs found using repository: https://<phabricator server>/diffusion/62/repo/" The reason is that ${repository.uri} is returning https://<phabricator server>/diffusion/62/repo/ insteand of https://<phabricator server>/diffusion/REPO/repo/ T10366 has broken our use of Harbormaster. We are using Jenkins as our continous integration server and mercurial as our VCS. We have a build plan that consists of one step "Make HTTP request". The URI of this build step is set to https://<jenkins server>/mercurial/notifyCommit?url=${repository.uri} Unfortunately the bug in question has changed what the variable ${repository.uri} resolves to. It no longer resolves to the correct URI but instead is resolving to some internal hidden version of the uri. This causes jenkins to say that there are no jenkins jobs that correspond to the uri in question. I suggest one of several possible solutions: 1. Make ${repository.uri} go back to previous behaviour (e.g. don't return the internal hidden uri but the public visible one) 2. Add some other variable(s) that will return the publicly visible uri so that I can restore CI functionality.

I am not sure what is unclear but here are the steps to reproduce: 1. Create Build Plan in harbourmaster with 1 step. 2. The Step should be of type "Make HTTP Request" 3. Set URI https://<jenkins server>/mercurial/notifyCommit?url=${repository.uri} 4. Check in something into repo with CALLSIGN REPO 5. Observe Build plan reports the following: "No Mercurial jobs found using repository: https://<phabricator server>/diffusion/62/repo/" The reason is that ${repository.uri} is returning https://<phabricator server>/diffusion/62/repo/ insteand of https://<phabricator server>/diffusion/REPO/repo/ T10366 has broken our use of Harbormaster. We are using Jenkins as our continous integration server and mercurial as our VCS. We have a build plan that consists of one step "Make HTTP request". The URI of this build step is set to https://<jenkins server>/mercurial/notifyCommit?url=${repository.uri} Unfortunately the bug in question has changed what the variable ${repository.uri} resolves to. It no longer resolves to the correct URI but instead is resolving to some internal hidden version of the uri. This causes jenkins to say that there are no jenkins jobs that correspond to the uri in question. I suggest one of several possible solutions: 1. Make ${repository.uri} go back to previous behaviour (e.g. don't return the internal hidden uri but the public visible one) 2. Add some other variable(s) that will return the publicly visible uri so that I can restore CI functionality.