Change Details

See <https://twitter.com/pkhuong/status/1289242309951807488>. There's currently no "move/copy" gutter on unified diffs, and the gutter does not have an aural cue (like "Line 15-25 were copied from X.c") for screen readers. The gutter should be available on unified diffs, and both the unified and 2-up gutters should have aural cues (although the unified mode is likely far more useful for users who use screen readers). See PHI1877. The coverage gutter isn't part of 1-up diffs. See PHI1965. This reports a couple of other display bugs with inline comment counts. See PHI1958. An install produces at least some changes which touch hundreds of generated files. Currently, changes which are mostly generated files are much more difficult to review than necessary, especially when generated files push the change over UI fallback breakpoints. When you "Quote" a comment, then cancel, the comment disappears from the UI. However, it is not deleted on the server side and appears on reload. If you "Quote", then "Cancel", then "Quote", the header count can get out of sync (possibly counting the invisible comment). - See comment below. - See PHI1965. --- //Done// When toggling diff display modes, the inline comment count in the UI header can lose sync with the page (comments removed when the old changeset is replaced are not subtracted from the count). - See PHI1968. - See PHI1877. - Resolved by D21642. When you create two comments (A and B), then delete A, then delete B, then "Undo" the deletion of A: B undeletes instead. - Resolved by D21650.

See <https://twitter.com/pkhuong/status/1289242309951807488>. There's currently no "move/copy" gutter on unified diffs, and the gutter does not have an aural cue (like "Line 15-25 were copied from X.c") for screen readers. The gutter should be available on unified diffs, and both the unified and 2-up gutters should have aural cues (although the unified mode is likely far more useful for users who use screen readers). See PHI1877. The coverage gutter isn't part of 1-up diffs. See PHI1958. An install produces at least some changes which touch hundreds of generated files. Currently, changes which are mostly generated files are much more difficult to review than necessary, especially when generated files push the change over UI fallback breakpoints. When you "Quote" a comment, then cancel, the comment disappears from the UI. However, it is not deleted on the server side and appears on reload. If you "Quote", then "Cancel", then "Quote", the header count can get out of sync (possibly counting the invisible comment). - See comment below. - See PHI1965. --- //Done// When toggling diff display modes, the inline comment count in the UI header can lose sync with the page (comments removed when the old changeset is replaced are not subtracted from the count). - See PHI1968. - See PHI1877. - Resolved by D21642. When you create two comments (A and B), then delete A, then delete B, then "Undo" the deletion of A: B undeletes instead. - Resolved by D21650.

See <https://twitter.com/pkhuong/status/1289242309951807488>. There's currently no "move/copy" gutter on unified diffs, and the gutter does not have an aural cue (like "Line 15-25 were copied from X.c") for screen readers. The gutter should be available on unified diffs, and both the unified and 2-up gutters should have aural cues (although the unified mode is likely far more useful for users who use screen readers). See PHI1877. The coverage gutter isn't part of 1-up diffs. See PHI1965. This reports a couple of other display bugs with inline comment counts. See PHI1958. An install produces at least some changes which touch hundreds of generated files. Currently, changes which are mostly generated files are much more difficult to review than necessary, especially when generated files push the change over UI fallback breakpoints. When you "Quote" a comment, then cancel, the comment disappears from the UI. However, it is not deleted on the server side and appears on reload. If you "Quote", then "Cancel", then "Quote", the header count can get out of sync (possibly counting the invisible comment). - See comment below. - See PHI1965. --- //Done// When toggling diff display modes, the inline comment count in the UI header can lose sync with the page (comments removed when the old changeset is replaced are not subtracted from the count). - See PHI1968. - See PHI1877. - Resolved by D21642. When you create two comments (A and B), then delete A, then delete B, then "Undo" the deletion of A: B undeletes instead. - Resolved by D21650.