Diffusion Phabricator (stable) History

phabricator/src/infrastructure
stable

Sat, May 22

2124c8af6d2d (stable) Promote 2021 Week 21
Author
epriestley
Browse Repository
Passed
Audit Required

Mar 29 2021

1308a5555fee Update client logic for inline comment "Save" and "Cancel" actions
Author
epriestley
Revisions
D21654: Update client logic for inline comment "Save" and "Cancel" actions
Browse Repository
Passed
No Audits

6fd55d692f14 Formally track "initial", "committed", and "active" states for inline comments
Author
epriestley
Revisions
D21653: Formally track "initial", "committed", and "active" states for inline comments
Browse Repository
Passed
No Audits

b75517918d86 When creating an inline comment, populate the content state with the default…
Author
epriestley
Revisions
D21652: When creating an inline comment, populate the content state with the default suggestion text
Browse Repository
Passed
No Audits

428fff2e58f3 Fix an issue when undoing mutiple inline comment deletions
Author
epriestley
Revisions
D21650: Fix an issue when undoing mutiple inline comment deletions
Browse Repository
Passed
No Audits

d30c3a961cd9 Make the client authoritative for "Cancel" actions
Author
epriestley
Revisions
D21649: Make the client authoritative for "Cancel" actions
Browse Repository
Passed
No Audits

60e869f4114f Make the client authoritative for "Save" actions
Author
epriestley
Revisions
D21648: Make the client authoritative for "Save" actions
Browse Repository
Passed
No Audits

Mar 26 2021

da8a579600c0 (stable) Promote 2021 Week 13
Author
epriestley
Browse Repository
Passed
Audit Required

Mar 16 2021

42c0c0e3d23a Remove or correct various "phabricator/" references to "libphutil"
Author
epriestley
Revisions
D21624: Remove or correct various "phabricator/" references to "libphutil"
Browse Repository
Passed
No Audits

Mar 13 2021

e7d3bae2cc3f (stable) Promote 2021 Week 11
Author
epriestley
Browse Repository
Passed
Audit Required

Mar 11 2021

32da29b96569 Provide more help around GRANT errors, particularly for missing TEMPORARY TABLE…
Author
epriestley
Revisions
D21608: Provide more help around GRANT errors, particularly for missing TEMPORARY TABLE permission
Browse Repository
Passed
No Audits

Mar 3 2021

629429b28354 (stable) Never return external connections to the GlobalLock connection pool
Author
epriestley
Revisions
D21585: Never return external connections to the GlobalLock connection pool
Browse Repository
Passed
No Audits

4aecb6f25d12 (stable) Refuse to acquire a second GlobalLock on a connection
Author
epriestley
Revisions
D21586: Refuse to acquire a second GlobalLock on a connection
Browse Repository
Passed
No Audits

84049ed4793c (stable) Prevent external connections from being mutated on held locks
Author
epriestley
Revisions
D21584: Prevent external connections from being mutated on held locks
Browse Repository
Passed
No Audits

aa2d89f1d4c5 (stable) When a GlobalLock with an external connection is released, don't…
Author
epriestley
Revisions
D21583: When a GlobalLock with an external connection is released, don't return it to the pool
Browse Repository
Passed
No Audits

Mar 2 2021

33bce22ef2ad Never return external connections to the GlobalLock connection pool
Author
epriestley
Revisions
D21585: Never return external connections to the GlobalLock connection pool
Browse Repository
Passed
No Audits

2b473558c2b3 Refuse to acquire a second GlobalLock on a connection
Author
epriestley
Revisions
D21586: Refuse to acquire a second GlobalLock on a connection
Browse Repository
Passed
No Audits

466013f11a6d Prevent external connections from being mutated on held locks
Author
epriestley
Revisions
D21584: Prevent external connections from being mutated on held locks
Browse Repository
Passed
No Audits

15dbf6bdf0a5 When a GlobalLock with an external connection is released, don't return it to…
Author
epriestley
Revisions
D21583: When a GlobalLock with an external connection is released, don't return it to the pool
Browse Repository
Passed
No Audits

Feb 19 2021

05745dfd024b (stable) Promote 2021 Week 8
Author
epriestley
Browse Repository
Passed
Audit Required

Feb 18 2021

8cfd22c5fe88 Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern
Author
epriestley
Revisions
D21568: Add a negative lookbehind to the Remarkup "bare URI" regular expression pattern
Browse Repository
Passed
No Audits

Feb 17 2021

bd4d9d88f2df Limit remarkup URI protocol length to 32 characters to avoid expensive regex…
Author
epriestley
Revisions
D21562: Limit remarkup URI protocol length to 32 characters to avoid expensive regex behavior
Browse Repository
Passed
No Audits

Feb 13 2021

90903282c706 Render user hovercards with context information about their ability to see the…
Author
epriestley
Revisions
D21554: Render user hovercards with context information about their ability to see the context object
Browse Repository
Passed
No Audits

Feb 7 2021

3e42f8be126f (stable) Promote 2021 Week 6
Author
epriestley
Browse Repository
Passed
Audit Required

Feb 3 2021

9502312b60ae Remove "final" from "private" methods in Phabricator
Author
epriestley
Revisions
D21540: Remove "final" from "private" methods in Phabricator
Browse Repository
Passed
No Audits

Feb 2 2021

c9ab36395983 Add "bin/worker delay" and "bin/worker priority" utilities for managing task…
Author
epriestley
Revisions
D21535: Add "bin/worker delay" and "bin/worker priority" utilities for managing task queues
Browse Repository
Passed
No Audits

0203105a94e3 Add more selectors to existing "bin/worker" commands
Author
epriestley
Revisions
D21534: Add more selectors to existing "bin/worker" commands
Browse Repository
Passed
No Audits

201e0d29435c Add support for a "containerPHID" in the worker queue
Author
epriestley
Revisions
D21531: Add support for a "containerPHID" in the worker queue
Browse Repository
Passed
No Audits

32942f623250 Introduce storage patch "phases" to allow index-rebuilding patches to execute…
Author
epriestley
Revisions
D21529: Introduce storage patch "phases" to allow index-rebuilding patches to execute after worker queue schema changes
Browse Repository
Passed
No Audits

Jan 23 2021

498fcd34ac9f (stable) Promote 2021 Week 4
Author
epriestley
Browse Repository
Passed
Audit Required

15e022d64870 Support an "--active" flag for selecting active tasks
Author
epriestley
Revisions
D21517: Support an "--active" flag for selecting active tasks
Browse Repository
Passed
No Audits

Jan 12 2021

c63c2aadef3a Support "control" and "return/enter" in the remarkup rule for keystrokes
Author
epriestley
Revisions
D21508: Support "control" and "return/enter" in the remarkup rule for keystrokes
Browse Repository
Passed
No Audits

Oct 30 2020

671986592baf Add a missing "GROUP BY" to MailQuery when querying for multiple recipients
Author
epriestley
Revisions
D21486: Add a missing "GROUP BY" to MailQuery when querying for multiple recipients
Browse Repository
Passed
No Audits

Oct 19 2020

86ad69863930 (stable) When a new, deleted, draft inline is revived with "Undo", undelete it
Author
epriestley
Revisions
D21483: When a new, deleted, draft inline is revived with "Undo", undelete it
Browse Repository
Passed
No Audits

bc4f86d27996 When a new, deleted, draft inline is revived with "Undo", undelete it
Author
epriestley
Revisions
D21483: When a new, deleted, draft inline is revived with "Undo", undelete it
Browse Repository
Passed
No Audits

916bce119a2b (stable) Promote 2020 Week 42
Author
epriestley
Browse Repository
Passed
Audit Required

Oct 16 2020

2b8bbae5fb27 Set an explicit height when drawing the dependent revision graph
Author
epriestley
Revisions
D21481: Set an explicit height when drawing the dependent revision graph
Browse Repository
Passed
No Audits

Oct 2 2020

0f27cd46ccad Never render "Show More Context" inside an inline comment suggestion diff
Author
epriestley
Revisions
D21476: Never render "Show More Context" inside an inline comment suggestion diff
Browse Repository
Passed
No Audits

Sep 18 2020

5e06d924f8eb (stable) Promote 2020 Week 37
Author
epriestley
Browse Repository
Passed
Audit Required

Sep 16 2020

737e7c85412c When an in-process worker subtask fails permanently, don't fatal the whole…
Author
epriestley
Revisions
D21459: When an in-process worker subtask fails permanently, don't fatal the whole process
Browse Repository
Passed
No Audits

Sep 8 2020

6e1b5da1121c Fix additional "xprintf()"-class static parameter lint errors
Author
epriestley
Revisions
D21457: Fix additional "xprintf()"-class static parameter lint errors
Browse Repository
Passed
No Audits

Sep 4 2020

5fff4ed8dbb7 (stable) Remove obsolete write to "pid" property in "annihilateProcessGroup()"…
Author
epriestley
Revisions
D21452: Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon Overseer
Browse Repository
Passed
No Audits

69662a11d73d (stable) When printing timestamps on paper: use an absolute, context-free date…
Author
epriestley
Revisions
D21451: When printing timestamps on paper: use an absolute, context-free date format
Browse Repository
Passed
No Audits

7daaaa8463e2 Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon…
Author
epriestley
Revisions
D21452: Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon Overseer
Browse Repository
Passed
No Audits

0854425d191f When printing timestamps on paper: use an absolute, context-free date format
Author
epriestley
Revisions
D21451: When printing timestamps on paper: use an absolute, context-free date format
Browse Repository
Passed
No Audits

Aug 12 2020

72f149bf399a Require rows passed to "loadAllFromArray()" have unique keys
Author
epriestley
Revisions
D21400: Require rows passed to "loadAllFromArray()" have unique keys
Browse Repository
Passed
No Audits

9fa25253844e Improve rendering of history graph in "CommitGraphView"
Author
epriestley
Revisions
D21411: Improve rendering of history graph in "CommitGraphView"
Browse Repository
Passed
No Audits

Aug 8 2020

5e3768473711 (stable) Promote 2020 Week 31
Author
epriestley
Browse Repository
Passed
Audit Required

Aug 5 2020

ce0dc9a2ba2c Correct an apparent off-by-one error when adjusting inlines across revision…
Author
epriestley
Revisions
D21436: Correct an apparent off-by-one error when adjusting inlines across revision changes
Browse Repository
Passed
No Audits

Jul 25 2020

1b54f45c4c47 (stable) Promote 2020 Week 29
Author
epriestley
Browse Repository
Passed
Audit Required

Jul 23 2020

a27c83757d9f Remove ancient "phd.trace" and "phd.verbose" configuration options
Author
epriestley
Revisions
D21426: Remove ancient "phd.trace" and "phd.verbose" configuration options
Browse Repository
Passed
No Audits

78d1b62bb8e9 Streamline handling of Futures and PIDs in daemons
Author
epriestley
Revisions
D21425: Streamline handling of Futures and PIDs in daemons
Browse Repository
Passed
No Audits

5f0535934d72 Manage PIDs more carefully in DaemonHandle
Author
epriestley
Revisions
D21424: Manage PIDs more carefully in DaemonHandle
Browse Repository
Passed
No Audits

fcb75d0503c6 Fix an issue where prose diffing may fail after hitting the PCRE backtracking…
Author
epriestley
Revisions
D21422: Fix an issue where prose diffing may fail after hitting the PCRE backtracking limit
Browse Repository
Passed
No Audits

Jul 3 2020

b2f0937e300c (stable) Promote 2020 Week 26
Author
epriestley
Browse Repository
Passed
Audit Required

Jun 26 2020

0e4d62847cfc (stable) When acquiring a GlobalLock, put good connections that just got…
Author
epriestley
Revisions
D21369: When acquiring a GlobalLock, put good connections that just got unlucky back in the pool
Browse Repository
Passed
No Audits

22de618d3bd3 When acquiring a GlobalLock, put good connections that just got unlucky back in…
Author
epriestley
Revisions
D21369: When acquiring a GlobalLock, put good connections that just got unlucky back in the pool
Browse Repository
Passed
No Audits

May 30 2020

36075f6ce525 Correct a prose diff behavior when prose pieces include newlines
Author
epriestley
Revisions
D21295: Correct a prose diff behavior when prose pieces include newlines
Browse Repository
Passed
No Audits

May 22 2020

73024e454239 (stable) Promote 2020 Week 20
Author
epriestley
Browse Repository
Passed
Audit Required

May 20 2020

6d0dbeb77f77 Use the changeset parse cache to cache suggestion changesets
Author
epriestley
Revisions
D21280: Use the changeset parse cache to cache suggestion changesets
Browse Repository
Passed
No Audits

5d0ae283a9ab Put a readthrough cache in front of inline context construction
Author
epriestley
Revisions
D21279: Put a readthrough cache in front of inline context construction
Browse Repository
Passed
No Audits

d2d7e7f5ff1b Clean up Diffusion behaviors for inline edit suggestions
Author
epriestley
Revisions
D21278: Clean up Diffusion behaviors for inline edit suggestions
Browse Repository
Passed
No Audits

10f241352dce Render inline comment suggestions as real diffs
Author
epriestley
Revisions
D21277: Render inline comment suggestions as real diffs
Browse Repository
Passed
No Audits

846562158aae Roughly support inline comment suggestions
Author
epriestley
Revisions
D21276: Roughly support inline comment suggestions
Browse Repository
Passed
No Audits

00430fdbe117 Make server components of inline comment content handling state-oriented
Author
epriestley
Revisions
D21275: Make server components of inline comment content handling state-oriented
Browse Repository
Passed
No Audits

87bc30526b7a Make inline content "state-oriented", not "string-oriented"
Author
epriestley
Revisions
D21273: Make inline content "state-oriented", not "string-oriented"
Browse Repository
Passed
No Audits

May 19 2020

1aa0569b6086 (stable) Treat PHP7 "Throwable" exceptions like other unhandled "Exception"…
Author
epriestley
Revisions
D21271: Treat PHP7 "Throwable" exceptions like other unhandled "Exception" cases in the worker queue
Browse Repository
Passed
No Audits

4257b26abc61 Treat PHP7 "Throwable" exceptions like other unhandled "Exception" cases in the…
Author
epriestley
Revisions
D21271: Treat PHP7 "Throwable" exceptions like other unhandled "Exception" cases in the worker queue
Browse Repository
Passed
No Audits

May 15 2020

686e51655bb0 (stable) Promote 2020 Week 19
Author
epriestley
Browse Repository
Passed
Audit Required

May 14 2020

fbd57ad83232 Give selected inline comments are more obvious selected state
Author
epriestley
Revisions
D21256: Give selected inline comments are more obvious selected state
Browse Repository
Passed
No Audits

2f5398796e02 Store inline comment offset information and show it when highlighting comments
Author
epriestley
Revisions
D21250: Store inline comment offset information and show it when highlighting comments
Browse Repository
Passed
No Audits

c063e0e5ec9d Add "View Raw Remarkup" to inline comments
Author
epriestley
Revisions
D21246: Add "View Raw Remarkup" to inline comments
Browse Repository
Passed
No Audits

419b7ceebb0f Move inline comment actions into a dropdown menu
Author
epriestley
Revisions
D21244: Move inline comment actions into a dropdown menu
Browse Repository
Passed
No Audits

May 12 2020

df139f044b9b Render proper "Show Context" links in DocumentEngine diffs, not just bullets
Author
epriestley
Revisions
D21243: Render proper "Show Context" links in DocumentEngine diffs, not just bullets
Browse Repository
Passed
No Audits

0cca40db3bc6 When creating an inline, save the current document engine
Author
epriestley
Revisions
D21240: When creating an inline, save the current document engine
Browse Repository
Passed
No Audits

May 8 2020

c358cff7bd72 (stable) Promote 2020 Week 18
Author
epriestley
Browse Repository
Passed
Audit Required

b804e8cffad2 Make "View" from inline comment previews correctly jump to "isEditing" inlines
Author
epriestley
Revisions
D21237: Make "View" from inline comment previews correctly jump to "isEditing" inlines
Browse Repository
Passed
No Audits

fa2d30ee3698 Lift inline comment draft behaviors to "InlineController"
Author
epriestley
Revisions
D21235: Lift inline comment draft behaviors to "InlineController"
Browse Repository
Passed
No Audits

May 7 2020

94a95efa059a Replace "loadUnsubmittedInlineComments()" with a modern "DiffQuery"
Author
epriestley
Revisions
D21234: Replace "loadUnsubmittedInlineComments()" with a modern "DiffQuery"
Browse Repository
Passed
No Audits

79107574a762 Remove "DifferentialInlineCommentQuery"
Author
epriestley
Revisions
D21233: Remove "DifferentialInlineCommentQuery"
Browse Repository
Passed
No Audits

983d77848b4c Move the "Inline List" view to "DiffInlineCommentQuery"
Author
epriestley
Revisions
D21232: Move the "Inline List" view to "DiffInlineCommentQuery"
Browse Repository
Passed
No Audits

af5b94b23473 Lift most "InlineController" querying to the base class
Author
epriestley
Revisions
D21231: Lift most "InlineController" querying to the base class
Browse Repository
Passed
No Audits

d0593a5a788e Replace "loadDraftAndPublishedComments()" with a Query
Author
epriestley
Revisions
D21228: Replace "loadDraftAndPublishedComments()" with a Query
Browse Repository
Passed
No Audits

c1f1345cc053 Make InlineCommentQueries more robust/consistent
Author
epriestley
Revisions
D21227: Make InlineCommentQueries more robust/consistent
Browse Repository
Passed
No Audits

1656a2ff081a Allow inline comment storage objects to generate their own runtime objects
Author
epriestley
Revisions
D21226: Allow inline comment storage objects to generate their own runtime objects
Browse Repository
Passed
No Audits

May 6 2020

0067f1a521a0 Remove the obsolete "DiffusionInlineCommentPreviewController"
Author
epriestley
Revisions
D21224: Remove the obsolete "DiffusionInlineCommentPreviewController"
Browse Repository
Passed
No Audits

May 4 2020

2e51c4b00de2 (stable) Fix an issue where non-ID changeset state keys were used as changeset…
Author
epriestley
Revisions
D21223: Fix an issue where non-ID changeset state keys were used as changeset IDs
Browse Repository
Failed
No Audits

a590db28b254 Fix an issue where non-ID changeset state keys were used as changeset IDs
Author
epriestley
Revisions
D21223: Fix an issue where non-ID changeset state keys were used as changeset IDs
Browse Repository
Passed
No Audits

07e160bde1e8 When cancelling an unsaved editing inline after a reload, don't cancel into an…
Author
epriestley
Revisions
D21219: When cancelling an unsaved editing inline after a reload, don't cancel into an empty state
Browse Repository
Passed
No Audits

fe501bd7f736 Save drafts for inline comments currently being edited
Author
epriestley
Revisions
D21216: Save drafts for inline comments currently being edited
Browse Repository
Passed
No Audits

63bfad0ff476 Refine unusual inline comment client interactions
Author
epriestley
Revisions
D21212: Refine unusual inline comment client interactions
Browse Repository
Passed
No Audits

67da18e37478 When users submit "editing" inlines, warn them that their inlines will be saved
Author
epriestley
Revisions
D21191: When users submit "editing" inlines, warn them that their inlines will be saved
Browse Repository
Passed
No Audits

b2ce0844b6ff When a user clicks "Cancel" on an inline comment to leave the "Editing" state…
Author
epriestley
Revisions
D21187: When a user clicks "Cancel" on an inline comment to leave the "Editing" state, save the state change
Browse Repository
Passed
No Audits

b48a22bf50a3 Make "editing" state persistent for inline comments
Author
epriestley
Revisions
D21186: Make "editing" state persistent for inline comments
Browse Repository
Passed
No Audits

May 3 2020

462a4784325c (stable) Fix an issue where the "%%%" parser could match too many lines in…
Author
epriestley
Revisions
D21208: Fix an issue where the "%%%" parser could match too many lines in unterminated blocks
Browse Repository
Passed
No Audits

6f09edeb91e8 Fix an issue where the "%%%" parser could match too many lines in unterminated…
Author
epriestley
Revisions
D21208: Fix an issue where the "%%%" parser could match too many lines in unterminated blocks
Browse Repository
Passed
No Audits

May 1 2020

efab6b9ae33c (stable) Promote 2020 Week 17
Author
epriestley
Browse Repository
Passed
Audit Required

Apr 29 2020

f892a5858d75 (stable) Replace nonexistent "withPHIDs()" in ChangesetQuery with "withIDs()"
Author
epriestley
Revisions
D21189: Replace nonexistent "withPHIDs()" in ChangesetQuery with "withIDs()"
Browse Repository
Passed
No Audits

186a12ef7f2a Replace nonexistent "withPHIDs()" in ChangesetQuery with "withIDs()"
Author
epriestley
Revisions
D21189: Replace nonexistent "withPHIDs()" in ChangesetQuery with "withIDs()"
Browse Repository
Passed
No Audits

Apr 28 2020

f21f1d8ab9e9 Update the diff table of contents to use hierarchical views and edit distance…
Author
epriestley
Revisions
D21183: Update the diff table of contents to use hierarchical views and edit distance renames
Browse Repository
Passed
No Audits