Diffusion Phabricator (stable) History

phabricator/resources/celerity
stable

Mar 29 2021

1308a5555fee Update client logic for inline comment "Save" and "Cancel" actions
Author
epriestley
Revisions
D21654: Update client logic for inline comment "Save" and "Cancel" actions
Browse Repository
Passed
No Audits

6fd55d692f14 Formally track "initial", "committed", and "active" states for inline comments
Author
epriestley
Revisions
D21653: Formally track "initial", "committed", and "active" states for inline comments
Browse Repository
Passed
No Audits

b75517918d86 When creating an inline comment, populate the content state with the default…
Author
epriestley
Revisions
D21652: When creating an inline comment, populate the content state with the default suggestion text
Browse Repository
Passed
No Audits

5efe7fb4c181 On inline comments, track an explicit "committed" content state
Author
epriestley
Revisions
D21651: On inline comments, track an explicit "committed" content state
Browse Repository
Passed
No Audits

d30c3a961cd9 Make the client authoritative for "Cancel" actions
Author
epriestley
Revisions
D21649: Make the client authoritative for "Cancel" actions
Browse Repository
Passed
No Audits

60e869f4114f Make the client authoritative for "Save" actions
Author
epriestley
Revisions
D21648: Make the client authoritative for "Save" actions
Browse Repository
Passed
No Audits

0f04d9e58458 Remove direct reads of form state from main Inline client code
Author
epriestley
Revisions
D21647: Remove direct reads of form state from main Inline client code
Browse Repository
Passed
No Audits

cb00cb99e244 Make client inlines track an "active" state
Author
epriestley
Revisions
D21646: Make client inlines track an "active" state
Browse Repository
Passed
No Audits

b964731b6a6b Make inline "ContentState" a client object, and track "hasSuggestion" on it
Author
epriestley
Revisions
D21645: Make inline "ContentState" a client object, and track "hasSuggestion" on it
Browse Repository
Passed
No Audits

87c6c270b435 Fix an issue where inlines could be duplicated in the client list
Author
epriestley
Revisions
D21642: Fix an issue where inlines could be duplicated in the client list
Browse Repository
Passed
No Audits

Mar 17 2021

db9191f9a8d5 Correct minor "jump to symbol" behavior in Differential
Author
epriestley
Revisions
D21641: Correct minor "jump to symbol" behavior in Differential
Browse Repository
Passed
No Audits

d6ed9392d4e0 Replace Differential "lint stars" with icons
Author
epriestley
Revisions
D21640: Replace Differential "lint stars" with icons
Browse Repository
Passed
No Audits

Mar 5 2021

bfe7cdc5a2af Provide default image alt text in more contexts and support custom alt text
Author
epriestley
Revisions
D21596: Provide default image alt text in more contexts and support custom alt text
Browse Repository
Passed
No Audits

Feb 19 2021

e77ae13d5c71 Provide a more structured result log for Herald conditions
Author
epriestley
Revisions
D21563: Provide a more structured result log for Herald conditions
Browse Repository
Passed
No Audits

Feb 13 2021

2f33dedc8b62 When a reviewer can't see a revision, show it clearly in the reviewer list
Author
epriestley
Revisions
D21555: When a reviewer can't see a revision, show it clearly in the reviewer list
Browse Repository
Passed
No Audits

90903282c706 Render user hovercards with context information about their ability to see the…
Author
epriestley
Revisions
D21554: Render user hovercards with context information about their ability to see the context object
Browse Repository
Passed
No Audits

2aac3156f791 Restructure Hovercards to support more context information
Author
epriestley
Revisions
D21553: Restructure Hovercards to support more context information
Browse Repository
Passed
No Audits

a4cb2bb77247 When a subscriber can't see an object, clearly show that they're missing the…
Author
epriestley
Revisions
D21547: When a subscriber can't see an object, clearly show that they're missing the permission in the curtain UI
Browse Repository
Passed
No Audits

Oct 16 2020

2b8bbae5fb27 Set an explicit height when drawing the dependent revision graph
Author
epriestley
Revisions
D21481: Set an explicit height when drawing the dependent revision graph
Browse Repository
Passed
No Audits

Oct 2 2020

0f0e94ca71fe Use "getInlines()", not "_inlines", to access inlines on client Changeset…
Author
epriestley
Revisions
D21475: Use "getInlines()", not "_inlines", to access inlines on client Changeset objects
Browse Repository
Passed
No Audits

Sep 28 2020

a5f20f710669 When printing, wrap all content in Remarkup tables more aggressively
Author
epriestley
Revisions
D21472: When printing, wrap all content in Remarkup tables more aggressively
Browse Repository
Passed
No Audits

Sep 4 2020

0854425d191f When printing timestamps on paper: use an absolute, context-free date format
Author
epriestley
Revisions
D21451: When printing timestamps on paper: use an absolute, context-free date format
Browse Repository
Passed
No Audits

Aug 12 2020

429543b6376f Fix some content/background overflow issues with commit graph lists
Author
epriestley
Revisions
D21440: Fix some content/background overflow issues with commit graph lists
Browse Repository
Passed
No Audits

0b64092d25d0 Improve handle/status list display on devices in commit graph lists
Author
epriestley
Revisions
D21431: Improve handle/status list display on devices in commit graph lists
Browse Repository
Passed
No Audits

49af92e90325 Improve commit action item layout on mobile
Author
epriestley
Revisions
D21430: Improve commit action item layout on mobile
Browse Repository
Passed
No Audits

57f9450bcfc0 Improve desktop and mobile layouts for new "CommitGridView"
Author
epriestley
Revisions
D21418: Improve desktop and mobile layouts for new "CommitGridView"
Browse Repository
Passed
No Audits

8aec3f916b39 Unify more build, property, auditor, and status information into…
Author
epriestley
Revisions
D21417: Unify more build, property, auditor, and status information into "CommitGraphView"
Browse Repository
Passed
No Audits

36dac46ff263 Clean up some minor commit list CSS
Author
epriestley
Revisions
D21416: Clean up some minor commit list CSS
Browse Repository
Passed
No Audits

cd09ba5e19d7 Replace "DiffusionCommitListView" with "DiffusionCommitGraphView"
Author
epriestley
Revisions
D21412: Replace "DiffusionCommitListView" with "DiffusionCommitGraphView"
Browse Repository
Passed
No Audits

9fa25253844e Improve rendering of history graph in "CommitGraphView"
Author
epriestley
Revisions
D21411: Improve rendering of history graph in "CommitGraphView"
Browse Repository
Passed
No Audits

545417597322 Coerce Chrome into breaking monospaced text when printing tables to PDFs
Author
epriestley
Revisions
D21439: Coerce Chrome into breaking monospaced text when printing tables to PDFs
Browse Repository
Passed
No Audits

Jul 24 2020

017ef1927c3e Revert use of "user-select: all" to modify tab selection behavior
Author
epriestley
Revisions
D21429: Revert use of "user-select: all" to modify tab selection behavior
Browse Repository
Passed
No Audits

Jul 17 2020

37ffb71c4d5e In source views, wrap display tabs in "user-select: all" to improve cursor…
Author
epriestley
Revisions
D21419: In source views, wrap display tabs in "user-select: all" to improve cursor selection behavior
Browse Repository
Passed
No Audits

Jun 29 2020

a7b3ba5a6f4e When long monospaced character sequences appear in Remarkup tables, break…
Author
epriestley
Revisions
D21370: When long monospaced character sequences appear in Remarkup tables, break rather than scrolling
Browse Repository
Passed
No Audits

May 22 2020

3635a11f848f When cancelling an edit of an inline with content, don't hide the inline
Author
epriestley
Revisions
D21286: When cancelling an edit of an inline with content, don't hide the inline
Browse Repository
Passed
No Audits

May 21 2020

87fb35abb72e Prevent keyboard selection of change blocks inside edit suggestions
Author
epriestley
Revisions
D21283: Prevent keyboard selection of change blocks inside edit suggestions
Browse Repository
Passed
No Audits

66566f878d82 Make "Open in Editor" use the simple line number of the current selected block
Author
epriestley
Revisions
D21282: Make "Open in Editor" use the simple line number of the current selected block
Browse Repository
Passed
No Audits

May 20 2020

d2d7e7f5ff1b Clean up Diffusion behaviors for inline edit suggestions
Author
epriestley
Revisions
D21278: Clean up Diffusion behaviors for inline edit suggestions
Browse Repository
Passed
No Audits

10f241352dce Render inline comment suggestions as real diffs
Author
epriestley
Revisions
D21277: Render inline comment suggestions as real diffs
Browse Repository
Passed
No Audits

846562158aae Roughly support inline comment suggestions
Author
epriestley
Revisions
D21276: Roughly support inline comment suggestions
Browse Repository
Passed
No Audits

00430fdbe117 Make server components of inline comment content handling state-oriented
Author
epriestley
Revisions
D21275: Make server components of inline comment content handling state-oriented
Browse Repository
Passed
No Audits

87bc30526b7a Make inline content "state-oriented", not "string-oriented"
Author
epriestley
Revisions
D21273: Make inline content "state-oriented", not "string-oriented"
Browse Repository
Passed
No Audits

May 19 2020

770a5c8412d1 Fix "r" and "R" both replying with quote on inline comments
Author
epriestley
Revisions
D21268: Fix "r" and "R" both replying with quote on inline comments
Browse Repository
Passed
No Audits

May 15 2020

93b08f0e83e6 Fix an out-of-order access issue with inlines
Author
epriestley
Revisions
D21263: Fix an out-of-order access issue with inlines
Browse Repository
Passed
No Audits

e959f934893c Use a more consistent inline highlighting style with fewer redraws
Author
epriestley
Revisions
D21262: Use a more consistent inline highlighting style with fewer redraws
Browse Repository
Passed
No Audits

c666cb9f0bc7 Reduce the frequency of DOM scans to rebuild inlines when scrolling revisions
Author
epriestley
Revisions
D21261: Reduce the frequency of DOM scans to rebuild inlines when scrolling revisions
Browse Repository
Passed
No Audits

May 14 2020

3ee6b5393c77 Improve offset/range inline behavior for rich diffs and unified diffs
Author
epriestley
Revisions
D21257: Improve offset/range inline behavior for rich diffs and unified diffs
Browse Repository
Passed
No Audits

fbd57ad83232 Give selected inline comments are more obvious selected state
Author
epriestley
Revisions
D21256: Give selected inline comments are more obvious selected state
Browse Repository
Passed
No Audits

b021da71a52d When users click headers to select diff UI elements, don't eat the events
Author
epriestley
Revisions
D21255: When users click headers to select diff UI elements, don't eat the events
Browse Repository
Passed
No Audits

42f1a95a1255 Fix a flash of document selection when "oncopy" and "inline on range" behaviors…
Author
epriestley
Revisions
D21254: Fix a flash of document selection when "oncopy" and "inline on range" behaviors interact
Browse Repository
Passed
No Audits

f45519c0604b When cancelling an inline comment edit, exit the edit state after the response…
Author
epriestley
Revisions
D21253: When cancelling an inline comment edit, exit the edit state after the response arrives
Browse Repository
Passed
No Audits

cfb5de6fa77f Distinguish more carefully between "null" inline offsets and "0" inline offsets
Author
epriestley
Revisions
D21252: Distinguish more carefully between "null" inline offsets and "0" inline offsets
Browse Repository
Passed
No Audits

2f5398796e02 Store inline comment offset information and show it when highlighting comments
Author
epriestley
Revisions
D21250: Store inline comment offset information and show it when highlighting comments
Browse Repository
Passed
No Audits

ebef22ccc1bb Improve select-to-comment behavior in Firefox and on unified diffs
Author
epriestley
Revisions
D21249: Improve select-to-comment behavior in Firefox and on unified diffs
Browse Repository
Passed
No Audits

42378ea393fe Allow users to create inline comments by directly selecting text directly
Author
epriestley
Revisions
D21248: Allow users to create inline comments by directly selecting text directly
Browse Repository
Passed
No Audits

c063e0e5ec9d Add "View Raw Remarkup" to inline comments
Author
epriestley
Revisions
D21246: Add "View Raw Remarkup" to inline comments
Browse Repository
Passed
No Audits

419b7ceebb0f Move inline comment actions into a dropdown menu
Author
epriestley
Revisions
D21244: Move inline comment actions into a dropdown menu
Browse Repository
Passed
No Audits

May 13 2020

1da54837ea8a Improve line breaking behavior in Firefox and Chrome under complex conditions
Author
epriestley
Revisions
D21247: Improve line breaking behavior in Firefox and Chrome under complex conditions
Browse Repository
Passed
No Audits

May 12 2020

acc1fa165519 Make "View as Document Type..." only show valid options
Author
epriestley
Revisions
D21241: Make "View as Document Type..." only show valid options
Browse Repository
Passed
No Audits

0cca40db3bc6 When creating an inline, save the current document engine
Author
epriestley
Revisions
D21240: When creating an inline, save the current document engine
Browse Repository
Passed
No Audits

May 8 2020

e7ebd5d9d1f8 Make "Delete" from inline comment previews function correctly while editing…
Author
epriestley
Revisions
D21238: Make "Delete" from inline comment previews function correctly while editing comments
Browse Repository
Passed
No Audits

b804e8cffad2 Make "View" from inline comment previews correctly jump to "isEditing" inlines
Author
epriestley
Revisions
D21237: Make "View" from inline comment previews correctly jump to "isEditing" inlines
Browse Repository
Passed
No Audits

24ba66f106f2 Persist "Show Changeset" and improve path text selection
Author
epriestley
Revisions
D21236: Persist "Show Changeset" and improve path text selection
Browse Repository
Passed
No Audits

May 7 2020

1656a2ff081a Allow inline comment storage objects to generate their own runtime objects
Author
epriestley
Revisions
D21226: Allow inline comment storage objects to generate their own runtime objects
Browse Repository
Passed
No Audits

May 4 2020

6b69102990a3 Fix a JS issue when the anchor element on a page has no container
Author
epriestley
Revisions
D21222: Fix a JS issue when the anchor element on a page has no container
Browse Repository
Passed
No Audits

07e160bde1e8 When cancelling an unsaved editing inline after a reload, don't cancel into an…
Author
epriestley
Revisions
D21219: When cancelling an unsaved editing inline after a reload, don't cancel into an empty state
Browse Repository
Passed
No Audits

3a76248071eb When loading a page with inlines, don't select/focus inlines which we…
Author
epriestley
Revisions
D21217: When loading a page with inlines, don't select/focus inlines which we immediately upgrade to "editing"
Browse Repository
Passed
No Audits

fe501bd7f736 Save drafts for inline comments currently being edited
Author
epriestley
Revisions
D21216: Save drafts for inline comments currently being edited
Browse Repository
Passed
No Audits

63bfad0ff476 Refine unusual inline comment client interactions
Author
epriestley
Revisions
D21212: Refine unusual inline comment client interactions
Browse Repository
Passed
No Audits

67da18e37478 When users submit "editing" inlines, warn them that their inlines will be saved
Author
epriestley
Revisions
D21191: When users submit "editing" inlines, warn them that their inlines will be saved
Browse Repository
Passed
No Audits

b2ce0844b6ff When a user clicks "Cancel" on an inline comment to leave the "Editing" state…
Author
epriestley
Revisions
D21187: When a user clicks "Cancel" on an inline comment to leave the "Editing" state, save the state change
Browse Repository
Passed
No Audits

b48a22bf50a3 Make "editing" state persistent for inline comments
Author
epriestley
Revisions
D21186: Make "editing" state persistent for inline comments
Browse Repository
Passed
No Audits

54ec566281b1 Restore highlighting when jumping to transactions using URI anchors
Author
epriestley
Revisions
D21213: Restore highlighting when jumping to transactions using URI anchors
Browse Repository
Passed
No Audits

May 1 2020

120507068700 Use underlines instead of background color to show file moves/renames
Author
epriestley
Revisions
D21205: Use underlines instead of background color to show file moves/renames
Browse Repository
Passed
No Audits

Apr 28 2020

f21f1d8ab9e9 Update the diff table of contents to use hierarchical views and edit distance…
Author
epriestley
Revisions
D21183: Update the diff table of contents to use hierarchical views and edit distance renames
Browse Repository
Passed
No Audits

Apr 24 2020

5a460e4ea57d Stick the page footer in the right place on Formation View pages
Author
epriestley
Revisions
D21166: Stick the page footer in the right place on Formation View pages
Browse Repository
Passed
No Audits

Apr 23 2020

e20feeeee952 Update static resource package definitions
Author
epriestley
Revisions
D21163: Update static resource package definitions
Browse Repository
Passed
No Audits

4793bfcb7c49 Don't show the "file tree" view on tablets/phones
Author
epriestley
Revisions
D21162: Don't show the "file tree" view on tablets/phones
Browse Repository
Passed
No Audits

d2572f8b335a Refine more Differential review state behaviors
Author
epriestley
Revisions
D21161: Refine more Differential review state behaviors
Browse Repository
Passed
No Audits

0ede616f314b Update the "View Options" menu for recent filetree changes
Author
epriestley
Revisions
D21160: Update the "View Options" menu for recent filetree changes
Browse Repository
Passed
No Audits

Apr 22 2020

60de1506fe3b Make "hidden" changesets sticky, and show hidden state in the filetree
Author
epriestley
Revisions
D21158: Make "hidden" changesets sticky, and show hidden state in the filetree
Browse Repository
Passed
No Audits

a72a66caa833 Mark "low importance" and "owned" changes in the filetree
Author
epriestley
Revisions
D21157: Mark "low importance" and "owned" changes in the filetree
Browse Repository
Passed
No Audits

ff88eb588eb4 Show change information in file icons in the filetree
Author
epriestley
Revisions
D21156: Show change information in file icons in the filetree
Browse Repository
Passed
No Audits

9550ae69849c When a directory has a single directory child, collapse them into a single…
Author
epriestley
Revisions
D21155: When a directory has a single directory child, collapse them into a single "a/b/" path entry
Browse Repository
Passed
No Audits

12eddb18fb78 Entirely replace the old filetree UI with the "flank" UI
Author
epriestley
Revisions
D21154: Entirely replace the old filetree UI with the "flank" UI
Browse Repository
Passed
No Audits

ba8071bbef50 Roughly style the new "flank" paths UI
Author
epriestley
Revisions
D21153: Roughly style the new "flank" paths UI
Browse Repository
Passed
No Audits

8cd1f9a30976 Generate file trees from changesets in the new flank UI
Author
epriestley
Revisions
D21152: Generate file trees from changesets in the new flank UI
Browse Repository
Passed
No Audits

646280972b88 Glue the new FormationView on top of the older Filetree view in Differential
Author
epriestley
Revisions
D21151: Glue the new FormationView on top of the older Filetree view in Differential
Browse Repository
Passed
No Audits

fef2cdabfe43 Add a "FormationView" to support dynamic flank panels
Author
epriestley
Revisions
D21150: Add a "FormationView" to support dynamic flank panels
Browse Repository
Passed
No Audits

Apr 19 2020

ef69c7969f58 Restore editor behavior to Diffusion and support "\" shortcut
Author
epriestley
Revisions
D21149: Restore editor behavior to Diffusion and support "\" shortcut
Browse Repository
Passed
No Audits

537ff68edda2 In Differential, make the "Open in Editor" keystroke work with no selection, or…
Author
epriestley
Revisions
D21148: In Differential, make the "Open in Editor" keystroke work with no selection, or a change or inline selected
Browse Repository
Passed
No Audits

8bdc7133521d Make the "Keyboard Shortcuts" dialog in Differential less hideous
Author
epriestley
Revisions
D21141: Make the "Keyboard Shortcuts" dialog in Differential less hideous
Browse Repository
Passed
No Audits

c3c55d82ae9d Make "renderer", "engine", and "encoding" sticky across reloads in Differential…
Author
epriestley
Revisions
D21138: Make "renderer", "engine", and "encoding" sticky across reloads in Differential and Diffusion
Browse Repository
Passed
No Audits

Apr 17 2020

3d966d8a41f1 Add an "Open in External Editor" keystroke to Differential
Author
epriestley
Revisions
D21135: Add an "Open in External Editor" keystroke to Differential
Browse Repository
Passed
No Audits

925d2b051ceb Fix a "flickering" behavior with the menu bar transition animations in Chrome
Author
epriestley
Revisions
D21133: Fix a "flickering" behavior with the menu bar transition animations in Chrome
Browse Repository
Passed
No Audits

Feb 24 2020

785f3c98da3a Extract raw commit messages from Git more faithfully across Git versions
Author
epriestley
Revisions
D21027: Extract raw commit messages from Git more faithfully across Git versions
Browse Repository
Passed
No Audits

Feb 4 2020

0e82bd024a8c Use the new "CurtainObjectRefList" UI element for subscribers
Author
epriestley
Revisions
D20967: Use the new "CurtainObjectRefList" UI element for subscribers
Browse Repository
Passed
No Audits

2a92fef8798d Improve wrapping and overflow behavior for curtain panels containing long…
Author
epriestley
Revisions
D20966: Improve wrapping and overflow behavior for curtain panels containing long usernames
Browse Repository
Passed
No Audits

6d4c6924d6d9 Update Herald rule creation workflow to use more modern UI elements
Author
epriestley
Revisions
D20956: Update Herald rule creation workflow to use more modern UI elements
Browse Repository
Passed
No Audits

26c2a1ba68b1 Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView"
Author
epriestley
Revisions
D20933: Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView"
Browse Repository
Passed
No Audits