Diffusion Phabricator (master) History

phabricator/webroot/rsrc/js/application
master

Mar 29 2021

1308a5555fee Update client logic for inline comment "Save" and "Cancel" actions
Author
epriestley
Revisions
D21654: Update client logic for inline comment "Save" and "Cancel" actions
Browse Repository
Passed
No Audits

6fd55d692f14 Formally track "initial", "committed", and "active" states for inline comments
Author
epriestley
Revisions
D21653: Formally track "initial", "committed", and "active" states for inline comments
Browse Repository
Passed
No Audits

b75517918d86 When creating an inline comment, populate the content state with the default…
Author
epriestley
Revisions
D21652: When creating an inline comment, populate the content state with the default suggestion text
Browse Repository
Passed
No Audits

5efe7fb4c181 On inline comments, track an explicit "committed" content state
Author
epriestley
Revisions
D21651: On inline comments, track an explicit "committed" content state
Browse Repository
Passed
No Audits

d30c3a961cd9 Make the client authoritative for "Cancel" actions
Author
epriestley
Revisions
D21649: Make the client authoritative for "Cancel" actions
Browse Repository
Passed
No Audits

60e869f4114f Make the client authoritative for "Save" actions
Author
epriestley
Revisions
D21648: Make the client authoritative for "Save" actions
Browse Repository
Passed
No Audits

0f04d9e58458 Remove direct reads of form state from main Inline client code
Author
epriestley
Revisions
D21647: Remove direct reads of form state from main Inline client code
Browse Repository
Passed
No Audits

cb00cb99e244 Make client inlines track an "active" state
Author
epriestley
Revisions
D21646: Make client inlines track an "active" state
Browse Repository
Passed
No Audits

b964731b6a6b Make inline "ContentState" a client object, and track "hasSuggestion" on it
Author
epriestley
Revisions
D21645: Make inline "ContentState" a client object, and track "hasSuggestion" on it
Browse Repository
Passed
No Audits

87c6c270b435 Fix an issue where inlines could be duplicated in the client list
Author
epriestley
Revisions
D21642: Fix an issue where inlines could be duplicated in the client list
Browse Repository
Passed
No Audits

Mar 17 2021

db9191f9a8d5 Correct minor "jump to symbol" behavior in Differential
Author
epriestley
Revisions
D21641: Correct minor "jump to symbol" behavior in Differential
Browse Repository
Passed
No Audits

Oct 16 2020

2b8bbae5fb27 Set an explicit height when drawing the dependent revision graph
Author
epriestley
Revisions
D21481: Set an explicit height when drawing the dependent revision graph
Browse Repository
Passed
No Audits

Oct 2 2020

0f0e94ca71fe Use "getInlines()", not "_inlines", to access inlines on client Changeset…
Author
epriestley
Revisions
D21475: Use "getInlines()", not "_inlines", to access inlines on client Changeset objects
Browse Repository
Passed
No Audits

Aug 12 2020

9fa25253844e Improve rendering of history graph in "CommitGraphView"
Author
epriestley
Revisions
D21411: Improve rendering of history graph in "CommitGraphView"
Browse Repository
Passed
No Audits

May 22 2020

3635a11f848f When cancelling an edit of an inline with content, don't hide the inline
Author
epriestley
Revisions
D21286: When cancelling an edit of an inline with content, don't hide the inline
Browse Repository
Passed
No Audits

May 21 2020

87fb35abb72e Prevent keyboard selection of change blocks inside edit suggestions
Author
epriestley
Revisions
D21283: Prevent keyboard selection of change blocks inside edit suggestions
Browse Repository
Passed
No Audits

66566f878d82 Make "Open in Editor" use the simple line number of the current selected block
Author
epriestley
Revisions
D21282: Make "Open in Editor" use the simple line number of the current selected block
Browse Repository
Passed
No Audits

May 20 2020

d2d7e7f5ff1b Clean up Diffusion behaviors for inline edit suggestions
Author
epriestley
Revisions
D21278: Clean up Diffusion behaviors for inline edit suggestions
Browse Repository
Passed
No Audits

846562158aae Roughly support inline comment suggestions
Author
epriestley
Revisions
D21276: Roughly support inline comment suggestions
Browse Repository
Passed
No Audits

00430fdbe117 Make server components of inline comment content handling state-oriented
Author
epriestley
Revisions
D21275: Make server components of inline comment content handling state-oriented
Browse Repository
Passed
No Audits

87bc30526b7a Make inline content "state-oriented", not "string-oriented"
Author
epriestley
Revisions
D21273: Make inline content "state-oriented", not "string-oriented"
Browse Repository
Passed
No Audits

May 19 2020

770a5c8412d1 Fix "r" and "R" both replying with quote on inline comments
Author
epriestley
Revisions
D21268: Fix "r" and "R" both replying with quote on inline comments
Browse Repository
Passed
No Audits

May 15 2020

93b08f0e83e6 Fix an out-of-order access issue with inlines
Author
epriestley
Revisions
D21263: Fix an out-of-order access issue with inlines
Browse Repository
Passed
No Audits

e959f934893c Use a more consistent inline highlighting style with fewer redraws
Author
epriestley
Revisions
D21262: Use a more consistent inline highlighting style with fewer redraws
Browse Repository
Passed
No Audits

c666cb9f0bc7 Reduce the frequency of DOM scans to rebuild inlines when scrolling revisions
Author
epriestley
Revisions
D21261: Reduce the frequency of DOM scans to rebuild inlines when scrolling revisions
Browse Repository
Passed
No Audits

May 14 2020

3ee6b5393c77 Improve offset/range inline behavior for rich diffs and unified diffs
Author
epriestley
Revisions
D21257: Improve offset/range inline behavior for rich diffs and unified diffs
Browse Repository
Passed
No Audits

fbd57ad83232 Give selected inline comments are more obvious selected state
Author
epriestley
Revisions
D21256: Give selected inline comments are more obvious selected state
Browse Repository
Passed
No Audits

b021da71a52d When users click headers to select diff UI elements, don't eat the events
Author
epriestley
Revisions
D21255: When users click headers to select diff UI elements, don't eat the events
Browse Repository
Passed
No Audits

f45519c0604b When cancelling an inline comment edit, exit the edit state after the response…
Author
epriestley
Revisions
D21253: When cancelling an inline comment edit, exit the edit state after the response arrives
Browse Repository
Passed
No Audits

cfb5de6fa77f Distinguish more carefully between "null" inline offsets and "0" inline offsets
Author
epriestley
Revisions
D21252: Distinguish more carefully between "null" inline offsets and "0" inline offsets
Browse Repository
Passed
No Audits

2f5398796e02 Store inline comment offset information and show it when highlighting comments
Author
epriestley
Revisions
D21250: Store inline comment offset information and show it when highlighting comments
Browse Repository
Passed
No Audits

ebef22ccc1bb Improve select-to-comment behavior in Firefox and on unified diffs
Author
epriestley
Revisions
D21249: Improve select-to-comment behavior in Firefox and on unified diffs
Browse Repository
Passed
No Audits

42378ea393fe Allow users to create inline comments by directly selecting text directly
Author
epriestley
Revisions
D21248: Allow users to create inline comments by directly selecting text directly
Browse Repository
Passed
No Audits

c063e0e5ec9d Add "View Raw Remarkup" to inline comments
Author
epriestley
Revisions
D21246: Add "View Raw Remarkup" to inline comments
Browse Repository
Passed
No Audits

419b7ceebb0f Move inline comment actions into a dropdown menu
Author
epriestley
Revisions
D21244: Move inline comment actions into a dropdown menu
Browse Repository
Passed
No Audits

May 12 2020

acc1fa165519 Make "View as Document Type..." only show valid options
Author
epriestley
Revisions
D21241: Make "View as Document Type..." only show valid options
Browse Repository
Passed
No Audits

0cca40db3bc6 When creating an inline, save the current document engine
Author
epriestley
Revisions
D21240: When creating an inline, save the current document engine
Browse Repository
Passed
No Audits

May 8 2020

e7ebd5d9d1f8 Make "Delete" from inline comment previews function correctly while editing…
Author
epriestley
Revisions
D21238: Make "Delete" from inline comment previews function correctly while editing comments
Browse Repository
Passed
No Audits

b804e8cffad2 Make "View" from inline comment previews correctly jump to "isEditing" inlines
Author
epriestley
Revisions
D21237: Make "View" from inline comment previews correctly jump to "isEditing" inlines
Browse Repository
Passed
No Audits

24ba66f106f2 Persist "Show Changeset" and improve path text selection
Author
epriestley
Revisions
D21236: Persist "Show Changeset" and improve path text selection
Browse Repository
Passed
No Audits

May 7 2020

1656a2ff081a Allow inline comment storage objects to generate their own runtime objects
Author
epriestley
Revisions
D21226: Allow inline comment storage objects to generate their own runtime objects
Browse Repository
Passed
No Audits

May 4 2020

07e160bde1e8 When cancelling an unsaved editing inline after a reload, don't cancel into an…
Author
epriestley
Revisions
D21219: When cancelling an unsaved editing inline after a reload, don't cancel into an empty state
Browse Repository
Passed
No Audits

3a76248071eb When loading a page with inlines, don't select/focus inlines which we…
Author
epriestley
Revisions
D21217: When loading a page with inlines, don't select/focus inlines which we immediately upgrade to "editing"
Browse Repository
Passed
No Audits

fe501bd7f736 Save drafts for inline comments currently being edited
Author
epriestley
Revisions
D21216: Save drafts for inline comments currently being edited
Browse Repository
Passed
No Audits

63bfad0ff476 Refine unusual inline comment client interactions
Author
epriestley
Revisions
D21212: Refine unusual inline comment client interactions
Browse Repository
Passed
No Audits

b2ce0844b6ff When a user clicks "Cancel" on an inline comment to leave the "Editing" state…
Author
epriestley
Revisions
D21187: When a user clicks "Cancel" on an inline comment to leave the "Editing" state, save the state change
Browse Repository
Passed
No Audits

b48a22bf50a3 Make "editing" state persistent for inline comments
Author
epriestley
Revisions
D21186: Make "editing" state persistent for inline comments
Browse Repository
Passed
No Audits

Apr 23 2020

d2572f8b335a Refine more Differential review state behaviors
Author
epriestley
Revisions
D21161: Refine more Differential review state behaviors
Browse Repository
Passed
No Audits

0ede616f314b Update the "View Options" menu for recent filetree changes
Author
epriestley
Revisions
D21160: Update the "View Options" menu for recent filetree changes
Browse Repository
Passed
No Audits

Apr 22 2020

60de1506fe3b Make "hidden" changesets sticky, and show hidden state in the filetree
Author
epriestley
Revisions
D21158: Make "hidden" changesets sticky, and show hidden state in the filetree
Browse Repository
Passed
No Audits

a72a66caa833 Mark "low importance" and "owned" changes in the filetree
Author
epriestley
Revisions
D21157: Mark "low importance" and "owned" changes in the filetree
Browse Repository
Passed
No Audits

ff88eb588eb4 Show change information in file icons in the filetree
Author
epriestley
Revisions
D21156: Show change information in file icons in the filetree
Browse Repository
Passed
No Audits

9550ae69849c When a directory has a single directory child, collapse them into a single…
Author
epriestley
Revisions
D21155: When a directory has a single directory child, collapse them into a single "a/b/" path entry
Browse Repository
Passed
No Audits

12eddb18fb78 Entirely replace the old filetree UI with the "flank" UI
Author
epriestley
Revisions
D21154: Entirely replace the old filetree UI with the "flank" UI
Browse Repository
Passed
No Audits

ba8071bbef50 Roughly style the new "flank" paths UI
Author
epriestley
Revisions
D21153: Roughly style the new "flank" paths UI
Browse Repository
Passed
No Audits

8cd1f9a30976 Generate file trees from changesets in the new flank UI
Author
epriestley
Revisions
D21152: Generate file trees from changesets in the new flank UI
Browse Repository
Passed
No Audits

646280972b88 Glue the new FormationView on top of the older Filetree view in Differential
Author
epriestley
Revisions
D21151: Glue the new FormationView on top of the older Filetree view in Differential
Browse Repository
Passed
No Audits

Apr 19 2020

537ff68edda2 In Differential, make the "Open in Editor" keystroke work with no selection, or…
Author
epriestley
Revisions
D21148: In Differential, make the "Open in Editor" keystroke work with no selection, or a change or inline selected
Browse Repository
Passed
No Audits

8bdc7133521d Make the "Keyboard Shortcuts" dialog in Differential less hideous
Author
epriestley
Revisions
D21141: Make the "Keyboard Shortcuts" dialog in Differential less hideous
Browse Repository
Passed
No Audits

c3c55d82ae9d Make "renderer", "engine", and "encoding" sticky across reloads in Differential…
Author
epriestley
Revisions
D21138: Make "renderer", "engine", and "encoding" sticky across reloads in Differential and Diffusion
Browse Repository
Passed
No Audits

Apr 17 2020

3d966d8a41f1 Add an "Open in External Editor" keystroke to Differential
Author
epriestley
Revisions
D21135: Add an "Open in External Editor" keystroke to Differential
Browse Repository
Passed
No Audits

Oct 29 2019

e1da1d86d680 Trim and URI encode symbol names before building URIs from them
Author
epriestley
Revisions
D20876: Trim and URI encode symbol names before building URIs from them
Browse Repository
Passed
No Audits

Sep 26 2019

2c06815edb0f When rendering Jupyter notebook diffs, split code inputs into individual blocks
Author
epriestley
Revisions
D20840: When rendering Jupyter notebook diffs, split code inputs into individual blocks
Browse Repository
Passed
No Audits

Sep 25 2019

932d829af339 Improve behavior of inline comment highlight reticle for block diffs
Author
epriestley
Revisions
D20835: Improve behavior of inline comment highlight reticle for block diffs
Browse Repository
Passed
No Audits

7ae711ed3e0b Add a "View as..." option to diff dropdowns for selecting between document…
Author
epriestley
Revisions
D20832: Add a "View as..." option to diff dropdowns for selecting between document engines
Browse Repository
Passed
No Audits

Sep 17 2019

d4ed5d0428ec Make various UX improvements to charts so they're closer to making visual sense
Author
epriestley
Revisions
D20817: Make various UX improvements to charts so they're closer to making visual sense
Browse Repository
Passed
No Audits

f529abf90065 In stacked area charts, group nearby points so they don't overlap
Author
epriestley
Revisions
D20814: In stacked area charts, group nearby points so they don't overlap
Browse Repository
Passed
No Audits

Sep 12 2019

d60d4e6a0521 Don't present users with Herald fields/actions for uninstalled applications…
Author
epriestley
Revisions
D20808: Don't present users with Herald fields/actions for uninstalled applications, unless the rule already uses them
Browse Repository
Passed
No Audits

Jul 30 2019

7d41535010aa When a task card is edited, emit update events for old boards and parent boards
Author
epriestley
Revisions
D20680: When a task card is edited, emit update events for old boards and parent boards
Browse Repository
Passed
No Audits

Jul 18 2019

17caecdda35d Make workboard real-time updates mostly work
Author
epriestley
Revisions
D20656: Make workboard real-time updates mostly work
Browse Repository
Passed
No Audits

Jul 17 2019

d02beaf8161a Make reloading workboards with "R" respect workboard ordering
Author
epriestley
Revisions
D20654: Make reloading workboards with "R" respect workboard ordering
Browse Repository
Passed
No Audits

8669c3c0d226 When updating a workboard with "R", send the client visible set with version…
Author
epriestley
Revisions
D20653: When updating a workboard with "R", send the client visible set with version numbers
Browse Repository
Passed
No Audits

1ee6ecf39768 Move "BoardResponseEngine" toward a more comprehensive update model
Author
epriestley
Revisions
D20652: Move "BoardResponseEngine" toward a more comprehensive update model
Browse Repository
Passed
No Audits

db69686927bd Make pressing "R" on your keyboard reload the card state on workboards
Author
epriestley
Revisions
D20639: Make pressing "R" on your keyboard reload the card state on workboards
Browse Repository
Passed
No Audits

Jul 3 2019

fc795994f30f Remove obsolete "options" from workboard "updateCard()" call
Author
epriestley
Revisions
D20638: Remove obsolete "options" from workboard "updateCard()" call
Browse Repository
Passed
No Audits

May 22 2019

a80426b339c4 Provide chart function labels over the wire instead of making them up
Author
epriestley
Revisions
D20501: Provide chart function labels over the wire instead of making them up
Browse Repository
Passed
No Audits

c6052b41a604 Label important data on charts
Author
epriestley
Revisions
D20500: Label important data on charts
Browse Repository
Passed
No Audits

81456db5594e Roughly support stacked area charts
Author
epriestley
Revisions
D20498: Roughly support stacked area charts
Browse Repository
Passed
No Audits

146317f2c447 Remove the legacy chart behavior from Maniphest
Author
epriestley
Revisions
D20487: Remove the legacy chart behavior from Maniphest
Browse Repository
Passed
No Audits

Apr 19 2019

e1076528ef76 Copy the "line-chart" behavior to "line-chart-legacy" to keep "Maniphest >…
Author
epriestley
Revisions
D20449: Copy the "line-chart" behavior to "line-chart-legacy" to keep "Maniphest > Reports" working
Browse Repository
Passed
No Audits

Apr 18 2019

45b3c23148d0 Fetch chart data via async request and redraw charts when the window is resized
Author
epriestley
Revisions
D20440: Fetch chart data via async request and redraw charts when the window is resized
Browse Repository
Passed
No Audits

044c6fbc19d4 Support drawing multiple functions on the same chart
Author
epriestley
Revisions
D20439: Support drawing multiple functions on the same chart
Browse Repository
Passed
No Audits

02981f0add6d Fix negative chart values, add storage for charts
Author
epriestley
Revisions
D20438: Fix negative chart values, add storage for charts
Browse Repository
Passed
No Audits

Apr 17 2019

9532bfbb32c8 Improve trigger editor behavior when switching to/from tokenizers
Author
epriestley
Revisions
D20416: Improve trigger editor behavior when switching to/from tokenizers
Browse Repository
Passed
No Audits

b8551bb5f98c Reduce drag-and-drop jank on dashboards
Author
epriestley
Revisions
D20415: Reduce drag-and-drop jank on dashboards
Browse Repository
Passed
No Audits

Apr 14 2019

fb994909cf9c Make "Move Panel" on dashboards use the new storage and transactions
Author
epriestley
Revisions
D20409: Make "Move Panel" on dashboards use the new storage and transactions
Browse Repository
Passed
No Audits

82c46f4b93bd Update "add panel" and "remove panel" Dashboard flows to the new panel storage…
Author
epriestley
Revisions
D20408: Update "add panel" and "remove panel" Dashboard flows to the new panel storage format
Browse Repository
Passed
No Audits

Apr 12 2019

cbe13b3065a1 When editing a tab panel from a dashboard, redirect back to the dashboard
Author
epriestley
Revisions
D20397: When editing a tab panel from a dashboard, redirect back to the dashboard
Browse Repository
Passed
No Audits

9ad9ac9be695 On Dashboard tab panels in edit mode, make the "Tab Name" and the "Dropdown…
Author
epriestley
Revisions
D20396: On Dashboard tab panels in edit mode, make the "Tab Name" and the "Dropdown Edit Caret" into different links
Browse Repository
Passed
No Audits

Mar 29 2019

cec779cdabee When drawing a very wide graph line diagram, smush it together a bit
Author
epriestley
Revisions
D20346: When drawing a very wide graph line diagram, smush it together a bit
Browse Repository
Passed
No Audits

Mar 26 2019

f6658bf391d3 When changing the trigger type in the trigger editor, properly redraw the…
Author
epriestley
Revisions
D20326: When changing the trigger type in the trigger editor, properly redraw the control
Browse Repository
Passed
No Audits

71c89bd0578d Pass all adjacent card PHIDs from the client to the server when moving a card
Author
epriestley
Revisions
D20322: Pass all adjacent card PHIDs from the client to the server when moving a card
Browse Repository
Passed
No Audits

6138e50962e6 When moving cards on workboards, treat before/after cards as optional hints…
Author
epriestley
Revisions
D20321: When moving cards on workboards, treat before/after cards as optional hints, not strict requirements
Browse Repository
Passed
No Audits

Mar 25 2019

686b03a1d59e Dim the action drop preview element when the cursor approaches
Author
epriestley
Revisions
D20320: Dim the action drop preview element when the cursor approaches
Browse Repository
Passed
No Audits

bfa5ffe8a1ea Add a "Play Sound" workboard trigger rule
Author
epriestley
Revisions
D20306: Add a "Play Sound" workboard trigger rule
Browse Repository
Passed
No Audits

66c1d623c340 If the user cancels a workboard drop flow, put things back where they were
Author
epriestley
Revisions
D20305: If the user cancels a workboard drop flow, put things back where they were
Browse Repository
Passed
No Audits

1277db945258 When users hover over a column trigger menu, show a "preview" with the rules…
Author
epriestley
Revisions
D20304: When users hover over a column trigger menu, show a "preview" with the rules instead of a tooltip
Browse Repository
Passed
No Audits

567dea54492b Mostly make the editor UI for triggers work
Author
epriestley
Revisions
D20301: Mostly make the editor UI for triggers work
Browse Repository
Passed
No Audits

a5b3e33e3c26 Don't show workboard action previews if the action won't have any effect
Author
epriestley
Revisions
D20300: Don't show workboard action previews if the action won't have any effect
Browse Repository
Passed
No Audits

5dca1569b577 Preview the effects of a drag-and-drop operation on workboards
Author
epriestley
Revisions
D20299: Preview the effects of a drag-and-drop operation on workboards
Browse Repository
Passed
No Audits