Diffusion Phabricator (master) History

phabricator/src/infrastructure/query/policy
master

Feb 3 2021

9502312b60ae Remove "final" from "private" methods in Phabricator
Author
epriestley
Revisions
D21540: Remove "final" from "private" methods in Phabricator
Browse Repository
Passed
No Audits

Oct 30 2020

671986592baf Add a missing "GROUP BY" to MailQuery when querying for multiple recipients
Author
epriestley
Revisions
D21486: Add a missing "GROUP BY" to MailQuery when querying for multiple recipients
Browse Repository
Passed
No Audits

Apr 16 2020

2748f83e1225 Modularize Ferret fulltext functions
Author
epriestley
Revisions
D21131: Modularize Ferret fulltext functions
Browse Repository
Passed
No Audits

9bdf477f2fef Combine the two different ngram-splitting algorithms into a single engine
Author
epriestley
Revisions
D21128: Combine the two different ngram-splitting algorithms into a single engine
Browse Repository
Passed
No Audits

fb3f423279b2 Remove broken and unfixable "prefix" ngram behavior
Author
epriestley
Revisions
D21127: Remove broken and unfixable "prefix" ngram behavior
Browse Repository
Passed
No Audits

Apr 14 2020

0511b2a0129e Implement the "present" and "absent" operators in the Ferret execution engine
Author
epriestley
Revisions
D21110: Implement the "present" and "absent" operators in the Ferret execution engine
Browse Repository
Passed
No Audits

8fa8d0e6483c Make Ferret query functions sticky only if their values are not quoted
Author
epriestley
Revisions
D21108: Make Ferret query functions sticky only if their values are not quoted
Browse Repository
Passed
No Audits

Feb 23 2020

0872051bfa28 Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all…
Author
epriestley
Revisions
D21015: Make AuthProvider, ExternalAccount, and ExternalAccountIdentifier all Destructible
Browse Repository
Passed
No Audits

Aug 22 2019

f1b054a20fd5 Correct the interaction between overheating and offset-based paging
Author
epriestley
Revisions
D20728: Correct the interaction between overheating and offset-based paging
Browse Repository
Passed
No Audits

Jul 18 2019

cb4add311649 In Ferret, allow documents with no title to match query terms by using LEFT…
Author
epriestley
Revisions
D20660: In Ferret, allow documents with no title to match query terms by using LEFT JOIN on the "title" ranking field
Browse Repository
Passed
No Audits

May 21 2019

642113708a83 Build a rough transaction-level view of Feed
Author
epriestley
Revisions
D20531: Build a rough transaction-level view of Feed
Browse Repository
Passed
No Audits

Apr 1 2019

00b1c4190c41 Correct some straggling Ferret/Cursor interactions
Author
epriestley
Revisions
D20354: Correct some straggling Ferret/Cursor interactions
Browse Repository
Passed
No Audits

Mar 25 2019

7f90570636af When paging by Ferret "rank", page using "HAVING rank > ...", not "WHERE rank >…
Author
epriestley
Revisions
D20298: When paging by Ferret "rank", page using "HAVING rank > ...", not "WHERE rank > ..."
Browse Repository
Passed
No Audits

Mar 19 2019

b90e02bec287 Select Ferret fulltext columns in results so fulltext queries work under UNION
Author
epriestley
Revisions
D20297: Select Ferret fulltext columns in results so fulltext queries work under UNION
Browse Repository
Passed
No Audits

a8ba8217d84f Skip Ferret fulltext columns in "ORDER BY" if there's no fulltext query
Author
epriestley
Revisions
D20296: Skip Ferret fulltext columns in "ORDER BY" if there's no fulltext query
Browse Repository
Passed
No Audits

3940c8e1f43a Make the UI when you use an invalid cursor ("?after=19874189471232892") a…
Author
epriestley
Revisions
D20295: Make the UI when you use an invalid cursor ("?after=19874189471232892") a little nicer
Browse Repository
Passed
No Audits

18b444e427b0 When queries overheat, raise an exception
Author
epriestley
Revisions
D20294: When queries overheat, raise an exception
Browse Repository
Passed
No Audits

8449c1793ace Convert complex query subclasses to use internal cursors
Author
epriestley
Revisions
D20293: Convert complex query subclasses to use internal cursors
Browse Repository
Passed
No Audits

d4847c3eeb78 Convert simple query subclasses to use internal cursors
Author
epriestley
Revisions
D20292: Convert simple query subclasses to use internal cursors
Browse Repository
Passed
No Audits

1b0ef4391032 Separate internal and external Query Cursors more cleanly, to fix pagination…
Author
epriestley
Revisions
D20291: Separate internal and external Query Cursors more cleanly, to fix pagination against broken objects
Browse Repository
Passed
No Audits

Mar 1 2019

27ea775fda5f Fix a log warning when searching for ranges on custom "Date" fields
Author
epriestley
Revisions
D20225: Fix a log warning when searching for ranges on custom "Date" fields
Browse Repository
Passed
No Audits

Jan 28 2019

03ac59a87708 Don't put "spacePHID IN (...)" constraints in queries which will raise policy…
Author
epriestley
Revisions
D20042: Don't put "spacePHID IN (...)" constraints in queries which will raise policy exceptions
Browse Repository
Passed
No Audits

Nov 16 2018

933462b4873b Continue cleaning up queries in the wake of changes to "%Q"
Author
epriestley
Revisions
D19814: Continue cleaning up queries in the wake of changes to "%Q"
Browse Repository
Passed
No Audits

Nov 15 2018

86fd2041484f Fix all query warnings in "arc unit --everything"
Author
epriestley
Revisions
D19801: Fix all query warnings in "arc unit --everything"
Browse Repository
Passed
No Audits

2f10d4adebf9 Continue making application fixes to Phabricator for changes to %Q semantics
Author
epriestley
Revisions
D19790: Continue making application fixes to Phabricator for changes to %Q semantics
Browse Repository
Passed
No Audits

98690ee326ce Update many Phabricator queries for new %Q query semantics
Author
epriestley
Revisions
D19789: Update many Phabricator queries for new %Q query semantics
Browse Repository
Passed
No Audits

Nov 14 2018

64b52b9952dd Make SELECT construction in PolicyAwareQuery safer
Author
epriestley
Revisions
D19785: Make SELECT construction in PolicyAwareQuery safer
Browse Repository
Passed
No Audits

Jul 23 2018

71d4fa41c93b Support the Ferret "=" (exact match) operator in the actual query engine
Author
epriestley
Revisions
D19529: Support the Ferret "=" (exact match) operator in the actual query engine
Browse Repository
Passed
No Audits

Feb 22 2018

d0591f3680b2 Support some QueryConstraint operations against generic ApplicationSearch query…
Author
epriestley
Revisions
D19126: Support some QueryConstraint operations against generic ApplicationSearch query logic
Browse Repository
Passed
No Audits

Oct 23 2017

1d213dc1fa4b Clean up virtual "_ft_rank" column for query construction of Ferret objects
Author
epriestley
Revisions
D18728: Clean up virtual "_ft_rank" column for query construction of Ferret objects
Browse Repository
Passed
No Audits

157f47cd149c Rewrite CommitQuery to use UNION for performance
Author
epriestley
Revisions
D18722: Rewrite CommitQuery to use UNION for performance
Browse Repository
Passed
No Audits

Oct 9 2017

9bd6a3705559 Fix spelling
Author
0
Revisions
D18693: Fix spelling
Browse Repository
Failed
No Audits

Oct 3 2017

1de130c9f5b2 Allow the Ferret engine to remove "common" ngrams from the index
Author
epriestley
Revisions
D18672: Allow the Ferret engine to remove "common" ngrams from the index
Browse Repository
Passed
No Audits

Sep 18 2017

94ab0c9afb91 Spell "Relevance" correctly
Author
epriestley
Revisions
D18622: Spell "Relevance" correctly
Browse Repository
Passed
No Audits

Sep 12 2017

fdc0d8c2f6f3 Fix an issue with selecting the right stemmed ngrams with Ferret engine queries
Author
epriestley
Revisions
D18593: Fix an issue with selecting the right stemmed ngrams with Ferret engine queries
Browse Repository
Passed
No Audits

39b74572e6f7 Return fulltext tokens from the Ferret fulltext engine
Author
epriestley
Revisions
D18589: Return fulltext tokens from the Ferret fulltext engine
Browse Repository
Passed
No Audits

Sep 8 2017

c662dda0f17d When selecting Ferret ngrams, select term ngrams (not raw ngrams) for term…
Author
epriestley
Revisions
D18581: When selecting Ferret ngrams, select term ngrams (not raw ngrams) for term search
Browse Repository
Passed
No Audits

Sep 7 2017

2218caee0f50 Reduce the amount of boilerplate that implementing FerretInterface requires
Author
epriestley
Revisions
D18559: Reduce the amount of boilerplate that implementing FerretInterface requires
Browse Repository
Passed
No Audits

a2a2b3f7f4b5 Sort global fulltext results by overall relevance
Author
epriestley
Revisions
D18551: Sort global fulltext results by overall relevance
Browse Repository
Passed
No Audits

8059db894d64 Use the Ferret engine fulltext document table to drive auxiliary fulltext…
Author
epriestley
Revisions
D18550: Use the Ferret engine fulltext document table to drive auxiliary fulltext constraints
Browse Repository
Passed
No Audits

Sep 6 2017

395a2ed6d127 Add an "only()" edge logic constraint, meaning "only the other constraints…
Author
epriestley
Revisions
D18543: Add an "only()" edge logic constraint, meaning "only the other constraints, exactly"
Browse Repository
Passed
No Audits

Sep 5 2017

64b7778f3257 Add support for relevance-ranking Ferret engine results
Author
epriestley
Revisions
D18539: Add support for relevance-ranking Ferret engine results
Browse Repository
Passed
No Audits

20aad35e6036 Move Ferret engine "title:..." field definitions to the engine itself
Author
epriestley
Revisions
D18536: Move Ferret engine "title:..." field definitions to the engine itself
Browse Repository
Passed
No Audits

46abc11114c3 Reduce the number of magic strings in the Ferret implementation
Author
epriestley
Revisions
D18534: Reduce the number of magic strings in the Ferret implementation
Browse Repository
Passed
No Audits

4a7593f47fc7 Consolidate more Ferret engine code into FerretEngine
Author
epriestley
Revisions
D18533: Consolidate more Ferret engine code into FerretEngine
Browse Repository
Passed
No Audits

Sep 1 2017

577d4980339f Create a virtual "core" field in the Ferret engine for "title and body together"
Author
epriestley
Revisions
D18514: Create a virtual "core" field in the Ferret engine for "title and body together"
Browse Repository
Passed
No Audits

Aug 30 2017

3b43a7077345 Add "title:..." support to the Ferret engine
Author
epriestley
Revisions
D18503: Add "title:..." support to the Ferret engine
Browse Repository
Passed
No Audits

048aa36c236d Support "-term" in Ferret engine queries
Author
epriestley
Revisions
D18502: Support "-term" in Ferret engine queries
Browse Repository
Passed
No Audits

df9c24e75058 Provide some "term vs substring" support for the Ferret engine
Author
epriestley
Revisions
D18500: Provide some "term vs substring" support for the Ferret engine
Browse Repository
Passed
No Audits

e5a495f43510 Parse raw Ferret queries into tokens before processing them
Author
epriestley
Revisions
D18499: Parse raw Ferret queries into tokens before processing them
Browse Repository
Passed
No Audits

Aug 28 2017

f97157e7edb1 Build a prototype fulltext engine ("Ferret") using only basic MySQL primitives
Author
epriestley
Revisions
D18484: Build a prototype fulltext engine ("Ferret") using only basic MySQL primitives
Browse Repository
Passed
No Audits

May 24 2017

709c304d76d1 Group query results under the "ANCESTOR" operator unconditionally
Author
epriestley
Revisions
D18012: Group query results under the "ANCESTOR" operator unconditionally
Browse Repository
Passed
No Audits

Mar 4 2017

be16f9b2cd57 Add a generic "edge.search" method
Author
epriestley
Revisions
D17462: Add a generic "edge.search" method
Browse Repository
Passed
No Audits

Feb 18 2017

9f3cde4db765 Fix errors found by PHPStan
Author
vrana
Revisions
D17377: Fix errors found by PHPStan
Browse Repository
Passed
No Audits

Oct 20 2016

a3253f78ce14 Make query engines "overheat" instead of stalling when filtering too many…
Author
epriestley
Revisions
D16735: Make query engines "overheat" instead of stalling when filtering too many results
Browse Repository
Passed
No Audits

Jul 13 2016

872bcd4487e6 Make limits and ranges work better with Calendar event queries
Author
epriestley
Revisions
D16289: Make limits and ranges work better with Calendar event queries
Browse Repository
Passed
No Audits

Mar 22 2016

47dedfb152d0 Introduce "bridged" objects
Author
epriestley
Revisions
D15502: Introduce "bridged" objects
Browse Repository
Passed
No Audits

Jan 21 2016

358240b80400 Fix an issue with paginating queries which reverse vector ordering components
Author
epriestley
Revisions
D15076: Fix an issue with paginating queries which reverse vector ordering components
Browse Repository
Passed
No Audits

Jan 12 2016

dd21761df9e8 Don't return any results for viewerprojects() if the viewer is in no projects
Author
epriestley
Revisions
D15003: Don't return any results for viewerprojects() if the viewer is in no projects
Browse Repository
Passed
No Audits

Dec 29 2015

14ae3c099c2e Make queries for Project "X" mean "X, or any subproject of X"
Author
epriestley
Revisions
D14910: Make queries for Project "X" mean "X, or any subproject of X"
Browse Repository
Passed
No Audits

Dec 22 2015

96fe8c0b83cf Implement basic ngram search for Owners Package names
Author
epriestley
Revisions
D14846: Implement basic ngram search for Owners Package names
Browse Repository
Passed
No Audits

Dec 16 2015

a5d23c9f3e88 Allow custom fields to be ordered ascending or descending
Author
epriestley
Revisions
D14800: Allow custom fields to be ordered ascending or descending
Browse Repository
Passed
No Audits

Dec 13 2015

9499987cfe6f Add "owners.search" Conduit API endpoint, with CustomField support
Author
epriestley
Revisions
D14758: Add "owners.search" Conduit API endpoint, with CustomField support
Browse Repository
Passed
No Audits

Jul 7 2015

9979952e71a5 Refine "invalid cursor" exception to have a little more information
Author
epriestley
Revisions
D13583: Refine "invalid cursor" exception to have a little more information
Browse Repository
No Builds
No Audits

Jul 3 2015

92b73fed6b2c Don't apply space constraints to omnipotent-viewer queries
Author
epriestley
Revisions
D13542: Don't apply space constraints to omnipotent-viewer queries
Browse Repository
No Builds
No Audits

Jul 1 2015

d5e4d9608626 Don't put objects into the query workspace by default
Author
epriestley
Revisions
D13516: Don't put objects into the query workspace by default
Browse Repository
No Builds
No Audits

Jun 30 2015

4adaf53bf0cb Dramatically increase cache hit rate for feed
Author
epriestley
Revisions
D13479: Dramatically increase cache hit rate for feed
Browse Repository
No Builds
No Audits

Jun 17 2015

6933ee5fb86d Don't spend ridiculous amounts of time rebuilding orderable columns
Author
epriestley
Revisions
D13322: Don't spend ridiculous amounts of time rebuilding orderable columns
Browse Repository
No Builds
No Audits

8484adcffdf6 Cache application visibility in the request cache
Author
epriestley
Revisions
D13321: Cache application visibility in the request cache
Browse Repository
No Builds
No Audits

Jun 14 2015

2fbc65e39649 Call didRejectResult() in DiffusionCommitQuery properly
Author
epriestley
Revisions
D13289: Call didRejectResult() in DiffusionCommitQuery properly
Browse Repository
No Builds
No Audits

Jun 11 2015

88e7cd158f28 Allow Spaces to be archived
Author
epriestley
Revisions
D13238: Allow Spaces to be archived
Browse Repository
No Builds
No Audits

Jun 8 2015

1a091e526047 Drive Maniphest grouping and ordering through standard infrastructure
Author
epriestley
Revisions
D13197: Drive Maniphest grouping and ordering through standard infrastructure
Browse Repository
No Builds
No Audits

bf87976d25de Support ordering in SearchField
Author
epriestley
Revisions
D13193: Support ordering in SearchField
Browse Repository
No Builds
No Audits

3cdaf52ce97a Make Subscribers automatically provide working SearchFields
Author
epriestley
Revisions
D13191: Make Subscribers automatically provide working SearchFields
Browse Repository
No Builds
No Audits

Jun 7 2015

2492fef029b1 Move Pholio to SearchFields
Author
epriestley
Revisions
D13174: Move Pholio to SearchFields
Browse Repository
No Builds
No Audits

Jun 5 2015

c1c897b96117 Provide core policy support for Spaces
Author
epriestley
Revisions
D13156: Provide core policy support for Spaces
Browse Repository
No Builds
No Audits

May 22 2015

36e2d02d6ec5 phtize all the things
Author
joshuaspence
Revisions
D12797: phtize all the things
Browse Repository
No Builds
No Audits

May 7 2015

7556a70280c8 Prevent Files from requiring infinite policy checks
Author
epriestley
Revisions
D12756: Prevent Files from requiring infinite policy checks
Browse Repository
No Builds
No Audits

Apr 29 2015

f3a2d2b02043 Restore missing ApplicationSearch join clause for Maniphest
Author
epriestley
Revisions
D12614: Restore missing ApplicationSearch join clause for Maniphest
Browse Repository
No Builds
No Audits

Apr 23 2015

22e3e35418be Move ManiphestTaskQuery to EdgeLogic
Author
epriestley
Revisions
D12526: Move ManiphestTaskQuery to EdgeLogic
Browse Repository
No Builds
No Audits

Apr 20 2015

4005bff56702 Implement function-driven logical project queries in Differential
Author
epriestley
Revisions
D12463: Implement function-driven logical project queries in Differential
Browse Repository
No Builds
No Audits

e27c0b416d45 Add "Edge Logic" support to PolicyAwareQuery
Author
epriestley
Revisions
D12455: Add "Edge Logic" support to PolicyAwareQuery
Browse Repository
No Builds
No Audits

55e49d7e316c Provide more buildXClause() and buildXClauseParts() on PolicyAwareQuery
Author
epriestley
Revisions
D12454: Provide more buildXClause() and buildXClauseParts() on PolicyAwareQuery
Browse Repository
No Builds
No Audits

f5580c7a083e Make buildWhereClause() a method of AphrontCursorPagedPolicyAwareQuery
Author
epriestley
Revisions
D12453: Make buildWhereClause() a method of AphrontCursorPagedPolicyAwareQuery
Browse Repository
No Builds
No Audits

Apr 17 2015

9437414f1756 Improve browsability of Almanac service datasource query
Author
epriestley
Revisions
D12433: Improve browsability of Almanac service datasource query
Browse Repository
No Builds
No Audits

Apr 13 2015

8efdc4aabf09 Replace getPagingValue() with cursor methods
Author
epriestley
Revisions
D12383: Replace getPagingValue() with cursor methods
Browse Repository
No Builds
No Audits

6e4f508bebdb Provide "builtin" high-level result orders
Author
epriestley
Revisions
D12379: Provide "builtin" high-level result orders
Browse Repository
No Builds
No Audits

2794c69db550 Remove getPagingColumn() / getReversePaging()
Author
epriestley
Revisions
D12378: Remove getPagingColumn() / getReversePaging()
Browse Repository
No Builds
No Audits

bdd1edea7a40 Modernize ManiphestTask paging and ordering
Author
epriestley
Revisions
D12372: Modernize ManiphestTask paging and ordering
Browse Repository
No Builds
No Audits

411456084448 Modernize more paging/order queries
Author
epriestley
Revisions
D12371: Modernize more paging/order queries
Browse Repository
No Builds
No Audits

9c7c13ffc88a Modernize Phrequent and Commit query ordering/paging
Author
epriestley
Revisions
D12363: Modernize Phrequent and Commit query ordering/paging
Browse Repository
No Builds
No Audits

e0fa0fbdee1b Modernize Phriction ordering/paging
Author
epriestley
Revisions
D12360: Modernize Phriction ordering/paging
Browse Repository
No Builds
No Audits

a4a198342e2c Modernize ReleephProjectQuery ordering/paging
Author
epriestley
Revisions
D12358: Modernize ReleephProjectQuery ordering/paging
Browse Repository
No Builds
No Audits

4fba6e7730aa Remove trivial implementations of getPagingColumn()
Author
epriestley
Revisions
D12356: Remove trivial implementations of getPagingColumn()
Browse Repository
No Builds
No Audits

a40c40fade6a Drive query ordering and paging more cohesively
Author
epriestley
Revisions
D12355: Drive query ordering and paging more cohesively
Browse Repository
No Builds
No Audits

604d1409f16f Make buildPagingClauseFromMultipleColumns() safer
Author
epriestley
Revisions
D12353: Make buildPagingClauseFromMultipleColumns() safer
Browse Repository
No Builds
No Audits

a43473c4b65c Begin formalizing query orders
Author
epriestley
Revisions
D12352: Begin formalizing query orders
Browse Repository
No Builds
No Audits

9dc114d1159a Make formatOrderClause() safer
Author
epriestley
Revisions
D12351: Make formatOrderClause() safer
Browse Repository
No Builds
No Audits

Mar 23 2015

6eadfe6a6fce Allow repositories to be ordered by commit count
Author
epriestley
Revisions
D12122: Allow repositories to be ordered by commit count
Browse Repository
No Builds
No Audits

Mar 14 2015

106ca70acb62 Fix an issue where subpriority paging could be truncated
Author
epriestley
Browse Repository
No Builds
Audited