Diffusion Phabricator (master) History

phabricator/src/applications/transactions/editor
master

Feb 3 2021

9502312b60ae Remove "final" from "private" methods in Phabricator
Author
epriestley
Revisions
D21540: Remove "final" from "private" methods in Phabricator
Browse Repository
Passed
No Audits

Jul 9 2020

6e85b521fe86 Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't…
Author
epriestley
Revisions
D21402: Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't adding any non-you subscribers
Browse Repository
Passed
No Audits

May 7 2020

94a95efa059a Replace "loadUnsubmittedInlineComments()" with a modern "DiffQuery"
Author
epriestley
Revisions
D21234: Replace "loadUnsubmittedInlineComments()" with a modern "DiffQuery"
Browse Repository
Passed
No Audits

May 4 2020

f5ef341c9e35 Don't publish "empty" inline comments
Author
epriestley
Revisions
D21211: Don't publish "empty" inline comments
Browse Repository
Passed
No Audits

67da18e37478 When users submit "editing" inlines, warn them that their inlines will be saved
Author
epriestley
Revisions
D21191: When users submit "editing" inlines, warn them that their inlines will be saved
Browse Repository
Passed
No Audits

Jan 30 2020

12c337098872 When issuing a "no-op" MFA token because no MFA is configured, don't give the…
Author
epriestley
Revisions
D20958: When issuing a "no-op" MFA token because no MFA is configured, don't give the timeline story a badge
Browse Repository
Passed
No Audits

Aug 26 2019

a0a38797127f In Phortune, send order email to account external addresses
Author
epriestley
Revisions
D20739: In Phortune, send order email to account external addresses
Browse Repository
Passed
No Audits

Jul 23 2019

cd449254256d Allow users with no CAN_EDIT permissions to silence projects if they want to
Author
artms
Revisions
D20675: Allow users with no CAN_EDIT permissions to silence projects if they want to
Browse Repository
Passed
No Audits

Jun 20 2019

6b9f4a918b85 Modularize PhabricatorEditEngineConfigurationTransaction
Author
amckinley
Revisions
D20595: Modularize PhabricatorEditEngineConfigurationTransaction
Browse Repository
Passed
No Audits

Jun 18 2019

753828649956 Fix missing link targets for "View Object" header buttons in HTML email
Author
epriestley
Revisions
D20586: Fix missing link targets for "View Object" header buttons in HTML email
Browse Repository
Passed
No Audits

Jun 17 2019

874282db7589 Correct "msort()" vs "msortv()" to more fully stabilize transaction sorts after…
Author
epriestley
Revisions
D20583: Correct "msort()" vs "msortv()" to more fully stabilize transaction sorts after recent changes
Browse Repository
Failed
No Audits

May 31 2019

81134d7e7d54 After reloading transactions for the recipient while building transaction mail…
Author
epriestley
Revisions
D20563: After reloading transactions for the recipient while building transaction mail, put them in the input order
Browse Repository
Passed
No Audits

May 30 2019

9a32a563f047 Add a "View Task" button to HTML mail from Maniphest
Author
epriestley
Revisions
D20561: Add a "View Task" button to HTML mail from Maniphest
Browse Repository
Passed
No Audits

May 28 2019

53b9acfb7d58 Test for "CAN_INTERACT" on comment edits in a way that survives objects which…
Author
epriestley
Revisions
D20558: Test for "CAN_INTERACT" on comment edits in a way that survives objects which only implement "CAN_VIEW"
Browse Repository
Passed
No Audits

May 24 2019

ce6fc5be9092 Fix a looping workflow when trying to submit a partially-effectless transaction…
Author
epriestley
Revisions
D20552: Fix a looping workflow when trying to submit a partially-effectless transaction group
Browse Repository
Passed
No Audits

aacc62463d61 Prevent editing and deleting comments in locked conversations
Author
epriestley
Revisions
D20551: Prevent editing and deleting comments in locked conversations
Browse Repository
Passed
No Audits

May 22 2019

31e623afcc92 Use the same transaction group ID for transactions applied indirectly by a sub…
Author
epriestley
Revisions
D20546: Use the same transaction group ID for transactions applied indirectly by a sub-editor
Browse Repository
Passed
No Audits

1eff4fdca332 Prevent "Differential Revision: ..." from counting as a mention in commit…
Author
epriestley
Revisions
D20544: Prevent "Differential Revision: ..." from counting as a mention in commit messages
Browse Repository
Passed
No Audits

fa4dcaa3aaff Stabilize sorting of feed stories with similar strength
Author
epriestley
Revisions
D20540: Stabilize sorting of feed stories with similar strength
Browse Repository
Passed
No Audits

May 21 2019

b8f6248e0782 Fix an issue where handles could load with the incorrect viewer when building…
Author
epriestley
Revisions
D20525: Fix an issue where handles could load with the incorrect viewer when building mail about changes to related objects
Browse Repository
Passed
No Audits

May 17 2019

167f06d3eb70 Label transaction groups with a "group ID" so Herald can reconstruct them…
Author
epriestley
Revisions
D20524: Label transaction groups with a "group ID" so Herald can reconstruct them faithfully
Browse Repository
Passed
No Audits

May 14 2019

3e0391c574f2 Don't mark subscribes/mentions as "Lock Overridden"
Author
epriestley
Browse Repository
Passed
No Audits

Apr 29 2019

0d9362355b1e In ApplicationTransactionEditor, determine new objects with "getID()" instead…
Author
epriestley
Browse Repository
Passed
No Audits

Apr 24 2019

b3b1cc64bdd0 When applying transactions, acquire a read lock sooner
Author
epriestley
Revisions
D20462: When applying transactions, acquire a read lock sooner
Browse Repository
Passed
No Audits

Mar 28 2019

15cc475cbd8c When a comment was signed with MFA, require MFA to edit it
Author
epriestley
Revisions
D20340: When a comment was signed with MFA, require MFA to edit it
Browse Repository
Passed
No Audits

Mar 18 2019

a6fd8f04792d When performing complex edits, pause sub-editors before they publish to…
Author
epriestley
Revisions
D20283: When performing complex edits, pause sub-editors before they publish to propagate "Must Encrypt" and other state
Browse Repository
Passed
No Audits

Mar 13 2019

04f9e72cbd10 Don't subscribe bots implicitly when they act on objects, or when they are…
Author
epriestley
Revisions
D20284: Don't subscribe bots implicitly when they act on objects, or when they are mentioned
Browse Repository
Passed
No Audits

Feb 28 2019

814e6d2de927 Add more type checking to transactions queued by Herald
Author
epriestley
Revisions
D20214: Add more type checking to transactions queued by Herald
Browse Repository
Passed
No Audits

Feb 19 2019

e44b40ca4d83 Make "Subscribe/Unsubscribe" require only "CAN_VIEW", not "CAN_INTERACT"
Author
epriestley
Revisions
D20174: Make "Subscribe/Unsubscribe" require only "CAN_VIEW", not "CAN_INTERACT"
Browse Repository
Passed
No Audits

Feb 9 2019

a20f10803412 When an edit overrides an object lock, note it in the transaction record
Author
epriestley
Revisions
D20131: When an edit overrides an object lock, note it in the transaction record
Browse Repository
Passed
No Audits

Feb 7 2019

9f5e6bee9037 Make the default behavior of getApplicationTransactionCommentObject() "return…
Author
epriestley
Revisions
D20121: Make the default behavior of getApplicationTransactionCommentObject() "return null" instead of "throw"
Browse Repository
Passed
No Audits

Feb 1 2019

7c795ab75722 Let omnipotent actors skip MFA transactions
Author
epriestley
Revisions
D20081: Let omnipotent actors skip MFA transactions
Browse Repository
Passed
No Audits

Jan 31 2019

b33333ab8e7a Fix method name typo in new modular transaction text/html mail methods
Author
epriestley
Browse Repository
Passed
Audit Required

138c07f32c79 Allow modular transactions to override transaction title and body text in mail
Author
epriestley
Revisions
D20057: Allow modular transactions to override transaction title and body text in mail
Browse Repository
Passed
No Audits

93b512b63cca Update a factor query in TransactionEditor for providers
Author
epriestley
Revisions
D20072: Update a factor query in TransactionEditor for providers
Browse Repository
Passed
No Audits

Jan 30 2019

f7e8fa0764fe Provide an Editor extension point for transaction validation
Author
epriestley
Revisions
D20041: Provide an Editor extension point for transaction validation
Browse Repository
Passed
No Audits

Jan 28 2019

d24e66724d3b Convert "Rename User" from session MFA to one-shot MFA
Author
epriestley
Revisions
D20036: Convert "Rename User" from session MFA to one-shot MFA
Browse Repository
Passed
No Audits

Jan 23 2019

587e9cea19ac Always require MFA to edit contact numbers
Author
epriestley
Revisions
D20024: Always require MFA to edit contact numbers
Browse Repository
Passed
No Audits

Jan 21 2019

afd2ace0dc9c Apply inverse edge edits after committing primary object edits
Author
epriestley
Revisions
D19969: Apply inverse edge edits after committing primary object edits
Browse Repository
Passed
No Audits

Jan 16 2019

0c0cbb1c09e4 Fix an issue where transactions in mail were always rendered as text
Author
epriestley
Revisions
D19968: Fix an issue where transactions in mail were always rendered as text
Browse Repository
Passed
No Audits

966a93334c85 Don't require "CAN_EDIT" to watch/unwatch a project
Author
epriestley
Revisions
D19977: Don't require "CAN_EDIT" to watch/unwatch a project
Browse Repository
Passed
No Audits

Dec 28 2018

106e90dcf086 Remove the "willApplyTransactions()" hook from ApplicationTransactionEditor
Author
epriestley
Revisions
D19909: Remove the "willApplyTransactions()" hook from ApplicationTransactionEditor
Browse Repository
Passed
No Audits

efb01bf34f60 Allow "MFA Required" objects to be edited without MFA if the edit is only…
Author
epriestley
Revisions
D19901: Allow "MFA Required" objects to be edited without MFA if the edit is only creating inverse edges
Browse Repository
Passed
No Audits

d3c325c4fc73 Allow objects to be put in an "MFA required for all interactions" mode, and…
Author
epriestley
Revisions
D19899: Allow objects to be put in an "MFA required for all interactions" mode, and support "MFA required" statuses in Maniphest
Browse Repository
Passed
No Audits

543f2b6bf156 Allow any transaction group to be signed with a one-shot "Sign With MFA" action
Author
epriestley
Revisions
D19897: Allow any transaction group to be signed with a one-shot "Sign With MFA" action
Browse Repository
Passed
No Audits

Dec 20 2018

11cf8f05b176 Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface
Author
epriestley
Revisions
D19920: Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface
Browse Repository
Passed
No Audits

Dec 11 2018

773b4eaa9ea0 Separate "feed" and "notifications" better, allow stories to appear in…
Author
epriestley
Revisions
D19864: Separate "feed" and "notifications" better, allow stories to appear in notifications only
Browse Repository
Passed
No Audits

ba833805656e Update the "Notification Test" workflow to use more modern mechanisms
Author
epriestley
Revisions
D19861: Update the "Notification Test" workflow to use more modern mechanisms
Browse Repository
Passed
No Audits

Dec 10 2018

508df60a6217 When users mark their own inline comments as "Done", suppress the timeline/mail…
Author
epriestley
Revisions
D19859: When users mark their own inline comments as "Done", suppress the timeline/mail stories
Browse Repository
Passed
No Audits

46feccdfcf19 Share more inline "Done" code between Differential and Diffusion
Author
epriestley
Revisions
D19858: Share more inline "Done" code between Differential and Diffusion
Browse Repository
Passed
No Audits

f0eefdd0b58b Replace the informal "array" subtype map with a more formal "SubtypeMap" object
Author
epriestley
Revisions
D19852: Replace the informal "array" subtype map with a more formal "SubtypeMap" object
Browse Repository
Passed
No Audits

Nov 16 2018

b2e91d220539 Move the "container updated" message for Buildables that build Diffs outside of…
Author
epriestley
Revisions
D19807: Move the "container updated" message for Buildables that build Diffs outside of the transaction
Browse Repository
Passed
No Audits

Sep 12 2018

f5e90a363e7a When a user takes actions while in a high security session, note it on the…
Author
epriestley
Revisions
D19665: When a user takes actions while in a high security session, note it on the resulting transactions
Browse Repository
Passed
No Audits

Aug 25 2018

4d89afcc6149 Remove requireCapabilities() from ApplicationTransactionEditor and require…
Author
epriestley
Revisions
D19586: Remove requireCapabilities() from ApplicationTransactionEditor and require CAN_EDIT by default
Browse Repository
Passed
No Audits

Jul 27 2018

a5d3aea67c5b Carry the "silent" transaction flag through inverse edge edits
Author
epriestley
Revisions
D19543: Carry the "silent" transaction flag through inverse edge edits
Browse Repository
Passed
No Audits

Apr 16 2018

f9b3673fbbe1 When mail (like "!history" mail) has multiple comments, label them separately
Author
epriestley
Revisions
D19373: When mail (like "!history" mail) has multiple comments, label them separately
Browse Repository
Passed
No Audits

25965260c431 Add a rough "!history" email command to get an entire object history via email
Author
epriestley
Revisions
D19372: Add a rough "!history" email command to get an entire object history via email
Browse Repository
Passed
No Audits

Apr 3 2018

ada0c9126cf0 Provide a modular buildable transaction in Diffusion
Author
epriestley
Revisions
D19280: Provide a modular buildable transaction in Diffusion
Browse Repository
Passed
No Audits

Mar 28 2018

b586ee065a75 Stop evaluating Herald rules when writing "someone mentioned this somewhere…
Author
epriestley
Revisions
D19263: Stop evaluating Herald rules when writing "someone mentioned this somewhere else." transactions
Browse Repository
Passed
No Audits

Mar 21 2018

6ed123e0801a Propagate "unexpandable" PHIDs to feed notification recipient expansion
Author
epriestley
Revisions
D19244: Propagate "unexpandable" PHIDs to feed notification recipient expansion
Browse Repository
Passed
No Audits

Mar 13 2018

df8d4dff679b Raise a warning when mentioning a user in a comment on a draft revision
Author
epriestley
Revisions
D19210: Raise a warning when mentioning a user in a comment on a draft revision
Browse Repository
Passed
No Audits

Feb 16 2018

bfdc9411f705 Provide context objects for remarkup mail rendering, fixing Phriction relative…
Author
epriestley
Revisions
D19105: Provide context objects for remarkup mail rendering, fixing Phriction relative URIs in initial email
Browse Repository
Passed
No Audits

Feb 12 2018

66f20595e4d2 Start buildables in "PREPARING", move them to "BUILDING" after builds queue
Author
epriestley
Revisions
D19065: Start buildables in "PREPARING", move them to "BUILDING" after builds queue
Browse Repository
Passed
No Audits

Feb 11 2018

653bc0fa019f Read lock all transaction edits
Author
epriestley
Revisions
D19059: Read lock all transaction edits
Browse Repository
Passed
No Audits

Feb 9 2018

64177cb16e77 Document how webhooks work
Author
epriestley
Revisions
D19050: Document how webhooks work
Browse Repository
Failed
No Audits

98c701ffc55f Add a "Call webhooks" action to Herald
Author
epriestley
Revisions
D19049: Add a "Call webhooks" action to Herald
Browse Repository
Failed
No Audits

41d28abfcc46 Trigger all "Firehose" webhooks on all transactional edits
Author
epriestley
Revisions
D19048: Trigger all "Firehose" webhooks on all transactional edits
Browse Repository
Failed
No Audits

Feb 8 2018

ab04d2179bf1 Add "Mute/Unmute" for subscribable objects
Author
epriestley
Revisions
D19033: Add "Mute/Unmute" for subscribable objects
Browse Repository
Passed
No Audits

bca9c08953bd Add an "Acting user" field to Herald
Author
epriestley
Revisions
D19031: Add an "Acting user" field to Herald
Browse Repository
Passed
No Audits

1cd3a593784a When users resign from revisions, stop expanding projects/packages to include…
Author
epriestley
Revisions
D19021: When users resign from revisions, stop expanding projects/packages to include them
Browse Repository
Passed
No Audits

f214abb63f9d When a change removes recipients from an object, send them one last email
Author
epriestley
Revisions
D19019: When a change removes recipients from an object, send them one last email
Browse Repository
Passed
No Audits

994d2e8e1563 Use "cluster.mailers" if it is configured
Author
epriestley
Revisions
D19005: Use "cluster.mailers" if it is configured
Browse Repository
Passed
No Audits

Feb 6 2018

56bf0690804f Try running Herald when performing inverse edge edits
Author
epriestley
Revisions
D18999: Try running Herald when performing inverse edge edits
Browse Repository
Passed
No Audits

1bf64e5cbcf4 Add Differential and Herald mail stamps and some refinements
Author
epriestley
Revisions
D18997: Add Differential and Herald mail stamps and some refinements
Browse Repository
Passed
No Audits

3131e733a85c Add Editor-based mail stamps: actor, via, silent, encrypted, new, mention, self…
Author
epriestley
Revisions
D18995: Add Editor-based mail stamps: actor, via, silent, encrypted, new, mention, self-actor, self-mention
Browse Repository
Passed
No Audits

c3f95bc410a3 Add basic support for mail "stamps" to improve client mail routing
Author
epriestley
Revisions
D18991: Add basic support for mail "stamps" to improve client mail routing
Browse Repository
Passed
No Audits

Feb 2 2018

cbe4e68c0722 Add a Herald action to trigger "Must Encrypt" for mail
Author
epriestley
Revisions
D18984: Add a Herald action to trigger "Must Encrypt" for mail
Browse Repository
Passed
No Audits

Jan 29 2018

e5639a8ed90f Write edge transactions in a more compact way
Author
epriestley
Revisions
D18947: Write edge transactions in a more compact way
Browse Repository
Passed
No Audits

Jan 26 2018

fd66ab55791e Always use the same set of transactions to generate mail and mail tags
Author
epriestley
Revisions
D18941: Always use the same set of transactions to generate mail and mail tags
Browse Repository
Passed
No Audits

Jan 19 2018

8b12fa6d6ed0 Prepare TransactionEditor for silent transactions via bulk edit
Author
epriestley
Revisions
D18882: Prepare TransactionEditor for silent transactions via bulk edit
Browse Repository
Passed
No Audits

8a5def8e0ae1 Remove legacy transaction editor "getDisableEmail()" method
Author
epriestley
Revisions
D18881: Remove legacy transaction editor "getDisableEmail()" method
Browse Repository
Passed
No Audits

Jan 4 2018

129e3a120849 Fix a minor/harmless race with feed publishers in certain draft states
Author
epriestley
Revisions
D18852: Fix a minor/harmless race with feed publishers in certain draft states
Browse Repository
Passed
No Audits

Dec 5 2017

6d3baa92f908 Execute Herald again after promoting revisions out of the "Draft" state
Author
epriestley
Revisions
D18819: Execute Herald again after promoting revisions out of the "Draft" state
Browse Repository
Passed
No Audits

Oct 9 2017

9bd6a3705559 Fix spelling
Author
0
Revisions
D18693: Fix spelling
Browse Repository
Failed
No Audits

Sep 21 2017

36df39761ea5 Create revisions into "Draft", publish them when builds finish
Author
epriestley
Revisions
D18628: Create revisions into "Draft", publish them when builds finish
Browse Repository
Passed
No Audits

Aug 24 2017

9639ec0dfabd Slightly simplify logic for determining if an inline comment has an effect
Author
epriestley
Revisions
D18468: Slightly simplify logic for determining if an inline comment has an effect
Browse Repository
Passed
No Audits

May 18 2017

1e3c8df1c89d Migrate Project names to modular transactions
Author
amckinley
Revisions
D17947: Migrate Project names to modular transactions
Browse Repository
Passed
No Audits

May 17 2017

d12be0fc2190 Change Pholio editor access modifier
Author
amckinley
Revisions
D17946: Change Pholio editor access modifier
Browse Repository
Passed
No Audits

May 4 2017

d34b338f3f85 Implement modular transactions for application policy changes
Author
amckinley
Revisions
D17757: Implement modular transactions for application policy changes
Browse Repository
Passed
No Audits

May 3 2017

60a19e36463b Allow ApplicationTransactionEditor to figure out whether TYPE_COMMENT is…
Author
epriestley
Revisions
D17822: Allow ApplicationTransactionEditor to figure out whether TYPE_COMMENT is supported or not
Browse Repository
Passed
No Audits

Apr 19 2017

51485a1f8257 Add participants ModularTransactions to Conpherence
Author
Chad Little <chad@phacility.com>
Revisions
D17685: Add participants ModularTransactions to Conpherence
Browse Repository
Passed
No Audits

Mar 22 2017

9c998e988b1d Don't require mentioned objects to have all required fields when editing…
Author
epriestley
Revisions
D17536: Don't require mentioned objects to have all required fields when editing comments
Browse Repository
Passed
No Audits

Mar 3 2017

5ed90b223591 Only validate form subtype edits if subtype transactions are present
Author
epriestley
Revisions
D17457: Only validate form subtype edits if subtype transactions are present
Browse Repository
Passed
No Audits

Mar 2 2017

4a061b1defff When an object which supports subtypes is created, set its subtype to the…
Author
epriestley
Revisions
D17443: When an object which supports subtypes is created, set its subtype to the creating form's subtype
Browse Repository
Passed
No Audits

b9d60d2653a3 Allow EditEngine forms for objects which support subtyping to have a subtype…
Author
epriestley
Revisions
D17442: Allow EditEngine forms for objects which support subtyping to have a subtype configured
Browse Repository
Passed
No Audits

Feb 24 2017

d38ee2d79aa6 Update Phurl for modular transactions
Author
Chad Little <chad@phacility.com>
Revisions
D17405: Update Phurl for modular transactions
Browse Repository
Passed
No Audits

Feb 23 2017

3b6a651b69fe Merge multiple Auditors transactions from Herald
Author
epriestley
Revisions
D17403: Merge multiple Auditors transactions from Herald
Browse Repository
Passed
No Audits

Dec 6 2016

e6ddd6d0e95d Cache Almanac URIs for repositories
Author
epriestley
Revisions
D17000: Cache Almanac URIs for repositories
Browse Repository
Passed
No Audits

Nov 28 2016

22a566f7326c Ignore Calendar date edits which just change the internal date timezone without…
Author
epriestley
Revisions
D16955: Ignore Calendar date edits which just change the internal date timezone without rescheduling it
Browse Repository
Passed
No Audits

Nov 7 2016

729492a8ff85 Allow transactions to specialize their mail headers for diff sections
Author
epriestley
Revisions
D16818: Allow transactions to specialize their mail headers for diff sections
Browse Repository
Passed
No Audits