Diffusion Phabricator (master) History

phabricator/src/applications/transactions/editengine
master

Sep 8 2020

6e1b5da1121c Fix additional "xprintf()"-class static parameter lint errors
Author
epriestley
Revisions
D21457: Fix additional "xprintf()"-class static parameter lint errors
Browse Repository
Passed
No Audits

May 4 2020

67da18e37478 When users submit "editing" inlines, warn them that their inlines will be saved
Author
epriestley
Revisions
D21191: When users submit "editing" inlines, warn them that their inlines will be saved
Browse Repository
Passed
No Audits

Apr 27 2020

b5bed7b0fa87 Make omitting "value" from a transaction description an explicit error
Author
epriestley
Revisions
D21176: Make omitting "value" from a transaction description an explicit error
Browse Repository
Passed
No Audits

Apr 19 2020

7a79131bf279 Replace old hard-coded URI-based "changes saved" jank with new overgeneralized…
Author
epriestley
Revisions
D21144: Replace old hard-coded URI-based "changes saved" jank with new overgeneralized cookie-based "changes saved" jank
Browse Repository
Passed
No Audits

Sep 26 2019

7a0090f4d070 Fix an issue where the "viewer" is not passed to Bulk Edit controls properly
Author
epriestley
Revisions
D20841: Fix an issue where the "viewer" is not passed to Bulk Edit controls properly
Browse Repository
Passed
No Audits

Sep 12 2019

41f0b8b0a3a1 Allow subtypes to specify "mutations", to control the behavior of the "Change…
Author
epriestley
Revisions
D20810: Allow subtypes to specify "mutations", to control the behavior of the "Change Subtype" action
Browse Repository
Passed
No Audits

3e6012803725 Support "Subtype" in Herald
Author
epriestley
Revisions
D20809: Support "Subtype" in Herald
Browse Repository
Passed
No Audits

Apr 2 2019

c9d3fb2ac5b6 Fix the incorrect link target for "Create Revision" as a Menu Item
Author
epriestley
Revisions
D20360: Fix the incorrect link target for "Create Revision" as a Menu Item
Browse Repository
Passed
No Audits

Feb 16 2019

0b2d25778d8f Add basic, rough support for changing field behavior based on object subtype
Author
epriestley
Revisions
D20161: Add basic, rough support for changing field behavior based on object subtype
Browse Repository
Passed
No Audits

Feb 14 2019

4c124201623a Replace "URI->setQueryParams()" after initialization with a constructor argument
Author
epriestley
Revisions
D20151: Replace "URI->setQueryParams()" after initialization with a constructor argument
Browse Repository
Passed
No Audits

Feb 12 2019

fcd85b6d7bed Replace "getRequestURI()->setQueryParams(array())" with "getPath()"
Author
epriestley
Revisions
D20150: Replace "getRequestURI()->setQueryParams(array())" with "getPath()"
Browse Repository
Passed
No Audits

Jan 30 2019

2374c92544e0 Add a warning about MFA requirements to edit forms
Author
epriestley
Revisions
D20045: Add a warning about MFA requirements to edit forms
Browse Repository
Passed
No Audits

13c5b427d637 Warn users about MFA requirements when interacting with "MFA Required" objects…
Author
epriestley
Revisions
D20044: Warn users about MFA requirements when interacting with "MFA Required" objects via the comment form
Browse Repository
Passed
No Audits

Jan 23 2019

587e9cea19ac Always require MFA to edit contact numbers
Author
epriestley
Revisions
D20024: Always require MFA to edit contact numbers
Browse Repository
Passed
No Audits

f713fa1fd7ec Expand "Settings" UI to full-width
Author
epriestley
Revisions
D20005: Expand "Settings" UI to full-width
Browse Repository
Passed
No Audits

Jan 3 2019

3963c86ad5e5 Pass timeline view data to comment previews, restoring Differential comment…
Author
epriestley
Revisions
D19943: Pass timeline view data to comment previews, restoring Differential comment previews
Browse Repository
Passed
No Audits

Dec 28 2018

d3c325c4fc73 Allow objects to be put in an "MFA required for all interactions" mode, and…
Author
epriestley
Revisions
D19899: Allow objects to be put in an "MFA required for all interactions" mode, and support "MFA required" statuses in Maniphest
Browse Repository
Passed
No Audits

543f2b6bf156 Allow any transaction group to be signed with a one-shot "Sign With MFA" action
Author
epriestley
Revisions
D19897: Allow any transaction group to be signed with a one-shot "Sign With MFA" action
Browse Repository
Passed
No Audits

Dec 20 2018

6c43d1d52cbd Remove "willRenderTimeline()" from ApplicationTransactionInterface
Author
epriestley
Revisions
D19918: Remove "willRenderTimeline()" from ApplicationTransactionInterface
Browse Repository
Passed
No Audits

Dec 10 2018

68b1dee1390d Replace the "Choose Subtype" radio buttons dialog with a simpler "big stuff you…
Author
epriestley
Revisions
D19855: Replace the "Choose Subtype" radio buttons dialog with a simpler "big stuff you click" sort of UI
Browse Repository
Passed
No Audits

a6632f8c188a Allow "maniphest.subtypes" to configure which options are presented by "Create…
Author
epriestley
Revisions
D19854: Allow "maniphest.subtypes" to configure which options are presented by "Create Subtask"
Browse Repository
Passed
No Audits

d1bcdaeda467 Allow the "Create Subtask" workflow to prompt for a subtype selection, and…
Author
epriestley
Revisions
D19853: Allow the "Create Subtask" workflow to prompt for a subtype selection, and prepare for customizable options
Browse Repository
Passed
No Audits

f0eefdd0b58b Replace the informal "array" subtype map with a more formal "SubtypeMap" object
Author
epriestley
Revisions
D19852: Replace the informal "array" subtype map with a more formal "SubtypeMap" object
Browse Repository
Passed
No Audits

Nov 28 2018

2f11001f6e3c Allow "Change Subtype" to be selected from the comment action stack
Author
epriestley
Revisions
D19842: Allow "Change Subtype" to be selected from the comment action stack
Browse Repository
Passed
No Audits

Aug 28 2018

fd0da4c41f82 Rename "PHUIDocumentViewPro" to "PHUIDocumentView"
Author
epriestley
Revisions
D19616: Rename "PHUIDocumentViewPro" to "PHUIDocumentView"
Browse Repository
Passed
No Audits

Aug 27 2018

cd8b5b82c860 Stop requiring CAN_EDIT to reach the TransactionEditor via "*.edit" in…
Author
epriestley
Revisions
D19608: Stop requiring CAN_EDIT to reach the TransactionEditor via "*.edit" in EditEngine
Browse Repository
Passed
No Audits

Mar 14 2018

ce6e020d5ddb Don't make an expensive, unused call to test if a viewer can reassign a task
Author
epriestley
Revisions
D19225: Don't make an expensive, unused call to test if a viewer can reassign a task
Browse Repository
Passed
No Audits

Mar 13 2018

df8d4dff679b Raise a warning when mentioning a user in a comment on a draft revision
Author
epriestley
Revisions
D19210: Raise a warning when mentioning a user in a comment on a draft revision
Browse Repository
Passed
No Audits

Mar 7 2018

28854ae8121b Return a integer JSON type from "*.edit" endpoints for the object ID
Author
epriestley
Revisions
D19186: Return a integer JSON type from "*.edit" endpoints for the object ID
Browse Repository
Passed
No Audits

Feb 11 2018

5e6e9fcc5652 When purging drafts after a transaction edit, purge all drafts
Author
epriestley
Revisions
D19060: When purging drafts after a transaction edit, purge all drafts
Browse Repository
Passed
No Audits

Jan 19 2018

7a431813373a Organize bulk edit actions into nice groups
Author
epriestley
Revisions
D18880: Organize bulk edit actions into nice groups
Browse Repository
Passed
No Audits

a26cf20dd128 Fix a bug with setting custom PHID list field values via Conduit and prepare…
Author
epriestley
Revisions
D18876: Fix a bug with setting custom PHID list field values via Conduit and prepare for bulk edits
Browse Repository
Passed
No Audits

1e51f1d0dc25 Reuse more transaction construction code in bulk editor
Author
epriestley
Revisions
D18875: Reuse more transaction construction code in bulk editor
Browse Repository
Passed
No Audits

91a78db99b33 Support "Assign To" in Maniphest bulk editor
Author
epriestley
Revisions
D18874: Support "Assign To" in Maniphest bulk editor
Browse Repository
Passed
No Audits

0cad6021b6f4 Restore "Tags" and "Subscribers" edit capabilities to Maniphest bulk editor
Author
epriestley
Revisions
D18868: Restore "Tags" and "Subscribers" edit capabilities to Maniphest bulk editor
Browse Repository
Passed
No Audits

687fada5af43 Restore bulk edit support for remarkup fields (description, add comment)
Author
epriestley
Revisions
D18867: Restore bulk edit support for remarkup fields (description, add comment)
Browse Repository
Passed
No Audits

09e71a408235 Define bulk edits in terms of EditEngine, not hard-coded ad-hoc definitions
Author
epriestley
Revisions
D18863: Define bulk edits in terms of EditEngine, not hard-coded ad-hoc definitions
Browse Repository
Passed
No Audits

Jan 4 2018

6d9776fa8963 Give EditEngine a Conduit-specific initialization pathway for objects
Author
epriestley
Revisions
D18847: Give EditEngine a Conduit-specific initialization pathway for objects
Browse Repository
Passed
No Audits

Dec 8 2017

60e5c0ec1b3e Add drydock.blueprint.edit Conduit method
Author
timhirsh
Revisions
D18822: Add drydock.blueprint.edit Conduit method
Browse Repository
Passed
No Audits

Oct 9 2017

9bd6a3705559 Fix spelling
Author
0
Revisions
D18693: Fix spelling
Browse Repository
Failed
No Audits

Sep 6 2017

a903388d4f89 Update EditEngine pages to take a page header separate
Author
Chad Little <chad@phacility.com>
Revisions
D18527: Update EditEngine pages to take a page header separate
Browse Repository
Passed
No Audits

Aug 17 2017

dc10bb1f4980 Update Settings to use TwoColumn fixed layout
Author
Chad Little <chad@phacility.com>
Revisions
D18436: Update Settings to use TwoColumn fixed layout
Browse Repository
Passed
No Audits

Aug 4 2017

83f66ce55e1a Update Settings to use full side-navigation
Author
Chad Little <chad@phacility.com>
Revisions
D18342: Update Settings to use full side-navigation
Browse Repository
Passed
No Audits

May 26 2017

742c3a834fc5 Provide UI hints about task subtypes
Author
epriestley
Revisions
D17451: Provide UI hints about task subtypes
Browse Repository
Passed
No Audits

Mar 23 2017

1953ab98be2b Don't show the "Override Lock" prompt when creating objects
Author
epriestley
Revisions
D17541: Don't show the "Override Lock" prompt when creating objects
Browse Repository
Passed
No Audits

Mar 3 2017

0e7a5623e32c Allow task statuses to "lock" them, preventing additional comments and…
Author
epriestley
Revisions
D17453: Allow task statuses to "lock" them, preventing additional comments and interactions
Browse Repository
Passed
No Audits

0a0ac1302f02 Prevent users from taking "edit"-like actions via comment forms if they don't…
Author
epriestley
Revisions
D17452: Prevent users from taking "edit"-like actions via comment forms if they don't have edit permission
Browse Repository
Passed
No Audits

Mar 2 2017

6f7bb8c91ad3 On workboards, provide all of the supported "create task" forms in the dropdown
Author
epriestley
Revisions
D17446: On workboards, provide all of the supported "create task" forms in the dropdown
Browse Repository
Passed
No Audits

7eab75410a19 When editing a subtyped object, use edit forms of the same subtype
Author
epriestley
Revisions
D17445: When editing a subtyped object, use edit forms of the same subtype
Browse Repository
Passed
No Audits

4948a21959bd Allow tasks to be searched by subtype
Author
epriestley
Revisions
D17444: Allow tasks to be searched by subtype
Browse Repository
Passed
No Audits

4a061b1defff When an object which supports subtypes is created, set its subtype to the…
Author
epriestley
Revisions
D17443: When an object which supports subtypes is created, set its subtype to the creating form's subtype
Browse Repository
Passed
No Audits

b9d60d2653a3 Allow EditEngine forms for objects which support subtyping to have a subtype…
Author
epriestley
Revisions
D17442: Allow EditEngine forms for objects which support subtyping to have a subtype configured
Browse Repository
Passed
No Audits

dc7ecf58753f Add "subtype" storage to Maniphest tasks
Author
epriestley
Revisions
D17441: Add "subtype" storage to Maniphest tasks
Browse Repository
Passed
No Audits

1b96f2fc2870 Add `maniphest.subtypes` for configuring task subtypes
Author
epriestley
Revisions
D17440: Add `maniphest.subtypes` for configuring task subtypes
Browse Repository
Passed
No Audits

91ef2372908c Add a "subtype" field to EditEngine forms
Author
epriestley
Revisions
D17439: Add a "subtype" field to EditEngine forms
Browse Repository
Passed
No Audits

Feb 22 2017

4540ae028a6e Fix "Create Form" link destinations when editing edit forms
Author
epriestley
Revisions
D17398: Fix "Create Form" link destinations when editing edit forms
Browse Repository
Passed
No Audits

Feb 16 2017

b2739710ba74 Don't allow forms which can't create objects to be added to profile menus
Author
epriestley
Revisions
D17372: Don't allow forms which can't create objects to be added to profile menus
Browse Repository
Passed
No Audits

Jan 20 2017

8113b7691089 Validate menu item fields (links, projects, dashboards, applications, forms…
Author
epriestley
Revisions
D17235: Validate menu item fields (links, projects, dashboards, applications, forms, etc)
Browse Repository
Passed
No Audits

Jan 17 2017

9d3f09ab478e Modularize global quick create builtin items
Author
epriestley
Revisions
D17215: Modularize global quick create builtin items
Browse Repository
Passed
No Audits

Jan 13 2017

7276af6a81f4 Make yellow "draft" bubbles more generic
Author
epriestley
Revisions
D17205: Make yellow "draft" bubbles more generic
Browse Repository
Passed
No Audits

Jan 11 2017

452f5bce18e5 Make some defaults for Quick Create / Favorites
Author
Chad Little <chad@phacility.com>
Revisions
D17174: Make some defaults for Quick Create / Favorites
Browse Repository
Passed
No Audits

Jan 9 2017

aa6e788f3666 Mark "v3" API methods as stable; mark obsoleted methods as "Frozen"
Author
epriestley
Revisions
D17158: Mark "v3" API methods as stable; mark obsoleted methods as "Frozen"
Browse Repository
Passed
No Audits

Jan 4 2017

e9243f22b92c Add Form MenuItem, Fix EditEngine Typeahead
Author
Chad Little <chad@phacility.com>
Revisions
D17098: Add Form MenuItem, Fix EditEngine Typeahead
Browse Repository
Passed
No Audits

Dec 31 2016

b373dcef7448 Restore some minor state behaviors to Differential on EditEngine
Author
epriestley
Revisions
D17118: Restore some minor state behaviors to Differential on EditEngine
Browse Repository
Passed
No Audits

18249b097fb6 Make inline comment preview and submission mostly work on EditEngine
Author
epriestley
Revisions
D17116: Make inline comment preview and submission mostly work on EditEngine
Browse Repository
Passed
No Audits

48fcfeadafe2 Allow comment actions to be grouped; group Differential "Review" and "Revision"…
Author
epriestley
Revisions
D17114: Allow comment actions to be grouped; group Differential "Review" and "Revision" actions
Browse Repository
Passed
No Audits

Nov 9 2016

706c21375e8f Remove empty implementations of `describeAutomaticCapabilities()`
Author
epriestley
Revisions
D16831: Remove empty implementations of `describeAutomaticCapabilities()`
Browse Repository
Passed
No Audits

Nov 4 2016

bd3233d3ab0c Use a more conventional placement of parentheses
Author
epriestley
Browse Repository
Passed
Audited

0f1785c0aa8c Allow EditEngine to build NUX buttons that point at the right place
Author
epriestley
Revisions
D16797: Allow EditEngine to build NUX buttons that point at the right place
Browse Repository
Passed
No Audits

Nov 2 2016

29313372e715 Improve some commenting/editing behaviors for recurring events
Author
epriestley
Revisions
D16795: Improve some commenting/editing behaviors for recurring events
Browse Repository
Passed
No Audits

Oct 31 2016

a0ea31f47f26 When users edit recurring events, prompt to "Edit This Event" or "Edit All…
Author
epriestley
Revisions
D16782: When users edit recurring events, prompt to "Edit This Event" or "Edit All Future Events"
Browse Repository
Passed
No Audits

Oct 26 2016

4c3f09a6a660 Suggest better start/end datetimes for Calendar events
Author
epriestley
Revisions
D16754: Suggest better start/end datetimes for Calendar events
Browse Repository
Passed
No Audits

Oct 14 2016

c71bb0550c5d Conduit accept int/bool parameters as strings
Author
gd
Revisions
D16694: Conduit accept int/bool parameters as strings
Browse Repository
Passed
No Audits

Jul 27 2016

e5256bd81584 Hide time controls when editing all-day Calendar events
Author
epriestley
Revisions
D16327: Hide time controls when editing all-day Calendar events
Browse Repository
Failed
No Audits

Jun 7 2016

8a7ded61293a Fix one more remarkup line wrapping issue
Author
epriestley
Revisions
D16065: Fix one more remarkup line wrapping issue
Browse Repository
Passed
No Audits

Jun 5 2016

b4a07d528fdf Allow users to unset "Editor", tailor short error messages properly on settings…
Author
epriestley
Revisions
D16051: Allow users to unset "Editor", tailor short error messages properly on settings forms
Browse Repository
Passed
No Audits

421bf2e548f0 Allow administrators to configure global default settings
Author
epriestley
Revisions
D16048: Allow administrators to configure global default settings
Browse Repository
Passed
No Audits

7969f66dfe07 Fully modularize the "Quick Actions" menu
Author
epriestley
Revisions
D16045: Fully modularize the "Quick Actions" menu
Browse Repository
Passed
No Audits

Jun 4 2016

2f936094d8df Convert "Account" and "Date and Time" settings to EditEngine
Author
epriestley
Revisions
D16017: Convert "Account" and "Date and Time" settings to EditEngine
Browse Repository
Passed
No Audits

May 6 2016

612a93229fa3 Fix some pagination/redirect issues for repositories
Author
epriestley
Revisions
D15865: Fix some pagination/redirect issues for repositories
Browse Repository
Passed
No Audits

May 4 2016

29d1115037b8 Swap Repository Edit UI to new code
Author
epriestley
Revisions
D15842: Swap Repository Edit UI to new code
Browse Repository
Passed
No Audits

May 2 2016

c0d42a89430a Split Repository EditEngine form into smaller pages
Author
epriestley
Revisions
D15832: Split Repository EditEngine form into smaller pages
Browse Repository
Passed
No Audits

Apr 28 2016

311de580d6e3 Port "Actions" to new Repository UI
Author
epriestley
Revisions
D15811: Port "Actions" to new Repository UI
Browse Repository
Passed
No Audits

Apr 20 2016

3b154a34c7e6 Use less hip lingo
Author
epriestley
Revisions
D15771: Use less hip lingo
Browse Repository
Passed
No Audits

7f15e8fbe8d2 Formally deprecate owners.query Conduit API method
Author
epriestley
Revisions
D15769: Formally deprecate owners.query Conduit API method
Browse Repository
Passed
No Audits

Apr 6 2016

4d32c990ab3e Allow stacked comment actions to be explicitly ordered
Author
epriestley
Revisions
D15639: Allow stacked comment actions to be explicitly ordered
Browse Repository
Passed
No Audits

Apr 4 2016

e2685a248b8c Update Conduit for new UI
Author
chad
Revisions
D15613: Update Conduit for new UI
Browse Repository
Passed
No Audits

Mar 28 2016

a939bbc4fa21 Update EditEngine for two column
Author
chad
Revisions
D15531: Update EditEngine for two column
Browse Repository
Passed
No Audits

Mar 26 2016

601aaa5a86c1 Modularize content sources
Author
epriestley
Revisions
D15521: Modularize content sources
Browse Repository
Passed
No Audits

Mar 8 2016

8a7c96390862 Allow applications to test if a user could edit a certain field by clicking…
Author
epriestley
Revisions
D15433: Allow applications to test if a user could edit a certain field by clicking "Edit Thing"
Browse Repository
Passed
No Audits

Feb 22 2016

ab86523ac490 Allow Almanac properties to be deleted, use EditEngine instead of CustomField
Author
epriestley
Revisions
D15327: Allow Almanac properties to be deleted, use EditEngine instead of CustomField
Browse Repository
Passed
No Audits

Jan 28 2016

fe5cd4ca2c77 Move FontIcon calls to Icon
Author
chad
Revisions
D15129: Move FontIcon calls to Icon
Browse Repository
Passed
No Audits

36158dbdc081 Convert all calls to 'IconFont' to just 'Icon'
Author
chad
Revisions
D15125: Convert all calls to 'IconFont' to just 'Icon'
Browse Repository
Passed
No Audits

Jan 13 2016

f24318f3086a Make "profile menu" configuration mostly work
Author
epriestley
Revisions
D15010: Make "profile menu" configuration mostly work
Browse Repository
Passed
No Audits

Jan 11 2016

add8333b98cb Improve behavior of "owner" transaction in "maniphest.edit" endpoint
Author
epriestley
Revisions
D14992: Improve behavior of "owner" transaction in "maniphest.edit" endpoint
Browse Repository
Passed
No Audits

Dec 29 2015

70053beeed60 Smooth out milestone creation workflow
Author
epriestley
Revisions
D14909: Smooth out milestone creation workflow
Browse Repository
Passed
No Audits

Dec 28 2015

e0a97c88dbec Provide phame.post.edit Conduit API method
Author
epriestley
Revisions
D14902: Provide phame.post.edit Conduit API method
Browse Repository
Passed
No Audits

Dec 27 2015

aa2089ba6804 Support field previews in EditEngine
Author
epriestley
Revisions
D14887: Support field previews in EditEngine
Browse Repository
Passed
No Audits

Dec 18 2015

5cb0de1efc31 Restore "Create" transactions
Author
epriestley
Revisions
D14820: Restore "Create" transactions
Browse Repository
Passed
No Audits

Dec 17 2015

a3bdce96806d Indent multiple items from the same application in Quick Create menu
Author
epriestley
Revisions
D14815: Indent multiple items from the same application in Quick Create menu
Browse Repository
Failed
No Audits