Diffusion Phabricator (master) History

phabricator/src/applications/transactions
master

Dec 20 2018

937e88c399ab Remove obsolete, no-op implementations of "willRenderTimeline()"
Author
epriestley
Revisions
D19919: Remove obsolete, no-op implementations of "willRenderTimeline()"
Browse Repository
Passed
No Audits

6c43d1d52cbd Remove "willRenderTimeline()" from ApplicationTransactionInterface
Author
epriestley
Revisions
D19918: Remove "willRenderTimeline()" from ApplicationTransactionInterface
Browse Repository
Passed
No Audits

Dec 11 2018

773b4eaa9ea0 Separate "feed" and "notifications" better, allow stories to appear in…
Author
epriestley
Revisions
D19864: Separate "feed" and "notifications" better, allow stories to appear in notifications only
Browse Repository
Passed
No Audits

ba833805656e Update the "Notification Test" workflow to use more modern mechanisms
Author
epriestley
Revisions
D19861: Update the "Notification Test" workflow to use more modern mechanisms
Browse Repository
Passed
No Audits

Dec 10 2018

508df60a6217 When users mark their own inline comments as "Done", suppress the timeline/mail…
Author
epriestley
Revisions
D19859: When users mark their own inline comments as "Done", suppress the timeline/mail stories
Browse Repository
Passed
No Audits

46feccdfcf19 Share more inline "Done" code between Differential and Diffusion
Author
epriestley
Revisions
D19858: Share more inline "Done" code between Differential and Diffusion
Browse Repository
Passed
No Audits

68b1dee1390d Replace the "Choose Subtype" radio buttons dialog with a simpler "big stuff you…
Author
epriestley
Revisions
D19855: Replace the "Choose Subtype" radio buttons dialog with a simpler "big stuff you click" sort of UI
Browse Repository
Passed
No Audits

a6632f8c188a Allow "maniphest.subtypes" to configure which options are presented by "Create…
Author
epriestley
Revisions
D19854: Allow "maniphest.subtypes" to configure which options are presented by "Create Subtask"
Browse Repository
Passed
No Audits

d1bcdaeda467 Allow the "Create Subtask" workflow to prompt for a subtype selection, and…
Author
epriestley
Revisions
D19853: Allow the "Create Subtask" workflow to prompt for a subtype selection, and prepare for customizable options
Browse Repository
Passed
No Audits

f0eefdd0b58b Replace the informal "array" subtype map with a more formal "SubtypeMap" object
Author
epriestley
Revisions
D19852: Replace the informal "array" subtype map with a more formal "SubtypeMap" object
Browse Repository
Passed
No Audits

Nov 28 2018

fd12b37d16f6 Modularize Repository transactions
Author
epriestley
Revisions
D19829: Modularize Repository transactions
Browse Repository
Passed
No Audits

2f11001f6e3c Allow "Change Subtype" to be selected from the comment action stack
Author
epriestley
Revisions
D19842: Allow "Change Subtype" to be selected from the comment action stack
Browse Repository
Passed
No Audits

Nov 16 2018

b2e91d220539 Move the "container updated" message for Buildables that build Diffs outside of…
Author
epriestley
Revisions
D19807: Move the "container updated" message for Buildables that build Diffs outside of the transaction
Browse Repository
Passed
No Audits

44c32839a68c When you "Request Review" of a draft revision, change the button text from…
Author
epriestley
Revisions
D19810: When you "Request Review" of a draft revision, change the button text from "Submit Quietly" to "Publish Revision"
Browse Repository
Passed
No Audits

Nov 15 2018

98690ee326ce Update many Phabricator queries for new %Q query semantics
Author
epriestley
Revisions
D19789: Update many Phabricator queries for new %Q query semantics
Browse Repository
Passed
No Audits

Oct 11 2018

8bffc9ea0efe In "bin/bulk export", require "--output <path>" by default
Author
epriestley
Revisions
D19744: In "bin/bulk export", require "--output <path>" by default
Browse Repository
Passed
No Audits

4f557ff075ad When using "bin/bulk export --overwrite", actually overwrite the file
Author
epriestley
Revisions
D19739: When using "bin/bulk export --overwrite", actually overwrite the file
Browse Repository
Passed
No Audits

Oct 10 2018

4928c34d00c2 Allow "bin/bulk export" to merge multiple queries and accept more flexible flags
Author
epriestley
Revisions
D19738: Allow "bin/bulk export" to merge multiple queries and accept more flexible flags
Browse Repository
Passed
No Audits

Sep 19 2018

3244324cb1ab Fix comment box borders in timelines after Phriction commenting
Author
epriestley
Revisions
D19684: Fix comment box borders in timelines after Phriction commenting
Browse Repository
Passed
No Audits

Sep 12 2018

e19c555913b1 Support (basic) commenting on Phriction documents
Author
epriestley
Revisions
D19660: Support (basic) commenting on Phriction documents
Browse Repository
Passed
No Audits

f5e90a363e7a When a user takes actions while in a high security session, note it on the…
Author
epriestley
Revisions
D19665: When a user takes actions while in a high security session, note it on the resulting transactions
Browse Repository
Passed
No Audits

Sep 11 2018

185e72c881cf Add aural section headers for "Event Timeline", "Add Comment", and "Comment…
Author
epriestley
Revisions
D19654: Add aural section headers for "Event Timeline", "Add Comment", and "Comment Preview"
Browse Repository
Passed
No Audits

Aug 28 2018

fd0da4c41f82 Rename "PHUIDocumentViewPro" to "PHUIDocumentView"
Author
epriestley
Revisions
D19616: Rename "PHUIDocumentViewPro" to "PHUIDocumentView"
Browse Repository
Passed
No Audits

Aug 27 2018

cd8b5b82c860 Stop requiring CAN_EDIT to reach the TransactionEditor via "*.edit" in…
Author
epriestley
Revisions
D19608: Stop requiring CAN_EDIT to reach the TransactionEditor via "*.edit" in EditEngine
Browse Repository
Passed
No Audits

Aug 25 2018

4d89afcc6149 Remove requireCapabilities() from ApplicationTransactionEditor and require…
Author
epriestley
Revisions
D19586: Remove requireCapabilities() from ApplicationTransactionEditor and require CAN_EDIT by default
Browse Repository
Passed
No Audits

Aug 17 2018

75a5dd8d8cc0 Add more accessibility labels for screen readers
Author
epriestley
Revisions
D19595: Add more accessibility labels for screen readers
Browse Repository
Passed
No Audits

438edde03150 Add some missing aural button labels for accessibility
Author
epriestley
Revisions
D19594: Add some missing aural button labels for accessibility
Browse Repository
Passed
No Audits

Aug 16 2018

7e29ec2e2a66 Move the "Can Lock Projects" check from requireCapabilities() to transaction…
Author
epriestley
Revisions
D19585: Move the "Can Lock Projects" check from requireCapabilities() to transaction validation
Browse Repository
Passed
No Audits

Aug 3 2018

5839a54b604d Raise a tailored error when calling "transaction.search" with empty "phids"…
Author
epriestley
Revisions
D19562: Raise a tailored error when calling "transaction.search" with empty "phids" constraint
Browse Repository
Passed
No Audits

Jul 27 2018

a5d3aea67c5b Carry the "silent" transaction flag through inverse edge edits
Author
epriestley
Revisions
D19543: Carry the "silent" transaction flag through inverse edge edits
Browse Repository
Passed
No Audits

Jun 26 2018

f94cee862888 Fix querying for transactions over "transaction.search" when the object does…
Author
epriestley
Revisions
D19507: Fix querying for transactions over "transaction.search" when the object does not support comments
Browse Repository
Passed
No Audits

Jun 23 2018

cac3dc4983c3 Give "create" transactions a readable type in "transaction.search"
Author
epriestley
Revisions
D19505: Give "create" transactions a readable type in "transaction.search"
Browse Repository
Passed
No Audits

14e911a0d8c0 Index only the first 1,000 comments on any object
Author
epriestley
Revisions
D19503: Index only the first 1,000 comments on any object
Browse Repository
Passed
No Audits

Jun 12 2018

c5b13a6be3b7 Allow object subtypes to be changed via bulk editor
Author
epriestley
Revisions
D19490: Allow object subtypes to be changed via bulk editor
Browse Repository
Passed
No Audits

May 8 2018

304c6a45976d Improve UI and documentation for "Ignore Attributes" in Owners slightly
Author
epriestley
Revisions
D19433: Improve UI and documentation for "Ignore Attributes" in Owners slightly
Browse Repository
Passed
No Audits

fddb506e987f Don't render the Maniphest edit form bottom-of-page preview panel if…
Author
epriestley
Revisions
D19432: Don't render the Maniphest edit form bottom-of-page preview panel if "Description" is locked or hidden
Browse Repository
Passed
No Audits

Apr 16 2018

f9b3673fbbe1 When mail (like "!history" mail) has multiple comments, label them separately
Author
epriestley
Revisions
D19373: When mail (like "!history" mail) has multiple comments, label them separately
Browse Repository
Passed
No Audits

25965260c431 Add a rough "!history" email command to get an entire object history via email
Author
epriestley
Revisions
D19372: Add a rough "!history" email command to get an entire object history via email
Browse Repository
Passed
No Audits

Apr 11 2018

e502df509d5f Implement "almanac.interface.search" and "almanac.interface.edit"
Author
epriestley
Revisions
D19338: Implement "almanac.interface.search" and "almanac.interface.edit"
Browse Repository
Passed
No Audits

Apr 3 2018

592d72e00688 Move PhabricatorModularTransaction slightly closer to having "final" methods…
Author
epriestley
Revisions
D19291: Move PhabricatorModularTransaction slightly closer to having "final" methods again
Browse Repository
Passed
No Audits

ada0c9126cf0 Provide a modular buildable transaction in Diffusion
Author
epriestley
Revisions
D19280: Provide a modular buildable transaction in Diffusion
Browse Repository
Passed
No Audits

Mar 28 2018

b586ee065a75 Stop evaluating Herald rules when writing "someone mentioned this somewhere…
Author
epriestley
Revisions
D19263: Stop evaluating Herald rules when writing "someone mentioned this somewhere else." transactions
Browse Repository
Passed
No Audits

Mar 21 2018

6ed123e0801a Propagate "unexpandable" PHIDs to feed notification recipient expansion
Author
epriestley
Revisions
D19244: Propagate "unexpandable" PHIDs to feed notification recipient expansion
Browse Repository
Passed
No Audits

Mar 14 2018

ce6e020d5ddb Don't make an expensive, unused call to test if a viewer can reassign a task
Author
epriestley
Revisions
D19225: Don't make an expensive, unused call to test if a viewer can reassign a task
Browse Repository
Passed
No Audits

Mar 13 2018

df8d4dff679b Raise a warning when mentioning a user in a comment on a draft revision
Author
epriestley
Revisions
D19210: Raise a warning when mentioning a user in a comment on a draft revision
Browse Repository
Passed
No Audits

Mar 7 2018

28854ae8121b Return a integer JSON type from "*.edit" endpoints for the object ID
Author
epriestley
Revisions
D19186: Return a integer JSON type from "*.edit" endpoints for the object ID
Browse Repository
Passed
No Audits

e57dbcda336a Hide "abraham landed Dxyz irresponsibly" stories from feed
Author
epriestley
Revisions
D19179: Hide "abraham landed Dxyz irresponsibly" stories from feed
Browse Repository
Passed
No Audits

Feb 19 2018

e3a1a32444d0 Extract count/point data from tasks in Fact engines
Author
epriestley
Revisions
D19120: Extract count/point data from tasks in Fact engines
Browse Repository
Passed
No Audits

Feb 16 2018

bfdc9411f705 Provide context objects for remarkup mail rendering, fixing Phriction relative…
Author
epriestley
Revisions
D19105: Provide context objects for remarkup mail rendering, fixing Phriction relative URIs in initial email
Browse Repository
Passed
No Audits

Feb 12 2018

894e9dd852fa Update a handful of missed HarbormasterBuildableStatus constants
Author
epriestley
Revisions
D19068: Update a handful of missed HarbormasterBuildableStatus constants
Browse Repository
Passed
No Audits

66f20595e4d2 Start buildables in "PREPARING", move them to "BUILDING" after builds queue
Author
epriestley
Revisions
D19065: Start buildables in "PREPARING", move them to "BUILDING" after builds queue
Browse Repository
Passed
No Audits

f939a2b12ea3 Make Harbormaster buildable status more of a nice flexible map and less of a…
Author
epriestley
Revisions
D19064: Make Harbormaster buildable status more of a nice flexible map and less of a bunch of switch statements
Browse Repository
Passed
No Audits

Feb 11 2018

5e6e9fcc5652 When purging drafts after a transaction edit, purge all drafts
Author
epriestley
Revisions
D19060: When purging drafts after a transaction edit, purge all drafts
Browse Repository
Passed
No Audits

653bc0fa019f Read lock all transaction edits
Author
epriestley
Revisions
D19059: Read lock all transaction edits
Browse Repository
Passed
No Audits

Feb 9 2018

64177cb16e77 Document how webhooks work
Author
epriestley
Revisions
D19050: Document how webhooks work
Browse Repository
Failed
No Audits

98c701ffc55f Add a "Call webhooks" action to Herald
Author
epriestley
Revisions
D19049: Add a "Call webhooks" action to Herald
Browse Repository
Failed
No Audits

41d28abfcc46 Trigger all "Firehose" webhooks on all transactional edits
Author
epriestley
Revisions
D19048: Trigger all "Firehose" webhooks on all transactional edits
Browse Repository
Failed
No Audits

4887c6aa803d Allow "transaction.search" to be constrained by PHIDs
Author
epriestley
Revisions
D19047: Allow "transaction.search" to be constrained by PHIDs
Browse Repository
Failed
No Audits

Feb 8 2018

ab04d2179bf1 Add "Mute/Unmute" for subscribable objects
Author
epriestley
Revisions
D19033: Add "Mute/Unmute" for subscribable objects
Browse Repository
Passed
No Audits

bca9c08953bd Add an "Acting user" field to Herald
Author
epriestley
Revisions
D19031: Add an "Acting user" field to Herald
Browse Repository
Passed
No Audits

1cd3a593784a When users resign from revisions, stop expanding projects/packages to include…
Author
epriestley
Revisions
D19021: When users resign from revisions, stop expanding projects/packages to include them
Browse Repository
Passed
No Audits

f214abb63f9d When a change removes recipients from an object, send them one last email
Author
epriestley
Revisions
D19019: When a change removes recipients from an object, send them one last email
Browse Repository
Passed
No Audits

994d2e8e1563 Use "cluster.mailers" if it is configured
Author
epriestley
Revisions
D19005: Use "cluster.mailers" if it is configured
Browse Repository
Passed
No Audits

Feb 6 2018

56bf0690804f Try running Herald when performing inverse edge edits
Author
epriestley
Revisions
D18999: Try running Herald when performing inverse edge edits
Browse Repository
Passed
No Audits

1bf64e5cbcf4 Add Differential and Herald mail stamps and some refinements
Author
epriestley
Revisions
D18997: Add Differential and Herald mail stamps and some refinements
Browse Repository
Passed
No Audits

3131e733a85c Add Editor-based mail stamps: actor, via, silent, encrypted, new, mention, self…
Author
epriestley
Revisions
D18995: Add Editor-based mail stamps: actor, via, silent, encrypted, new, mention, self-actor, self-mention
Browse Repository
Passed
No Audits

c3f95bc410a3 Add basic support for mail "stamps" to improve client mail routing
Author
epriestley
Revisions
D18991: Add basic support for mail "stamps" to improve client mail routing
Browse Repository
Passed
No Audits

Feb 2 2018

cbe4e68c0722 Add a Herald action to trigger "Must Encrypt" for mail
Author
epriestley
Revisions
D18984: Add a Herald action to trigger "Must Encrypt" for mail
Browse Repository
Passed
No Audits

032f5b22941f Allow revisions to revert commits and one another, and commits to revert…
Author
epriestley
Revisions
D18978: Allow revisions to revert commits and one another, and commits to revert revisions
Browse Repository
Passed
No Audits

Jan 31 2018

6d5f265a5795 Accept `null` via `conduit.edit` to unassign a task
Author
epriestley
Revisions
D18976: Accept `null` via `conduit.edit` to unassign a task
Browse Repository
Passed
No Audits

c9df8f77c8b5 Fix transcription of single-value bulk edit fields ("Assign to")
Author
epriestley
Revisions
D18975: Fix transcription of single-value bulk edit fields ("Assign to")
Browse Repository
Passed
No Audits

Jan 30 2018

b27fd05eef0a Add a `bin/bulk export` CLI tool to make debugging and profiling large exports…
Author
epriestley
Revisions
D18965: Add a `bin/bulk export` CLI tool to make debugging and profiling large exports easier
Browse Repository
Passed
No Audits

Jan 29 2018

e5639a8ed90f Write edge transactions in a more compact way
Author
epriestley
Revisions
D18947: Write edge transactions in a more compact way
Browse Repository
Passed
No Audits

de7f836f03e6 Wrap edge transaction readers in a translation layer
Author
epriestley
Revisions
D18946: Wrap edge transaction readers in a translation layer
Browse Repository
Passed
No Audits

Jan 26 2018

fd66ab55791e Always use the same set of transactions to generate mail and mail tags
Author
epriestley
Revisions
D18941: Always use the same set of transactions to generate mail and mail tags
Browse Repository
Passed
No Audits

Jan 25 2018

1059fae6c9b6 Set an explicit default value for the bulk action control
Author
epriestley
Revisions
D18923: Set an explicit default value for the bulk action control
Browse Repository
Passed
No Audits

Jan 22 2018

a9d7b4f0ff75 Support bulk edit of "points" for Maniphest tasks
Author
epriestley
Revisions
D18889: Support bulk edit of "points" for Maniphest tasks
Browse Repository
Passed
No Audits

d9b6513a2141 Respect tokenizer limits in the bulk editor
Author
epriestley
Revisions
D18888: Respect tokenizer limits in the bulk editor
Browse Repository
Passed
No Audits

Jan 19 2018

3038d564a6d8 Allow bulk edits to be made silently if you have CLI access
Author
epriestley
Revisions
D18883: Allow bulk edits to be made silently if you have CLI access
Browse Repository
Passed
No Audits

8b12fa6d6ed0 Prepare TransactionEditor for silent transactions via bulk edit
Author
epriestley
Revisions
D18882: Prepare TransactionEditor for silent transactions via bulk edit
Browse Repository
Passed
No Audits

8a5def8e0ae1 Remove legacy transaction editor "getDisableEmail()" method
Author
epriestley
Revisions
D18881: Remove legacy transaction editor "getDisableEmail()" method
Browse Repository
Passed
No Audits

7a431813373a Organize bulk edit actions into nice groups
Author
epriestley
Revisions
D18880: Organize bulk edit actions into nice groups
Browse Repository
Passed
No Audits

f8113aecdcbe Make bulk edit <select /> fields a little more natrual and set options for…
Author
epriestley
Revisions
D18878: Make bulk edit <select /> fields a little more natrual and set options for subtype transactions
Browse Repository
Passed
No Audits

a26cf20dd128 Fix a bug with setting custom PHID list field values via Conduit and prepare…
Author
epriestley
Revisions
D18876: Fix a bug with setting custom PHID list field values via Conduit and prepare for bulk edits
Browse Repository
Passed
No Audits

1e51f1d0dc25 Reuse more transaction construction code in bulk editor
Author
epriestley
Revisions
D18875: Reuse more transaction construction code in bulk editor
Browse Repository
Passed
No Audits

91a78db99b33 Support "Assign To" in Maniphest bulk editor
Author
epriestley
Revisions
D18874: Support "Assign To" in Maniphest bulk editor
Browse Repository
Passed
No Audits

0cad6021b6f4 Restore "Tags" and "Subscribers" edit capabilities to Maniphest bulk editor
Author
epriestley
Revisions
D18868: Restore "Tags" and "Subscribers" edit capabilities to Maniphest bulk editor
Browse Repository
Passed
No Audits

687fada5af43 Restore bulk edit support for remarkup fields (description, add comment)
Author
epriestley
Revisions
D18867: Restore bulk edit support for remarkup fields (description, add comment)
Browse Repository
Passed
No Audits

bf1ac701c37c Support "select" types in bulk editor (status, priority)
Author
epriestley
Revisions
D18866: Support "select" types in bulk editor (status, priority)
Browse Repository
Passed
No Audits

09e71a408235 Define bulk edits in terms of EditEngine, not hard-coded ad-hoc definitions
Author
epriestley
Revisions
D18863: Define bulk edits in terms of EditEngine, not hard-coded ad-hoc definitions
Browse Repository
Passed
No Audits

6ef45d824593 Provide a generic transaction-oriented bulk job worker
Author
epriestley
Revisions
D18862: Provide a generic transaction-oriented bulk job worker
Browse Repository
Passed
No Audits

7f91c8c4acbb Rebuild the bulk editor on SearchEngine
Author
epriestley
Revisions
D18806: Rebuild the bulk editor on SearchEngine
Browse Repository
Passed
No Audits

Jan 4 2018

6d9776fa8963 Give EditEngine a Conduit-specific initialization pathway for objects
Author
epriestley
Revisions
D18847: Give EditEngine a Conduit-specific initialization pathway for objects
Browse Repository
Passed
No Audits

129e3a120849 Fix a minor/harmless race with feed publishers in certain draft states
Author
epriestley
Revisions
D18852: Fix a minor/harmless race with feed publishers in certain draft states
Browse Repository
Passed
No Audits

Dec 8 2017

60e5c0ec1b3e Add drydock.blueprint.edit Conduit method
Author
timhirsh
Revisions
D18822: Add drydock.blueprint.edit Conduit method
Browse Repository
Passed
No Audits

Dec 5 2017

6d3baa92f908 Execute Herald again after promoting revisions out of the "Draft" state
Author
epriestley
Revisions
D18819: Execute Herald again after promoting revisions out of the "Draft" state
Browse Repository
Passed
No Audits

Oct 9 2017

9bd6a3705559 Fix spelling
Author
0
Revisions
D18693: Fix spelling
Browse Repository
Failed
No Audits

Oct 2 2017

cd14194a3297 Fix transaction queries using withComments() for transactions with no comments
Author
epriestley
Revisions
D18667: Fix transaction queries using withComments() for transactions with no comments
Browse Repository
Passed
No Audits

Sep 28 2017

b75a4151c899 Allow the fulltext index to select only transactions with comments
Author
epriestley
Revisions
D18660: Allow the fulltext index to select only transactions with comments
Browse Repository
Passed
No Audits

Sep 21 2017

36df39761ea5 Create revisions into "Draft", publish them when builds finish
Author
epriestley
Revisions
D18628: Create revisions into "Draft", publish them when builds finish
Browse Repository
Passed
No Audits