Diffusion Phabricator (master) History

phabricator/src/applications/diffusion/controller
master

Mar 17 2021

db9191f9a8d5 Correct minor "jump to symbol" behavior in Differential
Author
epriestley
Revisions
D21641: Correct minor "jump to symbol" behavior in Differential
Browse Repository
Passed
No Audits

Mar 15 2021

6d33ba7dc401 Move Diffusion to "withPaths()" for "Recent Open Revisions", and remove…
Author
epriestley
Revisions
D21620: Move Diffusion to "withPaths()" for "Recent Open Revisions", and remove "withPath()" from DifferentialRevisionQuery
Browse Repository
Passed
No Audits

e730f55e8857 Retitle "Recently Open Revisions" panel to "Recent Open Revisions"
Author
epriestley
Revisions
D21612: Retitle "Recently Open Revisions" panel to "Recent Open Revisions"
Browse Repository
Passed
No Audits

Mar 10 2021

ac2f5a10469a Modernize and clean up "PhabricatorAuditStatusConstants"
Author
epriestley
Revisions
D21599: Modernize and clean up "PhabricatorAuditStatusConstants"
Browse Repository
Passed
No Audits

2636d84d0c24 Remove very old Audit status constants and AuditRequest data
Author
epriestley
Revisions
D21598: Remove very old Audit status constants and AuditRequest data
Browse Repository
Passed
No Audits

Jan 27 2021

da7d92dd0a4e Catch more HTTP VCS errors and convert them into VCS repsonses
Author
epriestley
Revisions
D21525: Catch more HTTP VCS errors and convert them into VCS repsonses
Browse Repository
Passed
No Audits

32c82a53deb4 After loading the effective Viewer during a VCS request, flag them for inline…
Author
epriestley
Revisions
D21524: After loading the effective Viewer during a VCS request, flag them for inline cache generation
Browse Repository
Passed
No Audits

Oct 30 2020

c04147328fa3 Fix isValidGitShallowCloneResponse
Author
epriestley
Revisions
D21484: Fix isValidGitShallowCloneResponse
Browse Repository
Passed
Audited

Sep 16 2020

e454c3dafe99 Wrap all direct access to author/committer properties on "CommitData"
Author
epriestley
Revisions
D21448: Wrap all direct access to author/committer properties on "CommitData"
Browse Repository
Passed
No Audits

Aug 12 2020

2b0632b442a2 Remove "DiffusionHistoryTableView" and "DiffusionHistoryView"
Author
epriestley
Revisions
D21414: Remove "DiffusionHistoryTableView" and "DiffusionHistoryView"
Browse Repository
Passed
No Audits

7087c0439a7f Move the view of merged changes to "DiffusionCommitGraphView"
Author
epriestley
Revisions
D21413: Move the view of merged changes to "DiffusionCommitGraphView"
Browse Repository
Passed
No Audits

cd09ba5e19d7 Replace "DiffusionCommitListView" with "DiffusionCommitGraphView"
Author
epriestley
Revisions
D21412: Replace "DiffusionCommitListView" with "DiffusionCommitGraphView"
Browse Repository
Passed
No Audits

46695c76ebfe Introduce "DiffusionCommitGraphView", which unifies "HistoryListView" and…
Author
epriestley
Revisions
D21410: Introduce "DiffusionCommitGraphView", which unifies "HistoryListView" and "HistoryTableView"
Browse Repository
Failed
No Audits

c6de7c66a3c6 Remove the "Graph" view as a dedicated repository view
Author
epriestley
Revisions
D21409: Remove the "Graph" view as a dedicated repository view
Browse Repository
Passed
No Audits

9afc5c628757 Remove "Recent Commits" from repository landing page
Author
epriestley
Revisions
D21408: Remove "Recent Commits" from repository landing page
Browse Repository
Passed
No Audits

60e9f641907a Remove the "authored" subheader from commits
Author
epriestley
Revisions
D21406: Remove the "authored" subheader from commits
Browse Repository
Passed
No Audits

7fd6bf26a949 Modernize "Author" and "Committer" rendering for commits
Author
epriestley
Revisions
D21405: Modernize "Author" and "Committer" rendering for commits
Browse Repository
Passed
No Audits

81e4e5b7f9c9 Remove construction of "author" information from "LastModified" payload in…
Author
epriestley
Revisions
D21404: Remove construction of "author" information from "LastModified" payload in Diffusion
Browse Repository
Passed
No Audits

May 8 2020

fa2d30ee3698 Lift inline comment draft behaviors to "InlineController"
Author
epriestley
Revisions
D21235: Lift inline comment draft behaviors to "InlineController"
Browse Repository
Passed
No Audits

May 7 2020

983d77848b4c Move the "Inline List" view to "DiffInlineCommentQuery"
Author
epriestley
Revisions
D21232: Move the "Inline List" view to "DiffInlineCommentQuery"
Browse Repository
Passed
No Audits

af5b94b23473 Lift most "InlineController" querying to the base class
Author
epriestley
Revisions
D21231: Lift most "InlineController" querying to the base class
Browse Repository
Passed
No Audits

949b9163d006 Replace remaining pseudo-query methods on AuditInlineComment
Author
epriestley
Revisions
D21230: Replace remaining pseudo-query methods on AuditInlineComment
Browse Repository
Passed
No Audits

d0593a5a788e Replace "loadDraftAndPublishedComments()" with a Query
Author
epriestley
Revisions
D21228: Replace "loadDraftAndPublishedComments()" with a Query
Browse Repository
Passed
No Audits

May 6 2020

0067f1a521a0 Remove the obsolete "DiffusionInlineCommentPreviewController"
Author
epriestley
Revisions
D21224: Remove the obsolete "DiffusionInlineCommentPreviewController"
Browse Repository
Passed
No Audits

May 4 2020

b48a22bf50a3 Make "editing" state persistent for inline comments
Author
epriestley
Revisions
D21186: Make "editing" state persistent for inline comments
Browse Repository
Passed
No Audits

Apr 27 2020

604811bfc554 Fix a Diffusion issue where commits that do not show changesets would…
Author
epriestley
Revisions
D21175: Fix a Diffusion issue where commits that do not show changesets would incorrectly try to render changesets
Browse Repository
Passed
No Audits

Apr 22 2020

60de1506fe3b Make "hidden" changesets sticky, and show hidden state in the filetree
Author
epriestley
Revisions
D21158: Make "hidden" changesets sticky, and show hidden state in the filetree
Browse Repository
Passed
No Audits

12eddb18fb78 Entirely replace the old filetree UI with the "flank" UI
Author
epriestley
Revisions
D21154: Entirely replace the old filetree UI with the "flank" UI
Browse Repository
Passed
No Audits

Apr 19 2020

ef69c7969f58 Restore editor behavior to Diffusion and support "\" shortcut
Author
epriestley
Revisions
D21149: Restore editor behavior to Diffusion and support "\" shortcut
Browse Repository
Passed
No Audits

3984c14260d3 Tokenize external editor links so they can be safely materialized on the client
Author
epriestley
Revisions
D21143: Tokenize external editor links so they can be safely materialized on the client
Browse Repository
Passed
No Audits

c3c55d82ae9d Make "renderer", "engine", and "encoding" sticky across reloads in Differential…
Author
epriestley
Revisions
D21138: Make "renderer", "engine", and "encoding" sticky across reloads in Differential and Diffusion
Browse Repository
Passed
No Audits

8aac55cc57cb Make "Highlight As..." sticky across reloads in Diffusion and Differential
Author
epriestley
Revisions
D21137: Make "Highlight As..." sticky across reloads in Diffusion and Differential
Browse Repository
Passed
No Audits

Feb 4 2020

26c2a1ba68b1 Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView"
Author
epriestley
Revisions
D20933: Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView"
Browse Repository
Passed
No Audits

Nov 19 2019

a2b2c391a1f1 Distinguish between "Assigned" and "Effective" identity PHIDs more clearly and…
Author
epriestley
Revisions
D20908: Distinguish between "Assigned" and "Effective" identity PHIDs more clearly and consistently
Browse Repository
Passed
No Audits

df0f5c6cee03 Make repository identity email address association case-insensitive
Author
epriestley
Revisions
D20907: Make repository identity email address association case-insensitive
Browse Repository
Passed
No Audits

Aug 29 2019

3c26e384872a Provide a simple read-only maintenance mode for repositories
Author
epriestley
Revisions
D20748: Provide a simple read-only maintenance mode for repositories
Browse Repository
Passed
No Audits

Aug 2 2019

1fe631116771 Modernize user and repository "delete" workflows and improve documentation
Author
epriestley
Revisions
D20694: Modernize user and repository "delete" workflows and improve documentation
Browse Repository
Passed
No Audits

May 16 2019

c5ecc388a212 Make branch status more clear on Diffusion branches view
Author
epriestley
Revisions
D20493: Make branch status more clear on Diffusion branches view
Browse Repository
Passed
No Audits

Apr 25 2019

0fab41ff3c07 Show "hold reasons" on commit page, not on "Edit" page
Author
epriestley
Revisions
D20466: Show "hold reasons" on commit page, not on "Edit" page
Browse Repository
Passed
No Audits

Apr 24 2019

8f43c773b832 Remove nearly all remaining references to "Autoclose"
Author
epriestley
Revisions
D20465: Remove nearly all remaining references to "Autoclose"
Browse Repository
Passed
No Audits

7e8dc0742bdc Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()"
Author
epriestley
Revisions
D20458: Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()"
Browse Repository
Passed
No Audits

fc92cf438225 Move BlameController away from ancient "TABLE_COMMIT"
Author
epriestley
Revisions
D20457: Move BlameController away from ancient "TABLE_COMMIT"
Browse Repository
Passed
No Audits

Apr 18 2019

7a4ef2bad876 Move the repository "Publishing" option to the "Basics" panel in repository…
Author
epriestley
Revisions
D20425: Move the repository "Publishing" option to the "Basics" panel in repository management
Browse Repository
Passed
No Audits

1cda1402c7c2 Do not publish/notify about commits which are not reachable from any…
Author
epriestley
Revisions
D20419: Do not publish/notify about commits which are not reachable from any "Autoclose" ref
Browse Repository
Passed
No Audits

Mar 25 2019

6182193cf55a Give the "Code" tab in Diffusion more consistent (path-retaining) behavior
Author
epriestley
Revisions
D20323: Give the "Code" tab in Diffusion more consistent (path-retaining) behavior
Browse Repository
Passed
No Audits

Mar 7 2019

9913754a2aa2 Improve utilization of "AuthTemporaryToken" table keys in LFS authentication…
Author
epriestley
Revisions
D20261: Improve utilization of "AuthTemporaryToken" table keys in LFS authentication queries
Browse Repository
Passed
No Audits

Mar 1 2019

4cc556b576ab Clean up a PhutilURI "alter()" callsite in Diffusion blame
Author
epriestley
Revisions
D20222: Clean up a PhutilURI "alter()" callsite in Diffusion blame
Browse Repository
Passed
No Audits

Feb 19 2019

5310f1cdd90e Remove all whitespace options/configuration everywhere
Author
epriestley
Revisions
D20185: Remove all whitespace options/configuration everywhere
Browse Repository
Passed
No Audits

Feb 12 2019

1fd69f788cee Replace "getQueryParams()" callsites in Phabricator
Author
epriestley
Revisions
D20141: Replace "getQueryParams()" callsites in Phabricator
Browse Repository
Passed
No Audits

Feb 7 2019

8fab8d8a18ef Prepare owners package audit rules to become more flexible
Author
epriestley
Revisions
D20124: Prepare owners package audit rules to become more flexible
Browse Repository
Passed
No Audits

Jan 31 2019

1767b80654fe Replace manual query string construction with "phutil_build_http_querystring()"
Author
epriestley
Revisions
D20053: Replace manual query string construction with "phutil_build_http_querystring()"
Browse Repository
Passed
No Audits

Jan 4 2019

e48c36697ad4 Make blame UI recover gracefully if Identities haven't been built yet for a…
Author
epriestley
Revisions
D19958: Make blame UI recover gracefully if Identities haven't been built yet for a commit
Browse Repository
Passed
No Audits

Dec 20 2018

6c43d1d52cbd Remove "willRenderTimeline()" from ApplicationTransactionInterface
Author
epriestley
Revisions
D19918: Remove "willRenderTimeline()" from ApplicationTransactionInterface
Browse Repository
Passed
No Audits

Dec 10 2018

b88a87c43a28 Address a transaction issue with some audit actions not applying correctly
Author
epriestley
Revisions
D19845: Address a transaction issue with some audit actions not applying correctly
Browse Repository
Passed
No Audits

Nov 28 2018

fd12b37d16f6 Modularize Repository transactions
Author
epriestley
Revisions
D19829: Modularize Repository transactions
Browse Repository
Passed
No Audits

c25d2a399d68 Separate the repository management UI into sections
Author
epriestley
Revisions
D19827: Separate the repository management UI into sections
Browse Repository
Passed
No Audits

Nov 27 2018

bb369c7b711f Convert the "Repository Management" UI to a full-width, Phortune-style UI
Author
epriestley
Revisions
D19826: Convert the "Repository Management" UI to a full-width, Phortune-style UI
Browse Repository
Passed
No Audits

Nov 16 2018

933462b4873b Continue cleaning up queries in the wake of changes to "%Q"
Author
epriestley
Revisions
D19814: Continue cleaning up queries in the wake of changes to "%Q"
Browse Repository
Passed
No Audits

Nov 10 2018

315d857a8ad6 Add a basic web UI for intracluster sync logs
Author
epriestley
Revisions
D19799: Add a basic web UI for intracluster sync logs
Browse Repository
Passed
No Audits

Sep 26 2018

8065433ee8dc Migrate DiffusionBlameController to use repo identities
Author
amckinley
Revisions
D19587: Migrate DiffusionBlameController to use repo identities
Browse Repository
Passed
No Audits

Sep 10 2018

bae8a951143a Continue replacing Commit/Audit status checks with object-based checks
Author
epriestley
Revisions
D19647: Continue replacing Commit/Audit status checks with object-based checks
Browse Repository
Passed
No Audits

Sep 7 2018

16a6fc8341ea Allow reviewers to mark their own inlines as "Done" before they submit them
Author
epriestley
Revisions
D19634: Allow reviewers to mark their own inlines as "Done" before they submit them
Browse Repository
Passed
No Audits

Sep 6 2018

650e74933abb Update some inline comment logic to use more modern "Viewer"-oriented…
Author
epriestley
Revisions
D19633: Update some inline comment logic to use more modern "Viewer"-oriented calls/variables
Browse Repository
Passed
No Audits

Aug 17 2018

5c4c593af325 Update DiffusionLastModifiedController to use identities
Author
amckinley
Revisions
D19580: Update DiffusionLastModifiedController to use identities
Browse Repository
Passed
No Audits

Aug 13 2018

3b05e920e009 Start changing DiffusionCommitController to use identities
Author
amckinley
Revisions
D19492: Start changing DiffusionCommitController to use identities
Browse Repository
Passed
No Audits

Jul 23 2018

dce6dd5d02bb Add an explicit "null" to a missed `diffusion.branchquery` callsite to fix…
Author
epriestley
Revisions
D19532: Add an explicit "null" to a missed `diffusion.branchquery` callsite to fix Diffusion "Branches" page
Browse Repository
Passed
No Audits

Jun 23 2018

8ab8c390b785 If "branch" is provided to "diffusion.branchquery", use it as the "<pattern>"…
Author
epriestley
Revisions
D19499: If "branch" is provided to "diffusion.branchquery", use it as the "<pattern>" argument to "git branch --contains ..."
Browse Repository
Passed
No Audits

May 31 2018

fe5fde591026 Assign RepositoryIdentity objects to commits
Author
amckinley
Revisions
D19443: Assign RepositoryIdentity objects to commits
Browse Repository
Passed
No Audits

f191a66490b1 Add controllers/search/edit engine functionality to RepositoryIdentity
Author
amckinley
Revisions
D19429: Add controllers/search/edit engine functionality to RepositoryIdentity
Browse Repository
Passed
No Audits

Apr 20 2018

95e179d9a4f3 Fix a fatal in the document engine blame view with files that blame to the…
Author
epriestley
Revisions
D19391: Fix a fatal in the document engine blame view with files that blame to the initial commit
Browse Repository
Passed
No Audits

Apr 17 2018

665529ab60a1 Restore coverage reporting to Diffusion browse UI
Author
epriestley
Revisions
D19378: Restore coverage reporting to Diffusion browse UI
Browse Repository
Passed
No Audits

Apr 12 2018

6556536d0615 Allow repository cluster bindings to be marked as not "writable", making them…
Author
epriestley
Revisions
D19357: Allow repository cluster bindings to be marked as not "writable", making them read-only
Browse Repository
Passed
No Audits

7c7e6d555b3f Give getAlmanacServiceURI() an "options" parameter to prepare for read-only…
Author
epriestley
Revisions
D19356: Give getAlmanacServiceURI() an "options" parameter to prepare for read-only devices
Browse Repository
Passed
No Audits

Apr 9 2018

472bc3d90a59 Colorize lines in blame under DocumentEngine, to show relative age of changes
Author
epriestley
Revisions
D19314: Colorize lines in blame under DocumentEngine, to show relative age of changes
Browse Repository
Passed
No Audits

eca7dc25f20b Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly
Author
epriestley
Revisions
D19311: Use javelin_tag(), not phutil_tag(), to render revision blame tooltips properly
Browse Repository
Passed
No Audits

09c6d42b9599 Mostly make blame work with DocumentEngine
Author
epriestley
Revisions
D19309: Mostly make blame work with DocumentEngine
Browse Repository
Passed
No Audits

1fde4a945061 Move Diffusion browse rendering to DocumentEngine, breaking almost all features
Author
epriestley
Revisions
D19302: Move Diffusion browse rendering to DocumentEngine, breaking almost all features
Browse Repository
Passed
No Audits

7d4e25614d00 Remove the ability to disable blame in Diffusion
Author
epriestley
Revisions
D19300: Remove the ability to disable blame in Diffusion
Browse Repository
Passed
No Audits

Apr 3 2018

e40aec0210dc When a revision has more than 7 reviewers, render only the first 7 in the list…
Author
epriestley
Revisions
D19293: When a revision has more than 7 reviewers, render only the first 7 in the list view
Browse Repository
Passed
No Audits

Mar 8 2018

a4cc1373d3a2 Use a tokenizer, not a gigantic poorly-ordered "<select />", to choose…
Author
epriestley
Revisions
D19191: Use a tokenizer, not a gigantic poorly-ordered "<select />", to choose repositories in Owners
Browse Repository
Passed
No Audits

b41a0e6ddda3 Fix broken suggestion/validation for Owners paths in repositories with short…
Author
epriestley
Revisions
D19190: Fix broken suggestion/validation for Owners paths in repositories with short names
Browse Repository
Passed
No Audits

Mar 7 2018

c6a042b59acf Correct line highlighting behavior in Diffusion
Author
epriestley
Revisions
D19187: Correct line highlighting behavior in Diffusion
Browse Repository
Passed
No Audits

Mar 1 2018

ab579f251110 Never generate file download forms which point to the CDN domain, tighten "form…
Author
epriestley
Revisions
D19156: Never generate file download forms which point to the CDN domain, tighten "form-action" CSP
Browse Repository
Passed
No Audits

Feb 22 2018

4c7370a1a3b0 Make the filetree view width sticky across show/hide and reload
Author
epriestley
Revisions
D19129: Make the filetree view width sticky across show/hide and reload
Browse Repository
Passed
No Audits

Feb 8 2018

d1e273daf62f Remove completely pointless load of every repository when viewing a repository…
Author
epriestley
Revisions
D19036: Remove completely pointless load of every repository when viewing a repository URI
Browse Repository
Passed
No Audits

Jan 30 2018

1e3d1271ada0 Make push log "flags", "reject code" human readable; add crumbs to pull/push…
Author
epriestley
Revisions
D18973: Make push log "flags", "reject code" human readable; add crumbs to pull/push logs
Browse Repository
Passed
No Audits

Jan 26 2018

ad7755d9a993 Fix an issue with symbol lookup identifying path names in Diffusion
Author
epriestley
Revisions
D18940: Fix an issue with symbol lookup identifying path names in Diffusion
Browse Repository
Passed
No Audits

fdc36677ba4f Provide character position information to symbol queries
Author
epriestley
Revisions
D18939: Provide character position information to symbol queries
Browse Repository
Passed
No Audits

d606eb1c38b1 When available, pass path, line and repository hints to external symbol queries
Author
epriestley
Revisions
D18937: When available, pass path, line and repository hints to external symbol queries
Browse Repository
Passed
No Audits

Jan 23 2018

778dfff277dc Make minor correctness and display improvements to pull logs
Author
epriestley
Revisions
D18917: Make minor correctness and display improvements to pull logs
Browse Repository
Passed
No Audits

e6a9db56a96a Add a basic view for repository pull logs
Author
epriestley
Revisions
D18914: Add a basic view for repository pull logs
Browse Repository
Passed
No Audits

dd8f588ac51b Migrate VCS passwords to new shared password infrastructure
Author
epriestley
Revisions
D18898: Migrate VCS passwords to new shared password infrastructure
Browse Repository
Passed
No Audits

Jan 19 2018

86a0c7daa253 Fix a fatal in blame when the viewer can't see a revision because of a…
Author
epriestley
Revisions
D18884: Fix a fatal in blame when the viewer can't see a revision because of a permission issue
Browse Repository
Passed
No Audits

Jan 4 2018

53b25db91856 Prevent enormous changes from being pushed to repositoires by default
Author
epriestley
Revisions
D18850: Prevent enormous changes from being pushed to repositoires by default
Browse Repository
Passed
No Audits

Dec 20 2017

e411d75964e5 Fix an issue where blame could fatal for unrecognized authors
Author
epriestley
Revisions
D18833: Fix an issue where blame could fatal for unrecognized authors
Browse Repository
Passed
No Audits

Dec 18 2017

5295840a4cf9 Restore the "Download from Git LFS" UI button to Diffusion
Author
epriestley
Revisions
D18828: Restore the "Download from Git LFS" UI button to Diffusion
Browse Repository
Passed
No Audits

Dec 5 2017

46d496b8cc06 Fix error for URL's that could mean several commits
Author
lpriestley
Revisions
D18816: Fix error for URL's that could mean several commits
Browse Repository
Passed
No Audits

Dec 1 2017

42034e6739eb Property list view on Diffusion commits should show build status but not…
Author
lpriestley
Revisions
D18813: Property list view on Diffusion commits should show build status but not Subscriptions, Projects, or Tokens
Browse Repository
Passed
No Audits

Nov 30 2017

5240cffd9c20 Fix an issue where Diffusion could fatal if the default branch was deleted
Author
epriestley
Revisions
D18811: Fix an issue where Diffusion could fatal if the default branch was deleted
Browse Repository
Passed
No Audits

Oct 31 2017

80ebe401e584 Tweak padding/spacing on Diffusion blame view for profile pictures
Author
epriestley
Revisions
D18749: Tweak padding/spacing on Diffusion blame view for profile pictures
Browse Repository
Passed
No Audits