Diffusion Phabricator (master) History

phabricator/src/applications/differential/storage
master

Mar 15 2021

01ea84029d88 Update table schema for "AffectedPath" table
Author
epriestley
Revisions
D21617: Update table schema for "AffectedPath" table
Browse Repository
Passed
No Audits

38ef910da8ca Move "Affected Path" index updates to a separate class
Author
epriestley
Revisions
D21616: Move "Affected Path" index updates to a separate class
Browse Repository
Passed
No Audits

Feb 23 2021

6bfa990254a2 When mapping phantom comments across changes, correct an off-by-one issue
Author
epriestley
Revisions
D21572: When mapping phantom comments across changes, correct an off-by-one issue
Browse Repository
Passed
No Audits

Feb 15 2021

9feb7343e662 Provide a "differential.changeset.search" Conduit API method
Author
epriestley
Revisions
D21558: Provide a "differential.changeset.search" Conduit API method
Browse Repository
Passed
No Audits

ec5476a01f5f Add a PHID to Changesets
Author
epriestley
Revisions
D21557: Add a PHID to Changesets
Browse Repository
Passed
No Audits

Feb 3 2021

9502312b60ae Remove "final" from "private" methods in Phabricator
Author
epriestley
Revisions
D21540: Remove "final" from "private" methods in Phabricator
Browse Repository
Passed
No Audits

Jul 22 2020

8f9ba4852861 Fix an issue with destruction of Revision and Diff objects with viewstates
Author
epriestley
Revisions
D21421: Fix an issue with destruction of Revision and Diff objects with viewstates
Browse Repository
Passed
No Audits

May 23 2020

a529efa5b855 Fix an issue where inline comments with only edit suggestions are considered…
Author
epriestley
Revisions
D21287: Fix an issue where inline comments with only edit suggestions are considered empty
Browse Repository
Passed
No Audits

May 20 2020

d3d41324be9f Drop old "differential_commit" table
Author
epriestley
Revisions
D21281: Drop old "differential_commit" table
Browse Repository
Passed
No Audits

6d0dbeb77f77 Use the changeset parse cache to cache suggestion changesets
Author
epriestley
Revisions
D21280: Use the changeset parse cache to cache suggestion changesets
Browse Repository
Passed
No Audits

846562158aae Roughly support inline comment suggestions
Author
epriestley
Revisions
D21276: Roughly support inline comment suggestions
Browse Repository
Passed
No Audits

May 7 2020

1656a2ff081a Allow inline comment storage objects to generate their own runtime objects
Author
epriestley
Revisions
D21226: Allow inline comment storage objects to generate their own runtime objects
Browse Repository
Passed
No Audits

May 4 2020

a590db28b254 Fix an issue where non-ID changeset state keys were used as changeset IDs
Author
epriestley
Revisions
D21223: Fix an issue where non-ID changeset state keys were used as changeset IDs
Browse Repository
Passed
No Audits

6430d6d638eb Fix an intradiff error when the newer changeset does not exist
Author
epriestley
Revisions
D21220: Fix an intradiff error when the newer changeset does not exist
Browse Repository
Passed
No Audits

f5ef341c9e35 Don't publish "empty" inline comments
Author
epriestley
Revisions
D21211: Don't publish "empty" inline comments
Browse Repository
Passed
No Audits

67da18e37478 When users submit "editing" inlines, warn them that their inlines will be saved
Author
epriestley
Revisions
D21191: When users submit "editing" inlines, warn them that their inlines will be saved
Browse Repository
Passed
No Audits

b48a22bf50a3 Make "editing" state persistent for inline comments
Author
epriestley
Revisions
D21186: Make "editing" state persistent for inline comments
Browse Repository
Passed
No Audits

5ff0ae7d48a7 Add generic "attributes" storage to inline comment tables
Author
epriestley
Revisions
D21184: Add generic "attributes" storage to inline comment tables
Browse Repository
Passed
No Audits

17426a60f00a Fix an issue where text intradiff bodies may not render
Author
epriestley
Revisions
D21210: Fix an issue where text intradiff bodies may not render
Browse Repository
Passed
No Audits

Apr 30 2020

304467feb2ae Stabilize fatals when a build has a build plan the viewer can't see because of…
Author
epriestley
Revisions
D21194: Stabilize fatals when a build has a build plan the viewer can't see because of policy restrictions
Browse Repository
Passed
No Audits

Apr 28 2020

f21f1d8ab9e9 Update the diff table of contents to use hierarchical views and edit distance…
Author
epriestley
Revisions
D21183: Update the diff table of contents to use hierarchical views and edit distance renames
Browse Repository
Passed
No Audits

befeb17f6ff1 Improve the construction of synthetic "comparison/intradiff" changesets
Author
epriestley
Revisions
D21180: Improve the construction of synthetic "comparison/intradiff" changesets
Browse Repository
Passed
No Audits

Apr 27 2020

c12db282519d For changesets that affect binaries, use the new binary file content hash as an…
Author
epriestley
Revisions
D21174: For changesets that affect binaries, use the new binary file content hash as an effect hash
Browse Repository
Passed
No Audits

Apr 23 2020

d05d8f655896 Add a very forgiving GC for Differential viewstate information
Author
epriestley
Revisions
D21164: Add a very forgiving GC for Differential viewstate information
Browse Repository
Passed
No Audits

Apr 22 2020

60de1506fe3b Make "hidden" changesets sticky, and show hidden state in the filetree
Author
epriestley
Revisions
D21158: Make "hidden" changesets sticky, and show hidden state in the filetree
Browse Repository
Passed
No Audits

a72a66caa833 Mark "low importance" and "owned" changes in the filetree
Author
epriestley
Revisions
D21157: Mark "low importance" and "owned" changes in the filetree
Browse Repository
Passed
No Audits

ff88eb588eb4 Show change information in file icons in the filetree
Author
epriestley
Revisions
D21156: Show change information in file icons in the filetree
Browse Repository
Passed
No Audits

Apr 19 2020

8aac55cc57cb Make "Highlight As..." sticky across reloads in Diffusion and Differential
Author
epriestley
Revisions
D21137: Make "Highlight As..." sticky across reloads in Diffusion and Differential
Browse Repository
Passed
No Audits

Apr 13 2020

471e89a8b76d Add "uri" to "paste.search" API output
Author
epriestley
Revisions
D21105: Add "uri" to "paste.search" API output
Browse Repository
Passed
No Audits

19e0abcb27b4 Fix an issue where raw diffs that are not attached to revisions could skip…
Author
epriestley
Revisions
D21103: Fix an issue where raw diffs that are not attached to revisions could skip repository policy checks
Browse Repository
Passed
No Audits

5597f4e6f229 Add "uri" to the fields returned by "differential.revision.search"
Author
epriestley
Revisions
D21102: Add "uri" to the fields returned by "differential.revision.search"
Browse Repository
Passed
No Audits

Feb 13 2020

dc35ce79e484 Unprototype "Draft" mode in Differential
Author
epriestley
Revisions
D20983: Unprototype "Draft" mode in Differential
Browse Repository
Passed
No Audits

Aug 22 2019

353155a2034e Add "modifiedStart" and "modifiedEnd" constraints to "differential.revision.
Author
epriestley
Revisions
D20730: Add "modifiedStart" and "modifiedEnd" constraints to "differential.revision.search"
Browse Repository
Passed
No Audits

May 22 2019

fa4dcaa3aaff Stabilize sorting of feed stories with similar strength
Author
epriestley
Revisions
D20540: Stabilize sorting of feed stories with similar strength
Browse Repository
Passed
No Audits

May 1 2019

a15b0063df3d Add "Revision has passing builds" Herald rules for commit content (pushes) and…
Author
epriestley
Browse Repository
Passed
No Audits

Apr 24 2019

42c02557e4e3 Remove all remaining readers and writers for TABLE_COMMIT
Author
epriestley
Revisions
D20461: Remove all remaining readers and writers for TABLE_COMMIT
Browse Repository
Passed
No Audits

ec0085fd0c7a Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table
Author
epriestley
Revisions
D20459: Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table
Browse Repository
Passed
No Audits

7e8dc0742bdc Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()"
Author
epriestley
Revisions
D20458: Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()"
Browse Repository
Passed
No Audits

Mar 6 2019

718cdc24471a Implement Build Plan "Hold Drafts" behavior
Author
epriestley
Revisions
D20232: Implement Build Plan "Hold Drafts" behavior
Browse Repository
Passed
No Audits

Feb 19 2019

5310f1cdd90e Remove all whitespace options/configuration everywhere
Author
epriestley
Revisions
D20185: Remove all whitespace options/configuration everywhere
Browse Repository
Passed
No Audits

Feb 16 2019

c5e16f9bd996 Give HarbormasterBuildUnitMessage a real Query class
Author
epriestley
Revisions
D20179: Give HarbormasterBuildUnitMessage a real Query class
Browse Repository
Passed
No Audits

Dec 20 2018

11cf8f05b176 Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface
Author
epriestley
Revisions
D19920: Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface
Browse Repository
Passed
No Audits

937e88c399ab Remove obsolete, no-op implementations of "willRenderTimeline()"
Author
epriestley
Revisions
D19919: Remove obsolete, no-op implementations of "willRenderTimeline()"
Browse Repository
Passed
No Audits

6c43d1d52cbd Remove "willRenderTimeline()" from ApplicationTransactionInterface
Author
epriestley
Revisions
D19918: Remove "willRenderTimeline()" from ApplicationTransactionInterface
Browse Repository
Passed
No Audits

Sep 7 2018

046c1b5b828d Expose "isDraft" and "holdAsDraft" revision properties over Conduit
Author
epriestley
Revisions
D19648: Expose "isDraft" and "holdAsDraft" revision properties over Conduit
Browse Repository
Passed
No Audits

Jul 20 2018

67283c7a4526 Add test plan to differential.revision.search
Author
amckinley
Revisions
D19518: Add test plan to differential.revision.search
Browse Repository
Passed
No Audits

May 17 2018

8f9b9484471a When showing a diff-of-diffs, hide files which didn't get any more changes and…
Author
epriestley
Revisions
D19453: When showing a diff-of-diffs, hide files which didn't get any more changes and have no inlines
Browse Repository
Passed
No Audits

79fdf5c12707 Separate changeset analysis code from DifferentialDiff and provide a standalone…
Author
epriestley
Revisions
D19452: Separate changeset analysis code from DifferentialDiff and provide a standalone `rebuild-changesets` workflow
Browse Repository
Passed
No Audits

May 5 2018

5e2af4b9b5cd Prepare to support an "Ignore generated files" flag in Owners
Author
epriestley
Revisions
D19426: Prepare to support an "Ignore generated files" flag in Owners
Browse Repository
Passed
No Audits

af295341c863 Classify changesets as "generated" at creation time, in addition to display time
Author
epriestley
Revisions
D19425: Classify changesets as "generated" at creation time, in addition to display time
Browse Repository
Passed
No Audits

Apr 20 2018

843bfb4fd8ac Add a "commits" attachment to "differential.diff.search" for retrieving local…
Author
epriestley
Revisions
D19386: Add a "commits" attachment to "differential.diff.search" for retrieving local commit information
Browse Repository
Passed
No Audits

Apr 16 2018

b5f23b023e3c Add an "--auto" flag to "bin/differential migrate-hunk"
Author
epriestley
Revisions
D19371: Add an "--auto" flag to "bin/differential migrate-hunk"
Browse Repository
Passed
No Audits

Apr 5 2018

f01c2e36948b Remove "Large Changes" documentation and make some minor behavioral improvements
Author
epriestley
Revisions
D19298: Remove "Large Changes" documentation and make some minor behavioral improvements
Browse Repository
Passed
No Audits

Apr 3 2018

e70c9f72a48e Show revision sizes using a perplexing, inexplicable symbol code
Author
epriestley
Revisions
D19294: Show revision sizes using a perplexing, inexplicable symbol code
Browse Repository
Passed
No Audits

615d27c8e97f Show an additional "Draft" tag on non-broadcasting revisions in a non-draft…
Author
epriestley
Revisions
D19285: Show an additional "Draft" tag on non-broadcasting revisions in a non-draft state
Browse Repository
Passed
No Audits

38e788c99a78 Partially decouple revision broadcasting from revision draft state
Author
epriestley
Revisions
D19284: Partially decouple revision broadcasting from revision draft state
Browse Repository
Passed
No Audits

3b5a7d1c88c4 Rename the Differential "hasBroadcast" flag to "shouldBroadcast"
Author
epriestley
Revisions
D19283: Rename the Differential "hasBroadcast" flag to "shouldBroadcast"
Browse Repository
Passed
No Audits

f350b9e4646b Explicitly condition Differential draft promotion on only "impactful" builds
Author
epriestley
Revisions
D19282: Explicitly condition Differential draft promotion on only "impactful" builds
Browse Repository
Passed
No Audits

51461f18c15b When publishing buildables in Differential, ignore autobuilds (local lint and…
Author
epriestley
Revisions
D19281: When publishing buildables in Differential, ignore autobuilds (local lint and unit)
Browse Repository
Passed
No Audits

95c9d403f4a3 Make objects implementing BuildableInterface produce a BuildableEngine
Author
epriestley
Revisions
D19278: Make objects implementing BuildableInterface produce a BuildableEngine
Browse Repository
Passed
No Audits

Mar 13 2018

1e93b49b1bf2 Allow custom actions in Differential to explicitly override "accept" stickiness
Author
epriestley
Revisions
D19211: Allow custom actions in Differential to explicitly override "accept" stickiness
Browse Repository
Passed
No Audits

Mar 6 2018

743d1ac426fb Mostly modularize the Differential "update" transaction
Author
epriestley
Revisions
D19175: Mostly modularize the Differential "update" transaction
Browse Repository
Passed
No Audits

Feb 12 2018

6f508a225869 Update buildable containerPHIDs in a proper way via BuildWorker rather than via…
Author
epriestley
Revisions
D19066: Update buildable containerPHIDs in a proper way via BuildWorker rather than via sneaky uncoordinated write
Browse Repository
Passed
No Audits

Feb 11 2018

f43d08c2bbe6 Completely remove the legacy hunk table
Author
epriestley
Revisions
D19057: Completely remove the legacy hunk table
Browse Repository
Passed
No Audits

b0d1d46a73f9 Drop the legacy hunk table
Author
epriestley
Revisions
D19056: Drop the legacy hunk table
Browse Repository
Passed
No Audits

Feb 9 2018

6ea1b8df9bbb Colorize filetree for adds, moves, and deletes
Author
epriestley
Revisions
D19040: Colorize filetree for adds, moves, and deletes
Browse Repository
Passed
No Audits

Feb 8 2018

d0a2e3c54f9a Fix an issue where some Differential edit pathways may not have reviewers…
Author
epriestley
Revisions
D19022: Fix an issue where some Differential edit pathways may not have reviewers attached
Browse Repository
Passed
No Audits

1cd3a593784a When users resign from revisions, stop expanding projects/packages to include…
Author
epriestley
Revisions
D19021: When users resign from revisions, stop expanding projects/packages to include them
Browse Repository
Passed
No Audits

aa74af19834b Remove all "originalTitle"/"originalName" fields from objects
Author
epriestley
Revisions
D19013: Remove all "originalTitle"/"originalName" fields from objects
Browse Repository
Passed
No Audits

Feb 6 2018

1bf64e5cbcf4 Add Differential and Herald mail stamps and some refinements
Author
epriestley
Revisions
D18997: Add Differential and Herald mail stamps and some refinements
Browse Repository
Passed
No Audits

Jan 29 2018

de7f836f03e6 Wrap edge transaction readers in a translation layer
Author
epriestley
Revisions
D18946: Wrap edge transaction readers in a translation layer
Browse Repository
Passed
No Audits

Jan 23 2018

6b99aac49ddf Digest changeset anchors into purely alphanumeric strings
Author
epriestley
Revisions
D18909: Digest changeset anchors into purely alphanumeric strings
Browse Repository
Passed
No Audits

Jan 19 2018

3b7547e726ed Fix an issue where certain configurations could fail to publish revision feed…
Author
epriestley
Revisions
D18886: Fix an issue where certain configurations could fail to publish revision feed stories
Browse Repository
Passed
No Audits

Jan 4 2018

de6c68b91e57 Always show "X requested review" in mail to stop some undraft mail from being…
Author
epriestley
Revisions
D18851: Always show "X requested review" in mail to stop some undraft mail from being dropped
Browse Repository
Passed
No Audits

Dec 18 2017

a1ad184ddd8c Denormalize added and removed line counts for the current diff onto revisions
Author
epriestley
Revisions
D18832: Denormalize added and removed line counts for the current diff onto revisions
Browse Repository
Passed
No Audits

Nov 28 2017

54f131dc4baa Make "first broadcast" rules for Differential drafts more general
Author
epriestley
Revisions
D18801: Make "first broadcast" rules for Differential drafts more general
Browse Repository
Passed
No Audits

Nov 7 2017

cc865e549bcd Provide revision parent/child edges in `edge.search`, and more information in…
Author
epriestley
Revisions
D18762: Provide revision parent/child edges in `edge.search`, and more information in `differential.revision.search`
Browse Repository
Passed
No Audits

Nov 2 2017

6d36eb911309 Denormalize Diff PHIDs onto Revisions
Author
epriestley
Revisions
D18756: Denormalize Diff PHIDs onto Revisions
Browse Repository
Passed
No Audits

Oct 31 2017

28cec2f8a2bf Allow revisions to be held as drafts, even after builds finish
Author
epriestley
Revisions
D18737: Allow revisions to be held as drafts, even after builds finish
Browse Repository
Passed
No Audits

Oct 30 2017

0da3f34728e3 Provide "differential.diff.search"
Author
epriestley
Revisions
D18744: Provide "differential.diff.search"
Browse Repository
Passed
No Audits

Oct 23 2017

63e6b2553e0e Simply how Differential drafts ignore Harbormaster autobuilds
Author
epriestley
Revisions
D18721: Simply how Differential drafts ignore Harbormaster autobuilds
Browse Repository
Passed
No Audits

Oct 20 2017

1755ec242989 Show more detailed hints about draft revisions in the UI
Author
epriestley
Revisions
D18714: Show more detailed hints about draft revisions in the UI
Browse Repository
Passed
No Audits

bfabe49c5ae8 Start revisions in "Draft" if prototypes are enabled
Author
epriestley
Revisions
D18713: Start revisions in "Draft" if prototypes are enabled
Browse Repository
Passed
No Audits

Oct 9 2017

9bd6a3705559 Fix spelling
Author
0
Revisions
D18693: Fix spelling
Browse Repository
Failed
No Audits

Oct 4 2017

c767c971ca79 Add "persistence" types (data, cache, or index) to tables, and tweak what…
Author
epriestley
Revisions
D18682: Add "persistence" types (data, cache, or index) to tables, and tweak what "storage dump" dumps
Browse Repository
Passed
No Audits

Sep 29 2017

fe646ec32828 Mark Owners package reviewers which own nothing in the current diff
Author
epriestley
Revisions
D18663: Mark Owners package reviewers which own nothing in the current diff
Browse Repository
Passed
No Audits

Sep 21 2017

fca553f142a2 Prepare revision mail for the "Draft" status
Author
epriestley
Revisions
D18627: Prepare revision mail for the "Draft" status
Browse Repository
Passed
No Audits

Sep 18 2017

23867c148798 Add a "Draft" state for revisions, and action bucket support
Author
epriestley
Revisions
D18625: Add a "Draft" state for revisions, and action bucket support
Browse Repository
Passed
No Audits

156adccef0ad Fix an issue where "bin/differential migrate-hunk" could decompress data
Author
epriestley
Revisions
D18624: Fix an issue where "bin/differential migrate-hunk" could decompress data
Browse Repository
Passed
No Audits

Sep 11 2017

d15fb20fe6a9 Support storage of Differential hunk data in Files
Author
epriestley
Revisions
D18584: Support storage of Differential hunk data in Files
Browse Repository
Passed
No Audits

Sep 7 2017

2218caee0f50 Reduce the amount of boilerplate that implementing FerretInterface requires
Author
epriestley
Revisions
D18559: Reduce the amount of boilerplate that implementing FerretInterface requires
Browse Repository
Passed
No Audits

Sep 6 2017

e91d72fefbf9 Un-hide the "X added reviewers: ..." transactions in revision creation mail
Author
epriestley
Revisions
D18542: Un-hide the "X added reviewers: ..." transactions in revision creation mail
Browse Repository
Passed
No Audits

Sep 5 2017

f40f3ca74c91 Add Ferret engine index support to Differential
Author
epriestley
Revisions
D18540: Add Ferret engine index support to Differential
Browse Repository
Passed
No Audits

Aug 24 2017

ba1925b15515 Prevent Differential changeset HTML anchors from colliding with comment anchors
Author
epriestley
Revisions
D18465: Prevent Differential changeset HTML anchors from colliding with comment anchors
Browse Repository
Passed
No Audits

Aug 12 2017

48a74de0b649 Move all revision status transactions to modern values and mechanics
Author
epriestley
Revisions
D18419: Move all revision status transactions to modern values and mechanics
Browse Repository
Passed
No Audits

7b695aa43bd1 Migrate revision storage to modern status constants ("accepted") instead of…
Author
epriestley
Revisions
D18418: Migrate revision storage to modern status constants ("accepted") instead of legacy numeric values ("2")
Browse Repository
Passed
No Audits

5348f34c9eec Make all revision status readers explicitly read modern or legacy status
Author
epriestley
Revisions
D18417: Make all revision status readers explicitly read modern or legacy status
Browse Repository
Passed
No Audits

cd15c2d545ad Swap transactions and initialization over to modern status constants
Author
epriestley
Revisions
D18415: Swap transactions and initialization over to modern status constants
Browse Repository
Passed
No Audits

895f0cde1f0a Use modern revision statuses when bucketing revisions on the Differential…
Author
epriestley
Revisions
D18414: Use modern revision statuses when bucketing revisions on the Differential dashboard
Browse Repository
Passed
No Audits

7f743c14d532 Remove remaining ArcanistDifferentialRevisionStatus references in revision…
Author
epriestley
Revisions
D18413: Remove remaining ArcanistDifferentialRevisionStatus references in revision state logic
Browse Repository
Passed
No Audits