Diffusion Phabricator (master) History

phabricator/src/applications/differential/render
master

Mar 29 2021

428fff2e58f3 Fix an issue when undoing mutiple inline comment deletions
Author
epriestley
Revisions
D21650: Fix an issue when undoing mutiple inline comment deletions
Browse Repository
Passed
No Audits

Aug 5 2020

98e0440d459b In 1-up source diffs, retain the "No newline at end of file" on "\" lines
Author
epriestley
Revisions
D21433: In 1-up source diffs, retain the "No newline at end of file" on "\" lines
Browse Repository
Passed
No Audits

May 20 2020

10f241352dce Render inline comment suggestions as real diffs
Author
epriestley
Revisions
D21277: Render inline comment suggestions as real diffs
Browse Repository
Passed
No Audits

May 14 2020

3ee6b5393c77 Improve offset/range inline behavior for rich diffs and unified diffs
Author
epriestley
Revisions
D21257: Improve offset/range inline behavior for rich diffs and unified diffs
Browse Repository
Passed
No Audits

May 12 2020

df139f044b9b Render proper "Show Context" links in DocumentEngine diffs, not just bullets
Author
epriestley
Revisions
D21243: Render proper "Show Context" links in DocumentEngine diffs, not just bullets
Browse Repository
Passed
No Audits

May 4 2020

b48a22bf50a3 Make "editing" state persistent for inline comments
Author
epriestley
Revisions
D21186: Make "editing" state persistent for inline comments
Browse Repository
Passed
No Audits

Apr 28 2020

befeb17f6ff1 Improve the construction of synthetic "comparison/intradiff" changesets
Author
epriestley
Revisions
D21180: Improve the construction of synthetic "comparison/intradiff" changesets
Browse Repository
Passed
No Audits

Apr 26 2020

b0c295e54509 Fix some PHP 7.4 array index access issues
Author
epriestley
Revisions
D21172: Fix some PHP 7.4 array index access issues
Browse Repository
Passed
No Audits

Nov 8 2019

d4491ddc225e Fix an issue with 1up diff block rendering for added or removed blocks
Author
epriestley
Revisions
D20897: Fix an issue with 1up diff block rendering for added or removed blocks
Browse Repository
Passed
No Audits

Oct 26 2019

8ff0e3ab351f Support rich diff rendering with DocumentEngine for added/removed files
Author
epriestley
Revisions
D20865: Support rich diff rendering with DocumentEngine for added/removed files
Browse Repository
Passed
No Audits

Sep 30 2019

76d9912932bc Force unified abstract block diffs into roughly usable shape
Author
epriestley
Revisions
D20848: Force unified abstract block diffs into roughly usable shape
Browse Repository
Passed
No Audits

d9515e82a3ec Perform basic block interdiffs when diffing abstract blocks, and interdiff…
Author
epriestley
Revisions
D20845: Perform basic block interdiffs when diffing abstract blocks, and interdiff markdown in Jupyter notebooks
Browse Repository
Passed
No Audits

5afdc620db59 Make basic Juypter notebook rendering improvements and roughly support folding…
Author
epriestley
Revisions
D20844: Make basic Juypter notebook rendering improvements and roughly support folding unchanged context
Browse Repository
Passed
No Audits

a7f3316aa3df Improve sequencing of various content/header checks in abstract block diffs
Author
epriestley
Revisions
D20843: Improve sequencing of various content/header checks in abstract block diffs
Browse Repository
Passed
No Audits

Sep 26 2019

2c06815edb0f When rendering Jupyter notebook diffs, split code inputs into individual blocks
Author
epriestley
Revisions
D20840: When rendering Jupyter notebook diffs, split code inputs into individual blocks
Browse Repository
Passed
No Audits

Sep 25 2019

281598d65cfc Use a hash-and-diff strategy to produce a diff layout for block-based documents
Author
epriestley
Revisions
D20836: Use a hash-and-diff strategy to produce a diff layout for block-based documents
Browse Repository
Passed
No Audits

932d829af339 Improve behavior of inline comment highlight reticle for block diffs
Author
epriestley
Revisions
D20835: Improve behavior of inline comment highlight reticle for block diffs
Browse Repository
Passed
No Audits

a09b298d85d7 Correct DOM node metadata to let inline comments work against block-based diffs
Author
epriestley
Revisions
D20834: Correct DOM node metadata to let inline comments work against block-based diffs
Browse Repository
Passed
No Audits

1c4450d39f9b Allow the Jupyter engine to elect to emit diffs, and emit Jupyter documents as…
Author
epriestley
Revisions
D20833: Allow the Jupyter engine to elect to emit diffs, and emit Jupyter documents as blocks
Browse Repository
Passed
No Audits

bb71ef6ad6cd Render image diffs as abstract blocks diffs via DocumentEngine
Author
epriestley
Revisions
D20831: Render image diffs as abstract blocks diffs via DocumentEngine
Browse Repository
Passed
No Audits

Apr 1 2019

cddbe306f927 Correct a case where a single-hunk diff may incorrectly be identified as multi…
Author
epriestley
Revisions
D20363: Correct a case where a single-hunk diff may incorrectly be identified as multi-hunk by the Scope engine
Browse Repository
Passed
No Audits

Mar 7 2019

a3ebaac0f026 Tweak the visual style of the ">>" / "<<" depth change indicators slightly
Author
epriestley
Revisions
D20251: Tweak the visual style of the ">>" / "<<" depth change indicators slightly
Browse Repository
Passed
No Audits

Feb 20 2019

1b8325642112 Don't enable the "ScopeEngine" or try to identify scope context for diffs…
Author
epriestley
Revisions
D20198: Don't enable the "ScopeEngine" or try to identify scope context for diffs without context
Browse Repository
Passed
No Audits

f1a035d5c2c6 In Differential, give the "moved/copied from" gutter a more clear visual look
Author
epriestley
Revisions
D20197: In Differential, give the "moved/copied from" gutter a more clear visual look
Browse Repository
Passed
No Audits

Feb 19 2019

fe7047d12d69 Display some invisible/nonprintable characters in diffs by default
Author
epriestley
Revisions
D20194: Display some invisible/nonprintable characters in diffs by default
Browse Repository
Passed
No Audits

efccd75ae371 Correct various minor diff copy behaviors
Author
epriestley
Revisions
D20192: Correct various minor diff copy behaviors
Browse Repository
Passed
No Audits

37f12a05ea62 Behold! Copy text from either side of a diff!
Author
epriestley
Revisions
D20191: Behold! Copy text from either side of a diff!
Browse Repository
Passed
No Audits

d4b96bcf6b01 Remove hidden zero-width spaces affecting copy behavior
Author
epriestley
Revisions
D20189: Remove hidden zero-width spaces affecting copy behavior
Browse Repository
Passed
No Audits

98fe8fae4a90 Use `<td class="n" data-n="3">` instead of `<th>3</th>` for line numbers
Author
epriestley
Revisions
D20188: Use `<td class="n" data-n="3">` instead of `<th>3</th>` for line numbers
Browse Repository
Passed
No Audits

5310f1cdd90e Remove all whitespace options/configuration everywhere
Author
epriestley
Revisions
D20185: Remove all whitespace options/configuration everywhere
Browse Repository
Passed
No Audits

661c758ff9d1 Render indent depth changes more clearly
Author
epriestley
Revisions
D20181: Render indent depth changes more clearly
Browse Repository
Passed
No Audits

92abe3c8fb84 Extract scope line selection logic from the diff rendering engine so it can…
Author
epriestley
Revisions
D20171: Extract scope line selection logic from the diff rendering engine so it can reasonably be iterated on
Browse Repository
Passed
No Audits

Jun 8 2018

f37542717774 Use more consistent diff coloration in unified diffs
Author
epriestley
Revisions
D19482: Use more consistent diff coloration in unified diffs
Browse Repository
Passed
No Audits

May 14 2018

26d0862f4f6f Apply the new patch byte size limit to mail patch generation in Differential
Author
epriestley
Revisions
D19445: Apply the new patch byte size limit to mail patch generation in Differential
Browse Repository
Passed
No Audits

Oct 20 2017

672247eff30b Add aural "+" and "-" hints to unified diffs for users who use screenreaders
Author
epriestley
Revisions
D18718: Add aural "+" and "-" hints to unified diffs for users who use screenreaders
Browse Repository
Passed
No Audits

May 17 2017

422eb9db837d Correct the generation of "<th />" IDs on left-hand-side of image changesets
Author
epriestley
Revisions
D17926: Correct the generation of "<th />" IDs on left-hand-side of image changesets
Browse Repository
Passed
No Audits

May 16 2017

4fd4ec3d275d Hide inlines one-by-one, instead of in a big group
Author
epriestley
Revisions
D17861: Hide inlines one-by-one, instead of in a big group
Browse Repository
Passed
No Audits

Feb 23 2017

84aff44bcd64 Add a "Red/Green Colorblind" accessibility mode, make all web UIs and email…
Author
epriestley
Revisions
D17269: Add a "Red/Green Colorblind" accessibility mode, make all web UIs and email respect it
Browse Repository
Passed
No Audits

Jan 4 2017

96fbf37dcc11 Bring up contrast on light green / red diffs
Author
Chad Little <chad@phacility.com>
Revisions
D17141: Bring up contrast on light green / red diffs
Browse Repository
Passed
No Audits

Jun 6 2016

e1119b3f315b Render more info for binary files in Differential
Author
avivey
Revisions
D15828: Render more info for binary files in Differential
Browse Repository
Passed
No Audits

May 12 2016

bd9bcaa8ffea Improve HTML mail rendering of inline patches
Author
epriestley
Revisions
D15901: Improve HTML mail rendering of inline patches
Browse Repository
Passed
No Audits

May 6 2016

412fc3455730 Improve inline mail snippet rendering, possibly fixing Airmail?
Author
epriestley
Revisions
D15864: Improve inline mail snippet rendering, possibly fixing Airmail?
Browse Repository
Passed
No Audits

053d6111e4ab Refine inline style rendering in email
Author
epriestley
Revisions
D15857: Refine inline style rendering in email
Browse Repository
Passed
No Audits

May 5 2016

1baef494c1b7 Pick context windows for inlines in a slightly smarter way
Author
epriestley
Revisions
D15853: Pick context windows for inlines in a slightly smarter way
Browse Repository
Passed
No Audits

94c7bb605c35 Highlight inline diff context in HTML mail
Author
epriestley
Revisions
D15852: Highlight inline diff context in HTML mail
Browse Repository
Passed
No Audits

Apr 1 2016

61301ead90e4 Fix javascript interaction with right-hand-side images in two-up diff views in…
Author
epriestley
Revisions
D15566: Fix javascript interaction with right-hand-side images in two-up diff views in Differential
Browse Repository
Passed
No Audits

Jun 15 2015

b6d745b66687 Extend from Phobject
Author
joshuaspence
Revisions
D13283: Extend from Phobject
Browse Repository
No Builds
No Audits

Jun 8 2015

929f5f22acef Fix an issue with adding or updating images in unified diff view
Author
epriestley
Revisions
D13217: Fix an issue with adding or updating images in unified diff view
Browse Repository
No Builds
No Audits

May 27 2015

e9f4a84a892c Allow inline comments to be individually hidden
Author
epriestley
Revisions
D13009: Allow inline comments to be individually hidden
Browse Repository
No Builds
No Audits

May 22 2015

36e2d02d6ec5 phtize all the things
Author
joshuaspence
Revisions
D12797: phtize all the things
Browse Repository
No Builds
No Audits

May 7 2015

a238f6a7598a Implement rough content-aware inline adjustment rules for ghosts
Author
epriestley
Revisions
D12741: Implement rough content-aware inline adjustment rules for ghosts
Browse Repository
No Builds
No Audits

Mar 28 2015

a17542ab28c2 Touch up PHP/JS interactions for inline comments
Author
epriestley
Revisions
D12186: Touch up PHP/JS interactions for inline comments
Browse Repository
No Builds
No Audits

Mar 27 2015

174cf8239802 Provide getObjectOwnerPHID() on inline comment views
Author
epriestley
Revisions
D12185: Provide getObjectOwnerPHID() on inline comment views
Browse Repository
No Builds
No Audits

Mar 24 2015

21826ed7b35a Don't highlight very large files by default
Author
epriestley
Revisions
D12132: Don't highlight very large files by default
Browse Repository
No Builds
No Audits

4310c4ed5387 Track a "Done" state on inline comments
Author
epriestley
Revisions
D12033: Track a "Done" state on inline comments
Browse Repository
No Builds
No Audits

Mar 9 2015

f1f2c5d01df1 Reduce code duplication in inline right/left side tracking
Author
epriestley
Revisions
D12024: Reduce code duplication in inline right/left side tracking
Browse Repository
No Builds
No Audits

56a970900856 Reduce code duplication for inline "Undo"
Author
epriestley
Revisions
D12019: Reduce code duplication for inline "Undo"
Browse Repository
No Builds
No Audits

Mar 6 2015

68fa70eacbc8 Make images work in the unified diff view
Author
epriestley
Revisions
D12003: Make images work in the unified diff view
Browse Repository
No Builds
No Audits

f9cb366f0071 Remove duplicate inline scaffold in 2up renderer
Author
epriestley
Revisions
D12000: Remove duplicate inline scaffold in 2up renderer
Browse Repository
No Builds
No Audits

ac60b23ef9e2 Remove duplicate inline row scaffold in 1up renderer
Author
epriestley
Revisions
D11998: Remove duplicate inline row scaffold in 1up renderer
Browse Repository
No Builds
No Audits

1352be827e12 Begin separating inline comment scaffolding from other renderers
Author
epriestley
Revisions
D11997: Begin separating inline comment scaffolding from other renderers
Browse Repository
No Builds
No Audits

1088d34e58eb Rename inline comment views to "PHUIDiff" and give them a base class
Author
epriestley
Revisions
D11996: Rename inline comment views to "PHUIDiff" and give them a base class
Browse Repository
No Builds
No Audits

0af80c1d90e9 Further improve line grouping in unified views
Author
epriestley
Revisions
D11994: Further improve line grouping in unified views
Browse Repository
No Builds
No Audits

b3d1ecebc7f8 Fix another issue with line order on unified diffs
Author
epriestley
Revisions
D11992: Fix another issue with line order on unified diffs
Browse Repository
No Builds
No Audits

Mar 5 2015

bd5985e67db6 Add "Copy" and "Coverage" columns to unified view
Author
epriestley
Revisions
D11985: Add "Copy" and "Coverage" columns to unified view
Browse Repository
No Builds
No Audits

a8c9f2e8b09f Fix an issue where inlines appear in the wrong place in one-up views
Author
epriestley
Revisions
D11987: Fix an issue where inlines appear in the wrong place in one-up views
Browse Repository
No Builds
No Audits

35c1dbf1f8a4 Unify changeset line ID rendering and bring it to unified diffs
Author
epriestley
Revisions
D11983: Unify changeset line ID rendering and bring it to unified diffs
Browse Repository
No Builds
No Audits

cb886eb60eed Share code for context link rendering on side-by-side diffs
Author
epriestley
Revisions
D11981: Share code for context link rendering on side-by-side diffs
Browse Repository
No Builds
No Audits

ad3c94dd454f Make "Show Context" persist rendering, whitespace, encoding, etc
Author
epriestley
Revisions
D11977: Make "Show Context" persist rendering, whitespace, encoding, etc
Browse Repository
No Builds
No Audits

06df75ebbd4f Render "Show Context" blocks in unified view
Author
epriestley
Revisions
D11976: Render "Show Context" blocks in unified view
Browse Repository
No Builds
No Audits

79cb47116ed1 Provide "diff-1up" and "diff-2up" classes and tweak some styles
Author
epriestley
Revisions
D11974: Provide "diff-1up" and "diff-2up" classes and tweak some styles
Browse Repository
No Builds
No Audits

17702f398424 Improve display of "Context not available" in 1-up view
Author
epriestley
Revisions
D11973: Improve display of "Context not available" in 1-up view
Browse Repository
No Builds
No Audits

c82066408d1b Expand Differential test coverage to include moves, shields, and more
Author
epriestley
Revisions
D11970: Expand Differential test coverage to include moves, shields, and more
Browse Repository
No Builds
No Audits

Feb 10 2015

aaf8d73ec798 Fix `pht` method calls
Author
joshuaspence
Revisions
D11680: Fix `pht` method calls
Browse Repository
No Builds
No Audits

Jan 30 2015

77eae81e1a5c Policy - fix up DifferentialChangesetParser
Author
btrahan
Revisions
D11579: Policy - fix up DifferentialChangesetParser
Browse Repository
No Builds
No Audits

Nov 15 2014

00b245a56679 Set up colspec for differential 1up
Author
avivey
Revisions
D10854: Set up colspec for differential 1up
Browse Repository
No Builds
No Audits

Oct 7 2014

3cf9a5820fc9 Minor formatting changes
Author
joshuaspence
Revisions
D10585: Minor formatting changes
Browse Repository
No Builds
No Audits

Aug 19 2014

0057cf17e9d0 Clean up image file diffs UI
Author
chad
Revisions
D10296: Clean up image file diffs UI
Browse Repository
No Builds
No Audits

Aug 13 2014

1ad0e845188a Show image dimensions and some other metadata in Differential
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 21 2014

8999a1c1ea55 Utilize `PhutilMethodNotImplementedException`
Author
joshuaspence
Revisions
D10000: Utilize `PhutilMethodNotImplementedException`
Browse Repository
No Builds
No Audits

Jun 29 2014

c1af499ed7ab Only show text encoding note in Differential if a change has hunks
Author
epriestley
Revisions
D9780: Only show text encoding note in Differential if a change has hunks
Browse Repository
No Builds
No Audits

Jun 20 2014

b20884a842a6 Substantially support character encodings and "Highlight As" in changesets
Author
epriestley
Revisions
D9294: Substantially support character encodings and "Highlight As" in changesets
Browse Repository
No Builds
No Audits

Jun 9 2014

0a62f13464b8 Change double quotes to single quotes.
Author
joshuaspence
Revisions
D9431: Change double quotes to single quotes.
Browse Repository
No Builds
No Audits

Jun 4 2014

71e9fb96b56e Move more hunk loads into DifferentialHunkQuery
Author
epriestley
Revisions
D9287: Move more hunk loads into DifferentialHunkQuery
Browse Repository
No Builds
No Audits

Apr 9 2014

a7272dfb03d0 Switch back to zwsp for oncopy line marker
Author
sophiebits
Revisions
D8727: Switch back to zwsp for oncopy line marker
Browse Repository
No Builds
No Audits

Apr 3 2014

a0ac3d67168b Add colgroup in differential "shield" tables
Author
sophiebits
Revisions
D8693: Add colgroup in differential "shield" tables
Browse Repository
No Builds
No Audits

9fedd343eb18 Break long words in differential two-up view
Author
sophiebits
Revisions
D8686: Break long words in differential two-up view
Browse Repository
No Builds
No Audits

Nov 11 2013

a29b5b070f5a Replace some hsprintf() by phutil_tag()
Author
vrana
Revisions
D7549: Replace some hsprintf() by phutil_tag()
Browse Repository
No Builds
No Audits

Oct 2 2013

3c34cdce5adf Abstract raw diff rendering into DifferentialRawDiffRenderer
Author
zeeg
Browse Repository
No Builds
No Audits

Sep 12 2013

ab2ae9e47fa3 Differential - make sure not to return change type header if we're not top level
Author
btrahan
Browse Repository
No Builds
No Audits

Feb 19 2013

0d38bca11ff8 Fix function/method declaration lint in Phabricator. Automatic patches.
Author
epriestley
Browse Repository
No Builds
Audited

a22bea2a74cf Apply lint rules to Phabricator
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 17 2013

2231e5200ac3 Implement basic transaction detail blocks
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 13 2013

262abd39bc32 Fix undefined variable "none"
Author
epriestley
Browse Repository
No Builds
No Audits

4eb84149c2f1 Convert everything to safe HTML
Author
vrana
Browse Repository
No Builds
No Audits

Feb 11 2013

37b98450a57b Replace array_interleave() by phutil_implode_html()
Author
vrana
Browse Repository
No Builds
No Audits

Feb 8 2013

d817dfa8fcce Convert some phutil_escape_html() to hsprintf()
Author
vrana
Browse Repository
No Builds
No Audits

Feb 2 2013

6e959011611a Convert phutil_render_tag() to phutil_tag() for inline comments
Author
vrana
Browse Repository
No Builds
No Audits

Jan 30 2013

0a9f378594f0 render_tag -> tag: Differential Changeset stuff
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 25 2013

3093d1663de4 Add javelin_tag(), convert easy callsites
Author
epriestley
Browse Repository
No Builds
No Audits