Diffusion Phabricator (master) History

phabricator/src/applications/differential/editor
master

Mar 15 2021

26c68942bd00 Update "AffectedPath" table when a revision's repository changes
Author
epriestley
Revisions
D21618: Update "AffectedPath" table when a revision's repository changes
Browse Repository
Passed
No Audits

38ef910da8ca Move "Affected Path" index updates to a separate class
Author
epriestley
Revisions
D21616: Move "Affected Path" index updates to a separate class
Browse Repository
Passed
No Audits

c317d16bdd56 Lift peculiar side effect of path indexing out of indexer
Author
epriestley
Revisions
D21614: Lift peculiar side effect of path indexing out of indexer
Browse Repository
Passed
No Audits

Mar 4 2021

fceb9a3f9e1d Hide the "Author" field in Differential on the web create workflow
Author
epriestley
Revisions
D21595: Hide the "Author" field in Differential on the web create workflow
Browse Repository
Passed
No Audits

Mar 3 2021

dec14136844d Provide a more general "Author" transaction for Differential
Author
epriestley
Revisions
D21591: Provide a more general "Author" transaction for Differential
Browse Repository
Passed
No Audits

May 20 2020

846562158aae Roughly support inline comment suggestions
Author
epriestley
Revisions
D21276: Roughly support inline comment suggestions
Browse Repository
Passed
No Audits

May 7 2020

94a95efa059a Replace "loadUnsubmittedInlineComments()" with a modern "DiffQuery"
Author
epriestley
Revisions
D21234: Replace "loadUnsubmittedInlineComments()" with a modern "DiffQuery"
Browse Repository
Passed
No Audits

May 4 2020

fe501bd7f736 Save drafts for inline comments currently being edited
Author
epriestley
Revisions
D21216: Save drafts for inline comments currently being edited
Browse Repository
Passed
No Audits

468aabd4ef30 When draft inline comments are submitted, disengage the editor
Author
epriestley
Revisions
D21188: When draft inline comments are submitted, disengage the editor
Browse Repository
Passed
No Audits

Jun 18 2019

753828649956 Fix missing link targets for "View Object" header buttons in HTML email
Author
epriestley
Revisions
D20586: Fix missing link targets for "View Object" header buttons in HTML email
Browse Repository
Passed
No Audits

May 30 2019

9a32a563f047 Add a "View Task" button to HTML mail from Maniphest
Author
epriestley
Revisions
D20561: Add a "View Task" button to HTML mail from Maniphest
Browse Repository
Passed
No Audits

May 22 2019

1eff4fdca332 Prevent "Differential Revision: ..." from counting as a mention in commit…
Author
epriestley
Revisions
D20544: Prevent "Differential Revision: ..." from counting as a mention in commit messages
Browse Repository
Passed
No Audits

May 1 2019

a78f141b3fa8 Unify code for parsing "Reverts X" magic, and when something "reverts <hash>"…
Author
epriestley
Browse Repository
Passed
No Audits

Apr 2 2019

c9d3fb2ac5b6 Fix the incorrect link target for "Create Revision" as a Menu Item
Author
epriestley
Revisions
D20360: Fix the incorrect link target for "Create Revision" as a Menu Item
Browse Repository
Passed
No Audits

Feb 28 2019

814e6d2de927 Add more type checking to transactions queued by Herald
Author
epriestley
Revisions
D20214: Add more type checking to transactions queued by Herald
Browse Repository
Passed
No Audits

Feb 1 2019

bc61d09f5553 Allow parent and child revisions to be modified via Conduit
Author
epriestley
Revisions
D20075: Allow parent and child revisions to be modified via Conduit
Browse Repository
Passed
No Audits

Jan 18 2019

c125ab7a42bf Remove "metamta.*.subject-prefix" options
Author
epriestley
Revisions
D19993: Remove "metamta.*.subject-prefix" options
Browse Repository
Passed
No Audits

Jan 4 2019

73e3057c52f4 Rename "MetaMTA" mail attachments and add more mail message objects
Author
epriestley
Revisions
D19954: Rename "MetaMTA" mail attachments and add more mail message objects
Browse Repository
Passed
No Audits

Dec 10 2018

46feccdfcf19 Share more inline "Done" code between Differential and Diffusion
Author
epriestley
Revisions
D19858: Share more inline "Done" code between Differential and Diffusion
Browse Repository
Passed
No Audits

1029081b2805 Correct two straggling "%Q" + "implode(...)" callsites in Revision updates
Author
epriestley
Revisions
D19846: Correct two straggling "%Q" + "implode(...)" callsites in Revision updates
Browse Repository
Passed
No Audits

Nov 28 2018

2f11001f6e3c Allow "Change Subtype" to be selected from the comment action stack
Author
epriestley
Revisions
D19842: Allow "Change Subtype" to be selected from the comment action stack
Browse Repository
Passed
No Audits

Nov 26 2018

97e7ef0f015c When the last rejecting reviewer resigns from a revision, return it to "Needs…
Author
epriestley
Revisions
D19840: When the last rejecting reviewer resigns from a revision, return it to "Needs Review"
Browse Repository
Passed
No Audits

Oct 5 2018

99034efa8b8d Make Pholio mail render without a ton of over-escaped HTML
Author
epriestley
Revisions
D19733: Make Pholio mail render without a ton of over-escaped HTML
Browse Repository
Passed
No Audits

Sep 7 2018

16a6fc8341ea Allow reviewers to mark their own inlines as "Done" before they submit them
Author
epriestley
Revisions
D19634: Allow reviewers to mark their own inlines as "Done" before they submit them
Browse Repository
Passed
No Audits

Sep 6 2018

e8e5dc0f5690 Make a language improvement ("inlines" -> "inline comments")
Author
epriestley
Revisions
D19644: Make a language improvement ("inlines" -> "inline comments")
Browse Repository
Passed
No Audits

041392988ece When a transaction adds more than 100 inline comments, include only the first…
Author
epriestley
Revisions
D19632: When a transaction adds more than 100 inline comments, include only the first 100 in email
Browse Repository
Passed
No Audits

Aug 24 2018

5e4d9dfa9219 Condition "Changes Since Last Action" Differential link on "first broadcast"…
Author
epriestley
Revisions
D19598: Condition "Changes Since Last Action" Differential link on "first broadcast", not "new object"
Browse Repository
Passed
No Audits

Jul 27 2018

9e451879d998 Add a "Changes Since Last Action" view to Differential revisions
Author
epriestley
Revisions
D19541: Add a "Changes Since Last Action" view to Differential revisions
Browse Repository
Passed
No Audits

Jun 12 2018

62a402491ae4 Allow encrypted mail to be more specific about which object is affected
Author
epriestley
Revisions
D19488: Allow encrypted mail to be more specific about which object is affected
Browse Repository
Passed
No Audits

May 14 2018

26d0862f4f6f Apply the new patch byte size limit to mail patch generation in Differential
Author
epriestley
Revisions
D19445: Apply the new patch byte size limit to mail patch generation in Differential
Browse Repository
Passed
No Audits

May 5 2018

5e2af4b9b5cd Prepare to support an "Ignore generated files" flag in Owners
Author
epriestley
Revisions
D19426: Prepare to support an "Ignore generated files" flag in Owners
Browse Repository
Passed
No Audits

Apr 20 2018

9bf4df2c1ddf Allow demoted builds to automatically promote if builds pass after a restart
Author
epriestley
Revisions
D19380: Allow demoted builds to automatically promote if builds pass after a restart
Browse Repository
Passed
No Audits

Apr 12 2018

c52e10d1ecf0 Respect external unmentionable PHIDs in Differential revision editor
Author
epriestley
Revisions
D19361: Respect external unmentionable PHIDs in Differential revision editor
Browse Repository
Passed
No Audits

Apr 3 2018

e70c9f72a48e Show revision sizes using a perplexing, inexplicable symbol code
Author
epriestley
Revisions
D19294: Show revision sizes using a perplexing, inexplicable symbol code
Browse Repository
Passed
No Audits

6f520e053462 Clean up an old transaction state flag
Author
epriestley
Revisions
D19290: Clean up an old transaction state flag
Browse Repository
Passed
No Audits

804f9817c3e2 When a draft's builds fail and it demotes to "Changes Planned + Draft", notify…
Author
epriestley
Revisions
D19289: When a draft's builds fail and it demotes to "Changes Planned + Draft", notify the author (only) via email
Browse Repository
Passed
No Audits

adf8fdef0e89 When remote builds fail, demote revisions to "Changes Planned + But, Still A…
Author
epriestley
Revisions
D19287: When remote builds fail, demote revisions to "Changes Planned + But, Still A Draft"
Browse Repository
Passed
No Audits

615d27c8e97f Show an additional "Draft" tag on non-broadcasting revisions in a non-draft…
Author
epriestley
Revisions
D19285: Show an additional "Draft" tag on non-broadcasting revisions in a non-draft state
Browse Repository
Passed
No Audits

38e788c99a78 Partially decouple revision broadcasting from revision draft state
Author
epriestley
Revisions
D19284: Partially decouple revision broadcasting from revision draft state
Browse Repository
Passed
No Audits

3b5a7d1c88c4 Rename the Differential "hasBroadcast" flag to "shouldBroadcast"
Author
epriestley
Revisions
D19283: Rename the Differential "hasBroadcast" flag to "shouldBroadcast"
Browse Repository
Passed
No Audits

f350b9e4646b Explicitly condition Differential draft promotion on only "impactful" builds
Author
epriestley
Revisions
D19282: Explicitly condition Differential draft promotion on only "impactful" builds
Browse Repository
Passed
No Audits

Mar 13 2018

1e93b49b1bf2 Allow custom actions in Differential to explicitly override "accept" stickiness
Author
epriestley
Revisions
D19211: Allow custom actions in Differential to explicitly override "accept" stickiness
Browse Repository
Passed
No Audits

Mar 9 2018

1763b516b158 Fix missing parameter in parent call for Differential button text
Author
epriestley
Revisions
D19205: Fix missing parameter in parent call for Differential button text
Browse Repository
Passed
No Audits

Mar 8 2018

2de06a5375c6 Add some more UI reminder text about draft revisions
Author
epriestley
Revisions
D19204: Add some more UI reminder text about draft revisions
Browse Repository
Passed
No Audits

Mar 7 2018

d14a0f4787b5 Add "All" and "With Non-Owner Author" options for all Owners Package autoreview…
Author
epriestley
Revisions
D19180: Add "All" and "With Non-Owner Author" options for all Owners Package autoreview rules
Browse Repository
Passed
No Audits

Mar 6 2018

743d1ac426fb Mostly modularize the Differential "update" transaction
Author
epriestley
Revisions
D19175: Mostly modularize the Differential "update" transaction
Browse Repository
Passed
No Audits

Feb 12 2018

6f508a225869 Update buildable containerPHIDs in a proper way via BuildWorker rather than via…
Author
epriestley
Revisions
D19066: Update buildable containerPHIDs in a proper way via BuildWorker rather than via sneaky uncoordinated write
Browse Repository
Passed
No Audits

Feb 8 2018

d0a2e3c54f9a Fix an issue where some Differential edit pathways may not have reviewers…
Author
epriestley
Revisions
D19022: Fix an issue where some Differential edit pathways may not have reviewers attached
Browse Repository
Passed
No Audits

1cd3a593784a When users resign from revisions, stop expanding projects/packages to include…
Author
epriestley
Revisions
D19021: When users resign from revisions, stop expanding projects/packages to include them
Browse Repository
Passed
No Audits

f090fa7426e4 Use object PHIDs for "Thread-Topic" headers in mail
Author
epriestley
Revisions
D19012: Use object PHIDs for "Thread-Topic" headers in mail
Browse Repository
Passed
No Audits

Feb 2 2018

032f5b22941f Allow revisions to revert commits and one another, and commits to revert…
Author
epriestley
Revisions
D18978: Allow revisions to revert commits and one another, and commits to revert revisions
Browse Repository
Passed
No Audits

Jan 26 2018

fd66ab55791e Always use the same set of transactions to generate mail and mail tags
Author
epriestley
Revisions
D18941: Always use the same set of transactions to generate mail and mail tags
Browse Repository
Passed
No Audits

Jan 24 2018

dabd3f0b417b Fix a race between Harbormaster and reviewers (often bots) to publish drafts…
Author
epriestley
Revisions
D18921: Fix a race between Harbormaster and reviewers (often bots) to publish drafts for review
Browse Repository
Passed
No Audits

Dec 18 2017

a1ad184ddd8c Denormalize added and removed line counts for the current diff onto revisions
Author
epriestley
Revisions
D18832: Denormalize added and removed line counts for the current diff onto revisions
Browse Repository
Passed
No Audits

Dec 5 2017

6d3baa92f908 Execute Herald again after promoting revisions out of the "Draft" state
Author
epriestley
Revisions
D18819: Execute Herald again after promoting revisions out of the "Draft" state
Browse Repository
Passed
No Audits

Nov 28 2017

54f131dc4baa Make "first broadcast" rules for Differential drafts more general
Author
epriestley
Revisions
D18801: Make "first broadcast" rules for Differential drafts more general
Browse Repository
Passed
No Audits

Nov 14 2017

314e7266c3e5 Restore "Summary" and "Test Plan" to initial mail for non-draft configurations
Author
epriestley
Revisions
D18771: Restore "Summary" and "Test Plan" to initial mail for non-draft configurations
Browse Repository
Passed
No Audits

Nov 2 2017

03d059dd26e2 Don't include resigned reviewers in the Differential "To" list
Author
epriestley
Revisions
D18758: Don't include resigned reviewers in the Differential "To" list
Browse Repository
Passed
No Audits

6d36eb911309 Denormalize Diff PHIDs onto Revisions
Author
epriestley
Revisions
D18756: Denormalize Diff PHIDs onto Revisions
Browse Repository
Passed
No Audits

Oct 31 2017

a4b934cad2b5 Clean up Differential draft mail behaviors
Author
epriestley
Revisions
D18748: Clean up Differential draft mail behaviors
Browse Repository
Passed
No Audits

7fa0d066bc45 Don't run Herald build rules when Differential revisions are updated…
Author
epriestley
Revisions
D18745: Don't run Herald build rules when Differential revisions are updated automatically
Browse Repository
Passed
No Audits

28cec2f8a2bf Allow revisions to be held as drafts, even after builds finish
Author
epriestley
Revisions
D18737: Allow revisions to be held as drafts, even after builds finish
Browse Repository
Passed
No Audits

Oct 27 2017

f7f3dd5b2084 Don't run Herald build and mail rules when they don't make sense
Author
epriestley
Revisions
D18731: Don't run Herald build and mail rules when they don't make sense
Browse Repository
Passed
No Audits

Oct 26 2017

beaf0ad9a636 Attribute revision promotion from "Draft" to "Needs Review" to the author
Author
epriestley
Revisions
D18730: Attribute revision promotion from "Draft" to "Needs Review" to the author
Browse Repository
Passed
No Audits

Oct 20 2017

1755ec242989 Show more detailed hints about draft revisions in the UI
Author
epriestley
Revisions
D18714: Show more detailed hints about draft revisions in the UI
Browse Repository
Passed
No Audits

Oct 9 2017

9bd6a3705559 Fix spelling
Author
0
Revisions
D18693: Fix spelling
Browse Repository
Failed
No Audits

Sep 21 2017

36df39761ea5 Create revisions into "Draft", publish them when builds finish
Author
epriestley
Revisions
D18628: Create revisions into "Draft", publish them when builds finish
Browse Repository
Passed
No Audits

fca553f142a2 Prepare revision mail for the "Draft" status
Author
epriestley
Revisions
D18627: Prepare revision mail for the "Draft" status
Browse Repository
Passed
No Audits

Sep 13 2017

6fb3f857fb57 Stop the bleeding caused by attaching enormous patches to revision mail
Author
epriestley
Revisions
D18598: Stop the bleeding caused by attaching enormous patches to revision mail
Browse Repository
Passed
No Audits

Aug 24 2017

9639ec0dfabd Slightly simplify logic for determining if an inline comment has an effect
Author
epriestley
Revisions
D18468: Slightly simplify logic for determining if an inline comment has an effect
Browse Repository
Passed
No Audits

Aug 12 2017

48a74de0b649 Move all revision status transactions to modern values and mechanics
Author
epriestley
Revisions
D18419: Move all revision status transactions to modern values and mechanics
Browse Repository
Passed
No Audits

5348f34c9eec Make all revision status readers explicitly read modern or legacy status
Author
epriestley
Revisions
D18417: Make all revision status readers explicitly read modern or legacy status
Browse Repository
Passed
No Audits

7f743c14d532 Remove remaining ArcanistDifferentialRevisionStatus references in revision…
Author
epriestley
Revisions
D18413: Remove remaining ArcanistDifferentialRevisionStatus references in revision state logic
Browse Repository
Passed
No Audits

2b9838b482af Modularize remaining TYPE_ACTION transactions in Differential, reducing calls…
Author
epriestley
Revisions
D18412: Modularize remaining TYPE_ACTION transactions in Differential, reducing calls to ArcanistDifferentialRevisionStatus
Browse Repository
Passed
No Audits

19bc91fd208d Modularize the Differential "status" transaction and move away from…
Author
epriestley
Revisions
D18410: Modularize the Differential "status" transaction and move away from ArcanistDifferentialRevisionStatus
Browse Repository
Passed
No Audits

Aug 11 2017

153e4d8a383c Remove old reviewer double writes to legacy edge table in Differential
Author
epriestley
Revisions
D18398: Remove old reviewer double writes to legacy edge table in Differential
Browse Repository
Passed
No Audits

Apr 30 2017

b7c4f60e235d Only recognize "Fixes ..." in main revision content like the Summary or Test…
Author
epriestley
Revisions
D17805: Only recognize "Fixes ..." in main revision content like the Summary or Test Plan
Browse Repository
Passed
No Audits

Apr 11 2017

af1d494d66e9 Fix an issue where rejecting reviewers weren't powerful enough
Author
epriestley
Revisions
D17653: Fix an issue where rejecting reviewers weren't powerful enough
Browse Repository
Passed
No Audits

Apr 5 2017

f70ff34d97e8 Fix a copy/paste typo with sticky accept
Author
epriestley
Browse Repository
Passed
Audited

Apr 3 2017

9ebb5f8cda56 Don't downgrade accepts on update (fix "sticky accept")
Author
epriestley
Revisions
D17605: Don't downgrade accepts on update (fix "sticky accept")
Browse Repository
Passed
No Audits

Mar 28 2017

2fbc9a52da9b Allow users to "Force accept" package reviews if they own a more general package
Author
epriestley
Revisions
D17569: Allow users to "Force accept" package reviews if they own a more general package
Browse Repository
Passed
No Audits

ddc02ce420a5 When voiding "Accept" reviews, also void "Reject" reviews
Author
epriestley
Revisions
D17568: When voiding "Accept" reviews, also void "Reject" reviews
Browse Repository
Passed
No Audits

415ad784844e Remove old code for "Request Review" action from Differential
Author
epriestley
Revisions
D17567: Remove old code for "Request Review" action from Differential
Browse Repository
Passed
No Audits

aea46e55dac0 Fix an issue where "Request Review" of a fully-accepted revision would…
Author
epriestley
Revisions
D17566: Fix an issue where "Request Review" of a fully-accepted revision would transition to "Accepted"
Browse Repository
Passed
No Audits

Mar 21 2017

0ceab7d36f91 Rename "getReviewerStatus()" to "getReviewers()"
Author
epriestley
Revisions
D17522: Rename "getReviewerStatus()" to "getReviewers()"
Browse Repository
Passed
No Audits

Mar 20 2017

a15df4f8d580 Rename "needReviewerStatus()" into "needReviewers()"
Author
epriestley
Revisions
D17519: Rename "needReviewerStatus()" into "needReviewers()"
Browse Repository
Passed
No Audits

794b456530bc Store "last comment" and "last action" diffs on reviewers
Author
epriestley
Revisions
D17514: Store "last comment" and "last action" diffs on reviewers
Browse Repository
Passed
No Audits

77b3efafbd4e Use ModularTransactions for accept/reject/resign in "differential.createcomment"
Author
epriestley
Revisions
D17513: Use ModularTransactions for accept/reject/resign in "differential.createcomment"
Browse Repository
Passed
No Audits

a9cbbf3e5e15 Apply Owners reviewers using ModularTransactions
Author
epriestley
Revisions
D17512: Apply Owners reviewers using ModularTransactions
Browse Repository
Passed
No Audits

Jan 13 2017

e684794bf33d Get "Create Revision" out of Quick Create menu for now
Author
epriestley
Revisions
D17204: Get "Create Revision" out of Quick Create menu for now
Browse Repository
Passed
No Audits

Jan 10 2017

00e2755eab62 Provide tailored strings for revision creation
Author
epriestley
Revisions
D17170: Provide tailored strings for revision creation
Browse Repository
Passed
No Audits

Jan 5 2017

1f2306999bb5 Fix a case where "Accept + Comment" would ignore the "Accept"
Author
epriestley
Revisions
D17146: Fix a case where "Accept + Comment" would ignore the "Accept"
Browse Repository
Passed
No Audits

Dec 31 2016

69194fdaf510 Make marking comments as "Done" work cleanly on EditEngine
Author
epriestley
Revisions
D17120: Make marking comments as "Done" work cleanly on EditEngine
Browse Repository
Passed
No Audits

b373dcef7448 Restore some minor state behaviors to Differential on EditEngine
Author
epriestley
Revisions
D17118: Restore some minor state behaviors to Differential on EditEngine
Browse Repository
Passed
No Audits

18249b097fb6 Make inline comment preview and submission mostly work on EditEngine
Author
epriestley
Revisions
D17116: Make inline comment preview and submission mostly work on EditEngine
Browse Repository
Passed
No Audits

f7b5955d3386 Order actions sensibly within Differential revision comment action groups
Author
epriestley
Revisions
D17115: Order actions sensibly within Differential revision comment action groups
Browse Repository
Passed
No Audits

48fcfeadafe2 Allow comment actions to be grouped; group Differential "Review" and "Revision"…
Author
epriestley
Revisions
D17114: Allow comment actions to be grouped; group Differential "Review" and "Revision" actions
Browse Repository
Passed
No Audits

5a6643f36ff8 Restore "Accept", "Reject" and "Resign" actions to Differential on EditEngine
Author
epriestley
Revisions
D17113: Restore "Accept", "Reject" and "Resign" actions to Differential on EditEngine
Browse Repository
Passed
No Audits

3c5a17ba8a55 Restore "Reclaim" and "Abandon" actions to Differential on EditEngine
Author
epriestley
Revisions
D17107: Restore "Reclaim" and "Abandon" actions to Differential on EditEngine
Browse Repository
Passed
No Audits

c05306d746d7 Move Differential to EditEngine comments
Author
epriestley
Revisions
D17106: Move Differential to EditEngine comments
Browse Repository
Passed
No Audits